linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 0/5] reduce tasklist_lock hold time on exit and do some pid cleanup
@ 2025-02-05 19:32 Mateusz Guzik
  2025-02-05 19:32 ` [PATCH v4 1/5] exit: perform add_device_randomness() without tasklist_lock Mateusz Guzik
                   ` (4 more replies)
  0 siblings, 5 replies; 12+ messages in thread
From: Mateusz Guzik @ 2025-02-05 19:32 UTC (permalink / raw)
  To: ebiederm, oleg
  Cc: brauner, akpm, Liam.Howlett, linux-mm, linux-kernel, Mateusz Guzik

The clone side contends against exit side in a way which avoidably
exacerbates the problem by the latter waiting on locks held by the
former while holding the tasklist_lock.

Whacking this for both add_device_randomness and pids allocation gives
me a 15% speed up for thread creation/destruction in a 24-core vm.

The random patch is worth about 4%.

nothing blew up with lockdep, lightly tested so far

Bench (plop into will-it-scale):
$ cat tests/threadspawn1.c

char *testcase_description = "Thread creation and teardown";

static void *worker(void *arg)
{
	return (NULL);
}

void testcase(unsigned long long *iterations, unsigned long nr)
{
	pthread_t thread;
	int error;

	while (1) {
		error = pthread_create(&thread, NULL, worker, NULL);
		assert(error == 0);
		error = pthread_join(thread, NULL);
		assert(error == 0);
		(*iterations)++;
	}
}

v4:
- justify moving get_pid in the commit message with a one-liner
- drop the tty unref patch -- it is completely optional and Oleg has his
  own variant
- add the ACK by Oleg

v3:
- keep procfs flush where it was, instead hoist get_pid outside of the
  lock
- make detach_pid et al accept an array argument of pids to populate
- sprinkle asserts
- drop irq trips around pidmap_lock
- move tty unref outside of tasklist_lock


Mateusz Guzik (5):
  exit: perform add_device_randomness() without tasklist_lock
  exit: hoist get_pid() in release_task() outside of tasklist_lock
  pid: sprinkle tasklist_lock asserts
  pid: perform free_pid() calls outside of tasklist_lock
  pid: drop irq disablement around pidmap_lock

 include/linux/pid.h                   |   7 ++-
 kernel/exit.c                         |  36 +++++++----
 kernel/pid.c                          |  82 ++++++++++++++------------
 kernel/sys.c                          |  14 +++--
 scripts/selinux/genheaders/genheaders | Bin 90112 -> 0 bytes
 5 files changed, 82 insertions(+), 57 deletions(-)
 delete mode 100755 scripts/selinux/genheaders/genheaders

-- 
2.43.0



^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2025-02-05 20:58 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-05 19:32 [PATCH v4 0/5] reduce tasklist_lock hold time on exit and do some pid cleanup Mateusz Guzik
2025-02-05 19:32 ` [PATCH v4 1/5] exit: perform add_device_randomness() without tasklist_lock Mateusz Guzik
2025-02-05 19:55   ` Oleg Nesterov
2025-02-05 20:00     ` Mateusz Guzik
2025-02-05 19:32 ` [PATCH v4 2/5] exit: hoist get_pid() in release_task() outside of tasklist_lock Mateusz Guzik
2025-02-05 19:32 ` [PATCH v4 3/5] pid: sprinkle tasklist_lock asserts Mateusz Guzik
2025-02-05 20:26   ` Liam R. Howlett
2025-02-05 20:34     ` Mateusz Guzik
2025-02-05 20:42       ` Liam R. Howlett
2025-02-05 20:58         ` Mateusz Guzik
2025-02-05 19:32 ` [PATCH v4 4/5] pid: perform free_pid() calls outside of tasklist_lock Mateusz Guzik
2025-02-05 19:32 ` [PATCH v4 5/5] pid: drop irq disablement around pidmap_lock Mateusz Guzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox