From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C36B7C02192 for ; Wed, 5 Feb 2025 12:20:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BD806B007B; Wed, 5 Feb 2025 07:20:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 56E9B6B0083; Wed, 5 Feb 2025 07:20:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 483FE6B0082; Wed, 5 Feb 2025 07:20:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2A847280003 for ; Wed, 5 Feb 2025 07:20:27 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C6704120AAA for ; Wed, 5 Feb 2025 12:20:26 +0000 (UTC) X-FDA: 83085798852.29.40F81C8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 8876E100011 for ; Wed, 5 Feb 2025 12:20:24 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="QW8RK1/s"; spf=none (imf05.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738758025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2GD2f1+ZqTw4GQl694a5GY73mFn35yZd9oLR3uVjd78=; b=hb61QTYad+Uet0pV/bZVy9fsEcXU/IkaafwwmSFKLifZcYn30siO4EUfUbbP1t22WG/Wpg o1WqtBnmRVsl0TwnkU8IN6NzzFUrIgiugdgiTyx8BCeskSpJxd6CQMPohn4LNRhI7o/QMw nHAQ5tORFe1EdxHdKg/3zDgukH0lTF8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738758025; a=rsa-sha256; cv=none; b=ckVR4yHCuPD+TEargP4eN8s7nvs7HB7yhUaVCd1gyFZk+tJSXNoMyL8kDKdxkRx+M1cE66 prtBAXP61PduD7O94S4xzXF2oYLY2j4vdRl+r7AQjarGAbCzgCH7NcPUe2U41hxUHfuClE DP+M8meHB15TLpMmu2/1v2myhZ2Re9g= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="QW8RK1/s"; spf=none (imf05.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2GD2f1+ZqTw4GQl694a5GY73mFn35yZd9oLR3uVjd78=; b=QW8RK1/sH/tIlWsBK5Nz2B+l4X +5fkPTkQQmi15x9IO3gEp+aTPCgMZ+AsvzSJ8geKw3um3x6HeOjuMeTQmQx+cjSGcLSNmNe/ocvFs +ysIqBpjRhn8QxiggjiEC1sQdEC24+R45iCWscbFA5m1cP1p1hlYtNQDB6p0AY/l9bYcIXxdOu2CS IqywF31+klqkOsC9L8IBCVFm8pveJ5jp3hWVgDPSxN3Xmikr6b5AvwKrWJqBEc+9zNbdGRfAxgTDF RizMLtOUwV0MKhZXaDDx56dCrxfe5LEOLT97yGUHIK9plZUiUSut/f1ig61ATrOYm8rrO41v+czzo OYO+4oAQ==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tfeO1-00000004Omx-09ru; Wed, 05 Feb 2025 12:20:09 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id C8AC83002F0; Wed, 5 Feb 2025 13:20:07 +0100 (CET) Date: Wed, 5 Feb 2025 13:20:07 +0100 From: Peter Zijlstra To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Dave Hansen Subject: Re: [PATCH v8 03/12] x86/mm: consolidate full flush threshold decision Message-ID: <20250205122007.GH14028@noisy.programming.kicks-ass.net> References: <20250205014033.3626204-1-riel@surriel.com> <20250205014033.3626204-4-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250205014033.3626204-4-riel@surriel.com> X-Rspamd-Queue-Id: 8876E100011 X-Stat-Signature: aiuo7kgg55p9m4ni4es6apufoqrgqbmm X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1738758024-884860 X-HE-Meta: U2FsdGVkX18IoLyLplMnGprFP7JY36D26z2HtK+qkEMDM5RKsEryj//vPw9/4ETDh8yuykbrZBZ6UUCCGsSqvkOGcQEtmA8pSGEUpdAaK+Y6AiahOUAFKWXvf3el9IiA6PZBsz2pZx+76SQReinVrOZJriiYLDV8OoC+XHBdDo07PIqTkO6kr7zGKCdfkjhB1M5Tw/vZ9feGB3xXmYBNOLeKHgWrAsUR7MTciYUxSxuS4ivSvK9S1A76kINL9j8Aof5E4IL5wv9xsRE7j/PbWKFlLfDxTEh3ehpG0ai1xWtwpzsHsnlRbgHLb4CvRiQnU+AnKT2W8dJbnF5MUMFUi4XT69rp7EbRF9GnBrIeJuNjCFln9WYhHrjpFsYRyL1MinTAEoyLg7rH0FHovuvGwIvYe1lMipOPHdNb8wzjZTObDVIZCLEfbsSHU6L7W0CIHAW6jALzS21L5X45djdy6Zvjael8vaeCMu2ZHubPDnb6NAkDsV6fR12U14If5PnLCMkXhRtOeCuw/1lKgH/Ru3jJNoQ9Y9pdYs70JHVfV/UI5tX42lChZaGf2B5x/A7DO/FXfHyQQWeqbsHjjpCw0sSQVf65PzP5aiStZv27nGQQJ5DmZFfubaOCIuujlooH08dBpkAeRrW99145BQYqNxgauyuqIZR23tH1agKaiDp5v4tGm+CVlPQ4RZYCshQ/J+n9I8V0Fwb54Ro6VrlGPhBGho8hVkFi8+GzKsPmEvu5Dl+QCIUi0m5H+ZWNhtaf06uosIW29cGic719urdoQr5FejLo53n5hrnggk6/m89YiIN/ynv/WorSpsCN1CDOZ/cbSi6oSpJ/zP4Z2KUu14+817E4f2zVfQCPNF6u/MbiEk6Eqw4oW4B/J/bDpvn/uFwUp6UXLHqgvQIgkjifQ4LtOnD+w4GybzLV8zyYAFemEDUpGsKMO0bb2uXfdL986Ir69HImD4pXNk8LWF+ ++Wa7hQA Ss4lV14+cEtHC+OUYKP0z7SzPImO3g/qaNTPOGK1dyMI0MXEN9t7kjbxbdFhIsFJQA8Cm4TRQqbRmziYzHUFkczgvUvqKrJ2nHjCgXbY1r2MB9O6M1AbtZCncs0tQsNKBlBBuCTqDyUAGT5qMtq/Wf4qT5JBiS5yHE/BpkpPjLy3Re/L3cy0eVmypHkSv23vUGXSjExEUkvBGfu1UyEXZiWkWsWQ4PmIXlayvf7HbURwfkKW7FzVlKYbtCIlotZMxl6Zlbf5B32al4ZM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 04, 2025 at 08:39:52PM -0500, Rik van Riel wrote: > diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c > index 6cf881a942bb..02e1f5c5bca3 100644 > --- a/arch/x86/mm/tlb.c > +++ b/arch/x86/mm/tlb.c > @@ -1000,8 +1000,13 @@ static struct flush_tlb_info *get_flush_tlb_info(struct mm_struct *mm, > BUG_ON(this_cpu_inc_return(flush_tlb_info_idx) != 1); > #endif > > - info->start = start; > - info->end = end; > + /* > + * Round the start and end addresses to the page size specified > + * by the stride shift. This ensures partial pages at the end of > + * a range get fully invalidated. > + */ > + info->start = round_down(start, 1 << stride_shift); > + info->end = round_up(end, 1 << stride_shift); > info->mm = mm; > info->stride_shift = stride_shift; > info->freed_tables = freed_tables; Rather than doing this; should we not fix whatever dodgy users are feeding us non-page-aligned addresses for invalidation?