From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 373DFC02193 for ; Tue, 4 Feb 2025 23:13:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C31476B007B; Tue, 4 Feb 2025 18:13:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BDFBF6B009A; Tue, 4 Feb 2025 18:13:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A807A6B009D; Tue, 4 Feb 2025 18:13:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 895BB6B007B for ; Tue, 4 Feb 2025 18:13:51 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 491A41A02D9 for ; Tue, 4 Feb 2025 23:13:51 +0000 (UTC) X-FDA: 83083816662.30.D7CDE59 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 8967840009 for ; Tue, 4 Feb 2025 23:13:49 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iQsZwQiW; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738710829; a=rsa-sha256; cv=none; b=q4IH3DWS3zwGdP7hoMOqRQRQ+oW2WPW+vTDq2jUNCFPFWc2mERB0LAn+6H/cPWcV2LGA6h zVWWabTXrs6r66MXwelcR9AW7g04ujPBXTOPHmCR3dA6Io6v8QV+WdSlLBzv4m5aGgfJa2 9K+vYrWG9L4m8P3t8stMwuQ121xBIfc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iQsZwQiW; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738710829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7c3JU7oSWdLxSKitbmBJuUOl05CyIUMyYgY+kurito4=; b=vUGPvuRKuS7SoAvLUeAmm4lQE4wmnG5GQAS6/SI/DtHOTNHH2717xiiNOcmNFPaHoU3rmA E5zzRQwRltua3Qypax4dSOojifoL1nnP15+Gac7X5BMc5rg1dW2xjKj+FU+z9sfYDMhNz8 6VjvYBlVIESEJeyGZuia3LW+Q4gFNF8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D615F5C606F; Tue, 4 Feb 2025 23:13:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 307A8C4CEDF; Tue, 4 Feb 2025 23:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738710828; bh=1UaofT+c4ejJ6dFBaUjZ019vYzhreeikfVp4M9SwpGg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iQsZwQiW/kiHbPHPINpAHffeMprVBRYqmU6hnFUCdNhc+8v80bV+W3D4+OWBN7oY+ 0bkDTP2ii7GFXsDlaB1RT6KgNTnWgsW8tE9661Vdmxz+jzA6NsSxY1moT7uxNqzKig 4L7FMnl1tw7pIyIG7QTnW/fCPQUaGYfKprJqljgWagtiTGyS/CNmV37tpqccLLM3lG vTkwoB1apIwUpQ+dCnS70zHA1EmhoOlMp+8/rW5zhJ5PSqwkTARgUBoFW6YAE8hwKH RJ7ZUy4Dsv4AI1w2Hm2bbN+/WjZiRl+TM/hcFH6NRXIz/EhqbVJZlcAdyEn7CNcbtx aPqtbi6qtHQtg== From: SeongJae Park To: Usama Arif Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, hannes@cmpxchg.org, david@redhat.com, kernel-team@meta.com Subject: Re: [PATCH v4 6/6] Docs/admin-guide/mm/damon/usage: Document hugepage filter type Date: Tue, 4 Feb 2025 15:13:45 -0800 Message-Id: <20250204231345.2857-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250203225604.44742-7-usamaarif642@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 8967840009 X-Rspamd-Server: rspam10 X-Stat-Signature: 5k7joz85ss4dqnkgi6f4x39w93q1yap7 X-HE-Tag: 1738710829-855998 X-HE-Meta: U2FsdGVkX19ce/zHMNx+CYvUxd7uLytuUh1doq+wiokjfvifJzYOMEtpAJLtWE1tv+A8b1/d6iTUmgPRT9jPoQ+IpWGgKAlhARTx4wwYbi7qk377F/EeFzkgz+Rg0EErsd6Jhr8hi8wDF8P3DvX4LPWyIBJRzeSi3EAwGSpTV+0qfa0tEPPYEJ1OPwRUIKu+CDNcKo/ciAsmIsQz4JCn7HT23+XLdeHdJs0xLWitTPVkRixAKoEQYas+VHcPAO2bzjuDbVn7pIYdnlbXrBuGv8Nj9EnCquhX/k/Anek+MPfneFhxxLzTjDfX2nEtTi9Gb1JwvPlLRpZ8GGjGZ22/F10Mez557yG3UuQTLYht2L3hlIYQWX5bP/esT3tlJYJuB1USYFzYlcI27/2gbCtK22bflsr/mehb/s4PNiPjPbZDG6zOKRIU3ZFUBAj1y2JwXbfd91x84Icmz+6GvK2uiCoSwpaUXPf7svPaWW9YhTZ35rztSrHxK9q1EX28xGJAgluBh05cgO/xGzk6lnuXYdHvzlf+59mHGMELxAu949g1+DvXg81458LUO/WK3807ePfP5EBxZ1goBmJ8+bcrsStNhIP7bGnh2jDekb6FKRGgjVQsbkP6wXVwBEgAjfox/ACpHKX0KwXuksYWqgNB4e1p7GGu8I1ZPJIoTHqVYlOM8+VUWqCJCq3YphjiZThhWoDjNFoID8D9Pb74Q5Qy9Dx97b54WODCSZC8Vv3dGnso/qL63fl50wMJRaor9hkLp0BNCs9pCIhQyIEvXwvR1VXET05ldT8fv9Q13fHgTu44AQgoH6LhH+wZW1+z5ClH86i9P6eMGnThmEu2xeALFWbNce+RPzS3dXyNgJbdzExCzb57M+WE+c1nlU4ehQWTSfUTGd8aKWH2UqWFoVrw09AMyuWumiyS/FVrQlAchapheidEsc6MnN7jt1x0YiZje31zBqNWjTQqnXzNJxJ tTYIBUv7 KDiFvidyF6voGnXNFK+vp7T9P3YQY5JrT5jLIvWS5o5HQ22OHbLQb0x24vnel1ExA9QrE9WP6Enbo4uVRCLsJbhOuulHoG7KiJrbdkvu3IwmbbnOkbh6endlHKAw43wJX3S6Smso6bnRJOArNYD/u53f5tAR5VvVKsfZybwPt2s4zm8JvveDMWaNPTkCR36fNl5uTGFu1QSyo8U44qADSsjrh89XQ2OhXjGs4KyEMy11bk8PmSnrKU9PNbdtG8UwXdCWd9LXKencHQ1H27MTkBUMVbrmqQz8aiOpTUyyurBQzEbw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 3 Feb 2025 22:55:33 +0000 Usama Arif wrote: > This includes both the 'hugepage' filter type and the min/max > files used to decide range of sizes to filter on. > > Signed-off-by: Usama Arif > --- > Documentation/admin-guide/mm/damon/usage.rst | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst > index 47a44bd348ab..5765896aaa7e 100644 > --- a/Documentation/admin-guide/mm/damon/usage.rst > +++ b/Documentation/admin-guide/mm/damon/usage.rst > @@ -83,7 +83,7 @@ comma (","). > │ │ │ │ │ │ │ │ │ 0/target_metric,target_value,current_value > │ │ │ │ │ │ │ :ref:`watermarks `/metric,interval_us,high,mid,low > │ │ │ │ │ │ │ :ref:`filters `/nr_filters > - │ │ │ │ │ │ │ │ 0/type,matching,allow,memcg_path,addr_start,addr_end,target_idx > + │ │ │ │ │ │ │ │ 0/type,matching,allow,memcg_path,addr_start,addr_end,target_idx,min,max > │ │ │ │ │ │ │ :ref:`stats `/nr_tried,sz_tried,nr_applied,sz_applied,sz_ops_filter_passed,qt_exceeds > │ │ │ │ │ │ │ :ref:`tried_regions `/total_bytes > │ │ │ │ │ │ │ │ 0/start,end,nr_accesses,age,sz_filter_passed > @@ -406,13 +406,14 @@ number (``N``) to the file creates the number of child directories named ``0`` > to ``N-1``. Each directory represents each filter. The filters are evaluated > in the numeric order. > > -Each filter directory contains seven files, namely ``type``, ``matching``, > -``allow``, ``memcg_path``, ``addr_start``, ``addr_end``, and ``target_idx``. > -To ``type`` file, you can write one of five special keywords: ``anon`` for > -anonymous pages, ``memcg`` for specific memory cgroup, ``young`` for young > -pages, ``addr`` for specific address range (an open-ended interval), or > -``target`` for specific DAMON monitoring target filtering. Meaning of the > -types are same to the description on the :ref:`design doc > +Each filter directory contains nine files, namely ``type``, ``matching``, > +``allow``, ``memcg_path``, ``addr_start``, ``addr_end``, ``min``, ``max`` > +and ``target_idx``. To ``type`` file, you can write one of six special > +keywords: ``anon`` for anonymous pages, ``memcg`` for specific memory cgroup, > +``young`` for young pages, ``addr`` for specific address range (an open-ended > +interval), ``hugepage`` for large folios of a specific size range [``min``, I'd prefer naming it ``hugepage_size``. > +``max``] or ``target`` for specific DAMON monitoring target filtering. Meaning > +of the types are same to the description on the :ref:`design doc > `. > > In case of the memory cgroup filtering, you can specify the memory cgroup of > -- > 2.43.5 Thanks, SJ