From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DE2FC02193 for ; Tue, 4 Feb 2025 20:49:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 184466B0083; Tue, 4 Feb 2025 15:49:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1350F6B0085; Tue, 4 Feb 2025 15:49:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3E636B0088; Tue, 4 Feb 2025 15:49:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D36BF6B0083 for ; Tue, 4 Feb 2025 15:49:51 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7F4AD160325 for ; Tue, 4 Feb 2025 20:49:51 +0000 (UTC) X-FDA: 83083453782.25.882CAD4 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf05.hostedemail.com (Postfix) with ESMTP id 9D04A10000D for ; Tue, 4 Feb 2025 20:49:49 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b="bOFgX/iH"; dmarc=none; spf=pass (imf05.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.178 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738702189; a=rsa-sha256; cv=none; b=3dsm/nwIq3ncPXaqKqCVrludUGJh1/3WqXTt62S3W8Y3uIEzWQyqwtaF7HJoqw+L+DB118 KBZ4uO9DHDzB0gfh2luLuqSSgAKEfbfgL/1T6oADL3JlwJume+emKonYhgL00gK7Sh3xwd /3EQ03X16Hkx8Afu/yq+T9h5Ch7VoR0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b="bOFgX/iH"; dmarc=none; spf=pass (imf05.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.178 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738702189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VuMGfHPH8Rgkcs5TNo6U5Y3uMl+k/KNkpfdbRlCt8ps=; b=ax2kc9By/1G0feohbwMLa7d4kqlaJw45wYi2ZegzzB5fhOGzOdUFwX2uBUP+Xml0MZcct8 Cgsc+qqcpUs+jPuKloO5gIj/PH2exBrWF2IB+4YaaVzE+tM/r95sMwPTufOii2bQDxbJ5H swbohrA8lbVn4j+Gtz8yMCkoG0YsfNE= Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7b6e5ee6ac7so533274785a.0 for ; Tue, 04 Feb 2025 12:49:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1738702188; x=1739306988; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VuMGfHPH8Rgkcs5TNo6U5Y3uMl+k/KNkpfdbRlCt8ps=; b=bOFgX/iHL5oQp/jjLAYLlo6ymHDo/9ly8wuuoqIBqr6a8rU2NnGZiBgyXQ4FjEjndA kCvhiqxIt970zrJksuHEBHbHCKwH8qoIQVCTI0+IfFXTMtLPv/NgzcrNK51jiXdYogwu PeBAQOCjaBNJt+2M6y7kGFeyeamVWtZe/uXBKA2m+8jg1Iv8ERbzObvT4DRvzLaeabai qis9EHE4Ukaqo5wLSjZFmx+pYiOxtCm44bD27prCFM3yKEl5mJBSJRKMbVGgJmdIiZbI 2nJ4WDV4QdyuPSCULhN7pohuq78CkK3VnysAZjs51lmG1RTlSher8519VVcVhrjf3pAt DsBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738702188; x=1739306988; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VuMGfHPH8Rgkcs5TNo6U5Y3uMl+k/KNkpfdbRlCt8ps=; b=RuKefdL2ouIueWkorA2wNWY4ZnmgyPw/STvQ7cduPTx+DWdFp8oppVIdOM8U5YMTGX FXvZhRWDV7dsOxVMRTGBkZGEo8IYE46/pQlq0YWjPCseRAJ9UaDmn1e0gs1n0f8aWDXH aryODo4R1C0MI5fbw0iGmMKiVp3g6CG85wVKvWPvpYDGue2rXUr3Y5dVMUz6PsfK9lpz c4kcJxVynuWiSXa0bxCWJ3k/iVcfodcTkkmNxPA6Hs20F3pR0xt668NE6gArPCpyVEwk WXvVxy544wjW1gTPNs0iumzn2yzUfLRz46AIMwKznWM9O9GSbhcOPc93H66YK8QRNCiz 9Y8g== X-Forwarded-Encrypted: i=1; AJvYcCWkTwTlMi//lveJMWOYtWtoQJ9UE6GwpJYHeoHuUEU9cOftZNKLN/iS1BEEE3Hm045oa47/Wf+a6w==@kvack.org X-Gm-Message-State: AOJu0YxvVcP0cSXiqLw2JxYorgGhefwLplHMO37tE9YJ7rrrVsIK/YAd Q0Oy7RW6RKveBtJrwYbJSFRSFGiyDSnNcM46+SPHxWBxRnaZTIzxfzp7W8WAvuA= X-Gm-Gg: ASbGncs5grYnj4A1BCbmsxpm5MzybD3mLYoxqa8WDvkBRvdmYN1wUS32T35oP6te/YF Zf0P88SwsblGoQqaSY+WeZC+vFLk8WvQY9AqxYrh6Nnt6ez9dcjYxOBjsw/ZbbCBdEwEZxucLAU k7xWj6zO+mkq7YUtUSKfMn++hQIcV+G7a+2LvK2SKMPC8qUX7Vp0OZBlW0HMa+IH72MkY/BGodg IkH9p24EZwKIJPRCKcYxgr8IVPCUsuTXFnn6xFO06wZG3h9a8S2LzKIDRGlemXltw1uQcRerPYP JPM83p5xErb3bKgZTZiVft8SRMhG+ABDUzdbTngl6epyOnJqREi2o2O6gzAVqgPA X-Google-Smtp-Source: AGHT+IFCoy9O2sWsL/DnH3NCL2vtPB/0RnkG362y0xiW+CjQk353JmqEMZQpoug4xTMKjQExIBheCg== X-Received: by 2002:a05:622a:1993:b0:466:886f:3773 with SMTP id d75a77b69052e-470281859damr1708191cf.1.1738702188666; Tue, 04 Feb 2025 12:49:48 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46fdf1728c8sm62847861cf.56.2025.02.04.12.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2025 12:49:48 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tfPrf-0000000CeMf-150d; Tue, 04 Feb 2025 16:49:47 -0400 Date: Tue, 4 Feb 2025 16:49:47 -0400 From: Jason Gunthorpe To: David Hildenbrand Cc: Asahi Lina , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jann Horn , Matthew Wilcox , Paolo Bonzini , Danilo Krummrich , Wedson Almeida Filho , Valentin Obst , Andrew Morton , linux-mm@kvack.org, airlied@redhat.com, Abdiel Janulgue , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Subject: Re: [PATCH 0/6] rust: page: Support borrowing `struct page` and physaddr conversion Message-ID: <20250204204947.GM2296753@ziepe.ca> References: <20250202-rust-page-v1-0-e3170d7fe55e@asahilina.net> <1eaf66ba-b2d3-448f-938b-913f17ca98a4@redhat.com> <20250204183933.GJ2296753@ziepe.ca> <1d379007-97c3-4bb9-93da-1a828f955fc4@redhat.com> <20250204202656.GL2296753@ziepe.ca> <08ce9562-9ded-4d95-a495-b60f90d75490@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08ce9562-9ded-4d95-a495-b60f90d75490@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9D04A10000D X-Stat-Signature: k7fcmz1yyzz9hrt9p78ctm8cbw4s9t8r X-HE-Tag: 1738702189-3257 X-HE-Meta: U2FsdGVkX1/qaVcEibcY4q5AnaOmDhPwIa4T7xpknEKIXFq7GWS4OMXU5DXlcb83Zuhc+VRjsspV7yA/gJz++nlgORaD6ESI8gxom56zi7vUfdupdi9GnM+MAyM2IQ61P3Wep9vLdYu3SEay3XqtoETFTvIfhk5956fRs1CbqlZoybc9o3JyUi4pXCXGQAmAwi7WC017H0w6siGgBZ3pKetdN0uZ5m5C+7Xyc6IQBeCWnNHys3cayrKMhf86346dMAZlXLucDnbh6eWXzX8Bq0O7ZUIzzV6zG9aQVfdqDK80KCK395ciIx2gqJKSe3IKY09L5G0INLqswtNaHyxYnLEhoo5qMBGsGLOqCd00oGTbmXul+ohakOdHakp+ipNiSA0sr21iXU7hBjYWeir9OQRBPQPdiXjSt4JWClCTi/r9+/x/WV1I5kzmoOWSatURCKAv2Ah6T88N7t3nxHnvJkknPvyBatSbwA5w+mQ037hasQYWsW4Zj75+IBiw6vaMWXNkIxcOEYJxchPKNqnBvegf8/akianBY/6Cjktr8YE3RqJwTcg7PunvEnXS3KZmTWFpOlW/upxb7mLhVA5PbmrkRDS3e2XLaVJrSatZFyXBrcRpiPFd43GO/0d1P9/N2ZZUrMFvj3uIeyRljgUswMgPwMcgHfOF3iyIlisZoBpf6Nl45HdnHnxhx0R2+feSJofdRsbNV5lbOsXm2jN46G4e9xB+5v0sMs+8HedwY0jSoxYf8z0z3XvjeLOIucGoDz1nw7C8jgS7/GlYyHL9oIxXf3aLHCC/pkxv4gJrTvCuCQ1DP2B2sW/n++Gl6f6/53KDFkuMb5HSO1/Qs8jH4opWdOUV/pfgaPVJGI4DQopyXBBX56S1KoiQ+saLMNspKdNcN9jpKziBDxSqgp/KV5sTo+QwRgqbkrfMrilde//hHUdaNuYGDJWarmfk7a7TxeCngRTanHJGjVDsOjo j9iC231l 970eD38mMcEhee0XygNoyznfJLhDY2tqdiHcxCkioiWCSAJJrkH286ypEdmYQcTZXlBKZ+EWEsQVwhkCQq1yTlw0MI1jXWSAKVBd9KBVvE77Ckt+sGuf2BhMYnzmHTQsLq2bUeEHdTUQt2mF3p6UfaofU0Ktb1Ilzr8965qtH5OUG5t9pNW97DItv7l7vCwwD0rjfkrjBR1Du1rVrTt4fcOCesOwcmOWC+6m2FhvWlnktpP3lGgbsGYzWdPCex+0NgtBlJwD6vfSVw4k/8pzAuXDcZHk8lJel22Fspd8XOcaYvJ2GUI3967osnLnsKCDPTIZm8JtfqMN5WUg1gUsmSiKQK4LMS2uNAOBDMXWHkfoVi+E= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.500000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 04, 2025 at 09:41:29PM +0100, David Hildenbrand wrote: > On 04.02.25 21:26, Jason Gunthorpe wrote: > > On Tue, Feb 04, 2025 at 09:05:47PM +0100, David Hildenbrand wrote: > > > Fully agreed, this is going into the right direction. Dumping what's mapped > > > is a different story. Maybe that dumping logic could simply be written in C > > > for the time being? > > > > ? > > > > Isn't dumping just a > > decode pte -> phys_to_virt() -> for_each_u64(virt) -> printk? > > > > IIUC, the problematic bit is that you might not have a directmap such that > phys_to_virt() would tell you the whole story. The phys_to_virt() I mean is on the page table pages themselves, not on a leaf. All page table pages came from alloc_pages_node() and you'd do virt_to_phys() to stick them into a next-table PTE, then phys_to_virt() to bring them back: phys_to_virt(virt_to_phys(page_address(alloc_pages_node()))) Effectively. The leaf pages could be anything and you should enver phys_to_virt those, this is what I mean by: > > Or do you mean trying to decode the leaf entires into some struct page > > detail? Does a GPU need to do that? Agree that would be better as some > > C function to take in a KVA instead of a struct page and populate a > > string with details about that KVA from the struct page. Though I should have said phys_addr_t not KVA Jason