From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8522C02193 for ; Tue, 4 Feb 2025 20:27:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 125F86B007B; Tue, 4 Feb 2025 15:27:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D6416B0082; Tue, 4 Feb 2025 15:27:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB9316B0083; Tue, 4 Feb 2025 15:27:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CDBAA6B007B for ; Tue, 4 Feb 2025 15:27:00 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5AFBB160213 for ; Tue, 4 Feb 2025 20:27:00 +0000 (UTC) X-FDA: 83083396200.20.91AC6E2 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf22.hostedemail.com (Postfix) with ESMTP id 6643CC0006 for ; Tue, 4 Feb 2025 20:26:58 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=iO+qqKgo; spf=pass (imf22.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.41 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738700818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XKfHXyy6Lxo2g0AOAumrKv9sTaQK4qw2WswIObaTPeM=; b=iK5XkPI9naIM/mwBpcFFcH9IzGthk6naaMvHewdSICWzh2ewty/PR2e/DOL7ojJOBkPja0 ma7QAwvyfsjPe1Jy/snh7BivK9n/aqUVkWCvBZok7ewiWBudm9XErWsjBm1k+NI54WB26f gqlebKNRxNZFQkRKuGmej6GunJYuBo8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=iO+qqKgo; spf=pass (imf22.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.41 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738700818; a=rsa-sha256; cv=none; b=aiayhAgFM0cGV919P/LwOyur8mkM6AsWR3tQ+ux629Rbt/zcsfkKj7s6XMwYhLg+OoCrh2 Ta5hPh//ItjXgPZLxAgQZtl4iFHxfpS6ExjZZ/lhx2jVe2DuEzx/T+dVboAMVvZzQF6DyG zsWngeTilg7M1ieLsKz8cTA1rpyoJ3w= Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6e42f82ab88so1134996d6.1 for ; Tue, 04 Feb 2025 12:26:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1738700817; x=1739305617; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XKfHXyy6Lxo2g0AOAumrKv9sTaQK4qw2WswIObaTPeM=; b=iO+qqKgo+Z5hn++xbOTakJW5ySLjk7RKfn37Tc2J3mO7Oz0C2+u3r8R0PKuIOegoyB O3coFkhdDjkad2bBWpqYMTgkDEgTgcJl18RyHBF+2Ca1gZeVD5AOKbKrdW6XxJNk5YCK DNAoekNpj6cxSPMcPiyhqXrBhMrn68lEUJGB6qaYGHxo7GPSlKDDS0CH9GuSp6QU2X9F WYOe2NwCNqLmD1yS6POsRAIA0AGhlVywWmbU9FquwnLUxbd7Z+B1EqZjKh1Bov7E2Npx OYPew6Dgx8py8VmV4xU20p19hFAIlet2+wn/riP0X668bze4tEWvsLuUyrck8ZeJ/Uj2 Oi+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738700817; x=1739305617; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XKfHXyy6Lxo2g0AOAumrKv9sTaQK4qw2WswIObaTPeM=; b=gJ7J1joPcUFq6/K++ODpffcMFDu/O3rHzhEmXyr+eUQIdbiWBPlrgZL+ylLGvdoucj C2XBMDKLfUHNuIJVNFmODSzLYihW9D9Bq8YygiRZtoPUPYM9IIPGLgk9a93Jkia5oEQY MFHTbnzxOtgFQ9wwaQWrLtSZrBSWkGeNY6Jdvx+b911TYrHdzkEBgoCNVyn/TEe+Zrf3 Z4+nWtroPiKDHvnNRdmP7L0URTB4rRSkvmpJrAL6EbQR4z8ONq7kRRHLPF61Uas/FqC8 KGVUdYmzx9csspWKU88WFa8FcJN5xFcR11jVachNJbV0/Xke4ZbuS0DBejwekMpzxxiJ DR+g== X-Forwarded-Encrypted: i=1; AJvYcCW1Mnf7hYhaC7rdkOoc4i4Sv+aV6AqWpVslwSqhU/dSWfDRaGDE+Nftkyq4CBATSJs7Wh9vLIMcRA==@kvack.org X-Gm-Message-State: AOJu0YyNolhcdfYT97pzG85Pv+hOYW9iCji2zBlrFCWILGNXcEf5evng ST8OSRlh0JLi3Sn572OVcBp6mqQM5IXVnLbtks+nnr/XwiXglaG5hIonZ6cBxLg= X-Gm-Gg: ASbGnctuXETBV/pjaoWXeBgiYmII1q8pSKRK26Ly2qZasfn30odHD11hRi/atpudEfa 1yARONLVSUHBFuwRVD+TO16HujtOh0Fs01BsPuwtKlPcw/o5FoDvRIMEWyzzARrNoTGRz/nNBIR TaBni73hPJ/3llVTO7ie9acAcUtLMIfryX0s6ZmFNUubvydmlq40asd6X5KO0GvKeWhAaM4AX2z RN9fwfajT6Y6VAdnuQVxyov/3F9ddxKcy5kuAIG7oIA+2r6DHt/2WFDb50o4oOXRjZn+BykSiY/ EsHPiKRjf6ragJYdmS+TKLB+j1aydDeOxTFQsrf+dVC5WynXLpNtrnslHXHgHK8z X-Google-Smtp-Source: AGHT+IEsHxW8JLcluvuP8S+KAnuCNS+p1UBsZQIkGSJDtHpddXcm+6eR6EfbSxlm/LewurR5/XZ3Xg== X-Received: by 2002:ad4:5c46:0:b0:6d8:af2d:2a44 with SMTP id 6a1803df08f44-6e42fc54742mr2065826d6.32.1738700817497; Tue, 04 Feb 2025 12:26:57 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6e254922538sm65650296d6.84.2025.02.04.12.26.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2025 12:26:56 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tfPVY-0000000CYY9-1RWN; Tue, 04 Feb 2025 16:26:56 -0400 Date: Tue, 4 Feb 2025 16:26:56 -0400 From: Jason Gunthorpe To: David Hildenbrand Cc: Asahi Lina , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jann Horn , Matthew Wilcox , Paolo Bonzini , Danilo Krummrich , Wedson Almeida Filho , Valentin Obst , Andrew Morton , linux-mm@kvack.org, airlied@redhat.com, Abdiel Janulgue , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Subject: Re: [PATCH 0/6] rust: page: Support borrowing `struct page` and physaddr conversion Message-ID: <20250204202656.GL2296753@ziepe.ca> References: <20250202-rust-page-v1-0-e3170d7fe55e@asahilina.net> <1eaf66ba-b2d3-448f-938b-913f17ca98a4@redhat.com> <20250204183933.GJ2296753@ziepe.ca> <1d379007-97c3-4bb9-93da-1a828f955fc4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1d379007-97c3-4bb9-93da-1a828f955fc4@redhat.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6643CC0006 X-Stat-Signature: i117edu431xjauyywzb1838eye5wchft X-Rspam-User: X-HE-Tag: 1738700818-64837 X-HE-Meta: U2FsdGVkX1+WQdWLb+O7uMKoa0GFNDMKQaJyfn4EKZxU/HOxwgtWNwdVTiZHPUOJu0DoYrijYnhavAYxlLjta3CloqOAOI8gSRoZxn7qBuV/cVpae0c0BPD/q48Hkmoe3Sx6Mgz0QXmXFkOkMCHHMghbHIgxBR1oKg4WjzbM9MPkPFvUhB0IxFaLzgWBgZ9reKRFQcKiB2WT2uA2R7AMKw4QGfO2hhc68VecYRwkO+vKaSId8ioFEpHzu1IOu9DRNNQJSlRsY/TnIpzHf78QGI6RgyHqfswdZQ0ao0HbRsBJas63j7Y2bUIf9vGzrPV/D+IzoTECtiyURnqJR56G7LNURcKApU9CIw99xWEc+nS34FqOcAtT6eyW0cfsmVITSgtoeiN8qFiLh1Vbk06q1WzlmuEr+fcaiyAOv0P/XwCAqQguZKnK7ydEhDs2+6iivBIWWY+LC3VULogr0oGuyPqKFJDptC/CRyZmOoOnOuT/pP3WUiDnbI5wGvzYTD+5+0413yuWfx14NMlsq9izXUvnufCpq3X1sZTzRYmojMbAtEAXUj7CAefq9h6e5V1Hb5ZI5EZOl67IKscGJSAiSoNZ15BV7F+qgaaWg9r099GhSnS6A70wCEQskcH5TZVu3GpBWlBY2V+hFKr4RuDdHvpSvdPdwiV8QOgDByrhRK2GjqtL/pdMcedsfuYFZj4+mQJLnTxX5xs+QibrMneoPOTqnnOVD789eaIJ7d68lGmFBFPqD+zfr2/o6h+I1R87BVZzSuZhbBPSvQ642MEvSXsW+jzYPJoMvNAGQpRkQ1ztkX/rr/0ahN7OCHXwcZRmdJcg7hO7SXhWMXmnFeYh/CuBtATNi/Zlq18Q8PsSPpQufB434IsHT6axV8Ckt+Um/qyi35S3AuJaTdk/EkqIAroGTsXw9EDHKF8RpcpRlWcu3HzelJVWvaMu0L64BNJaZQW0Wk8HU1YOo3Cd15N 3FGUifcp FSn9Ov4VJO8SERsRganmbdMrcXMBt9oj/3rw9ERiePvMnWQmY8K5KXWUsBIoEN8JXAgq5l/RSuj4nU06T/ppspWLUxsYJH52yFULdd2MLIyPFroQTIVJjmj4CKJ2Ept6bchGmGSLyIcZICcts/E2X6wgWfhxLZYJiqghhtCF/i6u0yF4/OO1w4hTZjXmCifgVE46CIoCauoum8U11yGsihg2P7DIJ7sT+jtQo/eVrGeXKgS/GRvzuPoARh1CeyuXBmNSdGkm2BAh/w2tHUwbCHvYmZ+bdviYmmKswGF49Cn2wHfdFWzjTTvl8aUIyEgNjBZLpks1owOCs7Odi0amOuOuTrL5RvBfNhk7z6D9d6WA1Iro= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.500000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 04, 2025 at 09:05:47PM +0100, David Hildenbrand wrote: > Fully agreed, this is going into the right direction. Dumping what's mapped > is a different story. Maybe that dumping logic could simply be written in C > for the time being? ? Isn't dumping just a decode pte -> phys_to_virt() -> for_each_u64(virt) -> printk? If you can populate the page table in rust you have to be able to dump it, surely. Or do you mean trying to decode the leaf entires into some struct page detail? Does a GPU need to do that? Agree that would be better as some C function to take in a KVA instead of a struct page and populate a string with details about that KVA from the struct page. Jason