From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E302C02196 for ; Wed, 5 Feb 2025 02:55:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA1CE280007; Tue, 4 Feb 2025 21:55:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A521A280002; Tue, 4 Feb 2025 21:55:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F12D280007; Tue, 4 Feb 2025 21:55:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 70D81280002 for ; Tue, 4 Feb 2025 21:55:52 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1B4A447F7D for ; Wed, 5 Feb 2025 02:55:52 +0000 (UTC) X-FDA: 83084376144.08.D556801 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id 64DDE1A0007 for ; Wed, 5 Feb 2025 02:55:50 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zp2t+0QT; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738724150; a=rsa-sha256; cv=none; b=F4yLMdLt7th75grTJoL8tZTBzO5obz8IcWC4/3umJu3gz0jKqqROC033P5UvCUrheVBspQ pQHuICIUfgbzYj2eL9qJyUjbSg6B1kLYCabKJ1Miw+Ka3/wLqQjl9gQiHU5JXCta9Ppnuz RQO6zXqgqxbmitFkzrJCDX6ksTxyrXo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zp2t+0QT; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738724150; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v/vdyw/FQJ6z9mXtNHBqHXc9PxNdOkzMlxLRuvd9sik=; b=WASFr5Ieu3jUD+S73Lctd7OTQjA08APoRWEHCeRCzDZVLp39EI9mcpXvv1ApNPeEbJRM3M +EJdUHqOL5kOLem2Rer3OCnE4BL7926krS7hd2lnRNibKeqPoajo4q3i8hra0L9SJQNjT4 gfY1wLMJ7aH88SN1x2jANQtHOytfiwo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7B7FBA41843; Wed, 5 Feb 2025 02:54:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A18A8C4CEDF; Wed, 5 Feb 2025 02:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1738724149; bh=Iy98cYZmlM0zfKAVbhzprR+xN12zDSTDaNyVInZr9pA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zp2t+0QT8fNkRMUZvjHBFUUNdBviJZg+np/oXvDgPQB2Id6m6syhV6Frr1GroNoJ4 uoGcXvZooe6z2E8NBDcwL48m5lS3DlFhfRPcrIsU3bhN+0XKfX3CI8s755s77aVDIC j5qhOGfvc7gwTaoMXV96zWvGvu0CB42PLVCNzKgo= Date: Tue, 4 Feb 2025 18:55:48 -0800 From: Andrew Morton To: David Hildenbrand Cc: Barry Song <21cnbao@gmail.com>, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, ioworker0@gmail.com, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, ying.huang@intel.com, zhengtangquan@oppo.com Subject: Re: [PATCH v3 3/4] mm: Support batched unmap for lazyfree large folios during reclamation Message-Id: <20250204185548.75d95ac35aacccbc3982e935@linux-foundation.org> In-Reply-To: <0785a15e-29fb-4801-9743-3d08e381d506@redhat.com> References: <20250115033808.40641-1-21cnbao@gmail.com> <20250115033808.40641-4-21cnbao@gmail.com> <0785a15e-29fb-4801-9743-3d08e381d506@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 64DDE1A0007 X-Stat-Signature: 93fz8p7qkgec757dt1aq1ocohbdn3hit X-HE-Tag: 1738724150-636607 X-HE-Meta: U2FsdGVkX19auZKVx+wF53Tf+eH2ILclcmGBZVXmxHH0l26JejBmU4dBEQjTsumo2AhxnIXTVQZMVQh5YQWFtq/2rlNCMLUO0w4HpeeLx1gKS2AmK0LRWT+qeM9OFGe4hw1lWW1ngawkeY7OoQEgcEJeaBWowOu4oPdeqj80oL3OJlBbZ/zCOHLRUVLjTyMCPAwxrXl2avzLvaU5ggE4H5SuH5vyR6fSIFP+cRDk80YR5usrz8c5g1ksWFwODMCBbIkg76180i1suzjaJkahld1+fNMZLtIt1/602sHrNIP4LIj3LPl20Sf9z7AyKwAcH+6ClXzeA3rgT9jOwGIIlLX5FfgdfldsQgGs8IBxuYRdQqmJH0cqCFZVy7fpe2D6UolVIu3tbS6J4uY03r1pCwsrjej7Q7B+9GOXm1+ewIkza4WdBO2qRojXyyU1deJD8xQj9eelpFHmCezi9EtleMyF98RFX4jaNKfGN6zE3CqEEbGy6/oSrmkcpp8RNU7lKEs4zefrtn4KmLLYVW64lcFRtItOEc0OLqFAecMEHNKvbo0U2k4nDv1UGJ9U1yB0D/mGTfLa6SRB8oGCGRtUauXzw8CjAmZfKENrh/l+1bk6mIbMI3PeaCLlqTURMC1cfzelrMSAGx1U6+7PCpHSL6rwlYwKaBAaCjLBZqLZknVJhBJvkHJh8UFc97O8p15n5gcJT00x/lH694ZONMLjefcQfgOH+PCbBJnevwQMfaDu5g6YW4RmR4p6m1r48qMr6lJ/F9a431hwWUmm4nFBwLvVrPi8y+9TyfQLlJ8/vp6A728BRajnN759caHO56RmKtbvpSILiIH1svFUZwiaBZKdAiBcaP5Ntr15O/go7cF4I0vGgihUoiffoXc2phImGhYkYRrRB71lUI3jq2l7B2OURwWPrB1dtQOct2MgS5pBIPQKig5suotzGnCP/4qleRW2t8NAf/MLQ6UQnGx S9XKsXR2 UBmCLVssvBIjGU7V9DZpK3PHzVVKnrke4pLKDHYCuL6J6MdTIBBkc1YHo6NY1cC6CvKmtT+XqH7eACGLTdnE7ZPy0bb5o6+4c8r3Pd05e19BqXqDPjQ6MeyEqBwrIbGp0+Cs1V/IFz8L4C89/4Wsx1Z9Cxj7Z2Z0Wrc+GQ+kt4L41FGn8A+9VvSgu7kilebsHdCgR/eM/YNjAWiRUBZRHR9EH9XSSB1WFLlWI1uDM377ac+xeimSnnfTNSd6fLmvoo95QMllyZS9gCz3yg7cTCLAibwJ/yQU2yNVPKD4jmwoaie4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 4 Feb 2025 12:38:31 +0100 David Hildenbrand wrote: > Hi, > > > unsigned long hsz = 0; > > > > @@ -1780,6 +1800,16 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, > > hugetlb_vma_unlock_write(vma); > > } > > pteval = huge_ptep_clear_flush(vma, address, pvmw.pte); > > + } else if (folio_test_large(folio) && !(flags & TTU_HWPOISON) && > > + can_batch_unmap_folio_ptes(address, folio, pvmw.pte)) { > > + nr_pages = folio_nr_pages(folio); > > + flush_cache_range(vma, range.start, range.end); > > + pteval = get_and_clear_full_ptes(mm, address, pvmw.pte, nr_pages, 0); > > + if (should_defer_flush(mm, flags)) > > + set_tlb_ubc_flush_pending(mm, pteval, address, > > + address + folio_size(folio)); > > + else > > + flush_tlb_range(vma, range.start, range.end); > > } else { > > I have some fixes [1] that will collide with this series. I'm currently > preparing a v2, and am not 100% sure when the fixes will get queued+merged. > > I'll base them against mm-stable for now, and send them out based on > that, to avoid the conflicts here (should all be fairly easy to resolve > from a quick glimpse). > > So we might have to refresh this series here if the fixes go in first. > > [1] https://lkml.kernel.org/r/20250129115411.2077152-1-david@redhat.com It doesn't look like "mm: fixes for device-exclusive entries (hmm)" will be backportable(?) but yes, we should aim to stage your fixes against mainline and ahead of other changes to at least make life easier for anyone who chooses to backport your fixes into an earlier kernel.