From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF77C02194 for ; Tue, 4 Feb 2025 15:32:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 925B46B0083; Tue, 4 Feb 2025 10:32:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D5AE6B0088; Tue, 4 Feb 2025 10:32:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79E8D6B008A; Tue, 4 Feb 2025 10:32:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5A91C6B0083 for ; Tue, 4 Feb 2025 10:32:20 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F2139462C3 for ; Tue, 4 Feb 2025 15:32:19 +0000 (UTC) X-FDA: 83082653598.06.2FA862E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 485B820007 for ; Tue, 4 Feb 2025 15:32:18 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k3GatPAW; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738683138; a=rsa-sha256; cv=none; b=ZBEo2btFKv6eQSkukSKZzD7sNt1meRCB1JJLMmNJ0tqqn5zcS+XDsuctlv8fxcyzyIEQY4 Wn8JH7ganeNiHHum5SCaiEcoC/NEIVnGdQbiHfu4fMI8azSptIZGsnfNn2/zR37UXaNb3g bei9KX1psIQJYBCde+UlMvp7B+lgtaE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k3GatPAW; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738683138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ld3vmidjddziwkVyqduIC5w1iHgVu+kf96UzV7Ja56Y=; b=GCPjbBWKA81waxGuAbwqMtTQ23KmXS8BcirzXictgIcNO01ZkwjXqt9h+XSECA1o1i51KN oqiuoQ48TBTm8BnAM6RL5Zzk0+piDiPI20uNYb8uxB7Jcsa/Ca9HMiBjqFmwh2DSxhASq+ 3+e4ltVU+ouUB3/whTv8q/CCoroR5K4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 96FDB5C4D92; Tue, 4 Feb 2025 15:31:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14A08C4CEDF; Tue, 4 Feb 2025 15:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738683137; bh=lB6OvlDcA1DjkCRpW2o82kIiiXZLmOPFTXUyGT8+KkQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k3GatPAW8DAmRoCF/yYbTBkS//29CtNtQiMM1q+sH7579KGGy+H+hBJJ1itEHnMmd qmAeMO4OJOPXW1tBObo2hytfnpECAAzu/ozSsw+oagpWk8wwWdu1TvXa+B9/6L9GUp 2ARcrWMDPjIepldiYc5yJ5Ndm2U1tSZUo8ws917v/YeKBuqy9E5/OFpImcYi0DOIw1 MFi9txFw5IMkdIqujPEi+hlNlpQYzXJKKc8s3Dp2tI6q4/uRN68qivxnP2FJ3m8nIJ ESNJWFBq36iV82J95BumlhNjZ9gntiK/UhvtTLFi52RIR0iKh4XNM0LcLHEmjDzp5R u6RxuCh6Hw2Zg== Date: Tue, 4 Feb 2025 07:32:14 -0800 From: Kees Cook To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Eric Biederman , Shuah Khan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH 04/16] elf, uapi: Add definitions for VER_FLG_BASE and VER_FLG_WEAK Message-ID: <202502040731.4EE9CCBB@keescook> References: <20250203-parse_vdso-nolibc-v1-0-9cb6268d77be@linutronix.de> <20250203-parse_vdso-nolibc-v1-4-9cb6268d77be@linutronix.de> <202502040708.6E9CF77@keescook> <20250204161210-b788ff6b-9c77-4a9c-8ab8-8b727b0b2003@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250204161210-b788ff6b-9c77-4a9c-8ab8-8b727b0b2003@linutronix.de> X-Rspam-User: X-Rspamd-Queue-Id: 485B820007 X-Rspamd-Server: rspam10 X-Stat-Signature: rn5wca7otq8nc446f5rnxjy1o7wotys5 X-HE-Tag: 1738683138-247535 X-HE-Meta: U2FsdGVkX1/z66EnSI/mSRhqA3be5OGVNBgDVBCNbvQovqqO2bF5j/x7uZFRj8JzQ/HB3mDKUbi3WLEYy7xpVOpAHfbZYkAjLwq21s1d+HOPTx3aNYwMGBI8XUmHjBKPCnhMxVNVC/mKIBCGBlfvhirRdfiNE5RNziyEEMgapH4U9gSm4tEBluhi2WIK9ySoI6W0mc5pxrqpJGgGpr+Gydu69dGxrtUqSDXDWMAbLmEgngOv3d4hBIsfTuVZ4p0/Q1Cu2W6XXnMJK1WqS1AiU1bUo76Of0tezi+dIEnmvm5RtBQHfc57gOSrmL6tc3WerdRK9gqLcitg9yz6xC8Ai99e/hytuJ2Z5cRYC6NvBYs+x4xYL5wbhSkXUIARGh3nbce4FCUWyWtCwDqL6ebUkY/dOFMUbd15hM92ZIGWerw0b4dl6rMFtFPgrHH3gO+QDYxOCDd7MeCoT5i5Ze3OAF6Ox55g45AWsS0/G4Jur/JqxedegEonV9QdzVrLRcjI1n4j/ehnoZq5ojDoUPi0xtl6Hp3GmYgovX0mrZITH/1TWDWLRzDDtOxIEU92AjV2c5YbFYC3j7m0RNw+CcrImfPJaZj25PbtHyR7/m6s0P+hjrIL8MvrtDPPVlx0D5SVlz/xlEhVfeL+kwWdbngMXB+voh+Bws4bJ8NzGQVywl+4d0zy6xEQdk7jNXQ5X9ajyoIrhBY8DWRob2RGlKGdlcqe5zCRGUWx5Uo7jyFjI/7+WLO0XnxDaea9RCUWkvWryDvGURo4iraOPpY4vKgmIUW9ZxrjftmFFY1UABhKbbRqn338Kuto+KWqlpIsj4I4/mxLdbk6OYeogbVS9sJlqZzRFtSOKqEutmbVZ4UqZXf7GFZ/5Lja/nZorKxg4VzbrltrPEisDL4/k8r8cROwo3BFql3HC7ycz/jODutZ27OLv2xH/MpzYBkQFppnkH4/Eib6bA1TKvX3YEsF3XA mbnNihgZ aZOc/vV953/GD3lXJDLQhVwBa//G+cnidqTk0kjz6m0CKcbg1lkGhZtN2JQVJvALP/Zy+sLOSioAWzVsZOUb/VKNmf7q/oc0xceXVgbl+Wa2knsbmhYN2FocqsEJ/3+RIuvzUPBHi27QUb+fhgz9pO9qw0RDJFXm/SY3KaGr9wTmDR0ySho3wwBIv2/PQSqKHDudr+C1BTZHkXm63NS7iZhux8gLVcNvStsW1Y/dX3mYcdg3MO86XkkQ7M948hZ0APhtYZI6u1z/fk2IgotNgEB6TkfSufnfbB7W0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 04, 2025 at 04:17:03PM +0100, Thomas Weißschuh wrote: > On Tue, Feb 04, 2025 at 07:10:00AM -0800, Kees Cook wrote: > > On Mon, Feb 03, 2025 at 10:05:05AM +0100, Thomas Weißschuh wrote: > > > The definitions are used by tools/testing/selftests/vDSO/parse_vdso.c. > > > To be able to build the vDSO selftests without a libc dependency, > > > add the definitions to the kernels own UAPI headers. > > > > For all the UAPI changes, where are the defines "normally" found? i.e. > > how does adding these to UAPI not break something that already has them? > > Or have these never been defined before? I'm confused about how removing > > the libc dependency exposes the lack of these defines. Are they defined > > in a non-exported libc header somewhere? > > They are normally defined directly in libc , which does not use > UAPI headers. Libc elf.h and Linux UAPI elf.h can not be used at the > same time because they define the same symbols. > In theory some user of UAPI elf.h could have defined these new symbols > on their own without ifdef guards. However UAPI elf.h is regularly > updated with new symbols. Okay, great. As long as the collision risk is low, I'm fine with all the UAPI additions. Thanks for doing this! -- Kees Cook