[PATCH] selftests/mm: Fix thuge-gen test name uniqueness

[PATCH] selftests/mm: Fix thuge-gen test name uniqueness

[Mark Brown]

The thuge-gen test_mmap() and test_shmget() tests are repeatedly run for a
variety of sizes but always report the result of their test with the same
name, meaning that automated sysetms running the tests are unable to
distinguish between the various tests. Add the supplied sizes to the logged
test names to distinguish between runs.

Fixes: b38bd9b2c448 ("selftests/mm: thuge-gen: conform to TAP format output")
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 tools/testing/selftests/mm/thuge-gen.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftests/mm/thuge-gen.c
index e4370b79b62ffb133056eb843cdd1eaeba6503df..cd5174d735be405220d99ae796a3768f53df6ea4 100644
--- a/tools/testing/selftests/mm/thuge-gen.c
+++ b/tools/testing/selftests/mm/thuge-gen.c
@@ -127,7 +127,7 @@ void test_mmap(unsigned long size, unsigned flags)
 
 	show(size);
 	ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
-			 "%s mmap\n", __func__);
+			 "%s mmap %lu\n", __func__, size);
 
 	if (munmap(map, size * NUM_PAGES))
 		ksft_exit_fail_msg("%s: unmap %s\n", __func__, strerror(errno));
@@ -165,7 +165,7 @@ void test_shmget(unsigned long size, unsigned flags)
 
 	show(size);
 	ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
-			 "%s: mmap\n", __func__);
+			 "%s: mmap %lu\n", __func__, size);
 	if (shmdt(map))
 		ksft_exit_fail_msg("%s: shmdt: %s\n", __func__, strerror(errno));
 }

---
base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
change-id: 20250204-kselftest-mm-fix-dups-076a48577184

Best regards,
-- 
Mark Brown <broonie@kernel.org>

Re: [PATCH] selftests/mm: Fix thuge-gen test name uniqueness

[Anshuman Khandual]

On 2/5/25 04:23, Mark Brown wrote:
> The thuge-gen test_mmap() and test_shmget() tests are repeatedly run for a
> variety of sizes but always report the result of their test with the same
> name, meaning that automated sysetms running the tests are unable to

s/sysetms/system		^^^^^^

> distinguish between the various tests. Add the supplied sizes to the logged
> test names to distinguish between runs.

This makes sense given that the size parameter is available right away.

> 
> Fixes: b38bd9b2c448 ("selftests/mm: thuge-gen: conform to TAP format output")

Just wondering how this fixes anything ? This seems like an improvement to
the current behaviour.

> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  tools/testing/selftests/mm/thuge-gen.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftests/mm/thuge-gen.c
> index e4370b79b62ffb133056eb843cdd1eaeba6503df..cd5174d735be405220d99ae796a3768f53df6ea4 100644
> --- a/tools/testing/selftests/mm/thuge-gen.c
> +++ b/tools/testing/selftests/mm/thuge-gen.c
> @@ -127,7 +127,7 @@ void test_mmap(unsigned long size, unsigned flags)
>  
>  	show(size);
>  	ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
> -			 "%s mmap\n", __func__);
> +			 "%s mmap %lu\n", __func__, size);
>  
>  	if (munmap(map, size * NUM_PAGES))
>  		ksft_exit_fail_msg("%s: unmap %s\n", __func__, strerror(errno));
> @@ -165,7 +165,7 @@ void test_shmget(unsigned long size, unsigned flags)
>  
>  	show(size);
>  	ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
> -			 "%s: mmap\n", __func__);
> +			 "%s: mmap %lu\n", __func__, size);
>  	if (shmdt(map))
>  		ksft_exit_fail_msg("%s: shmdt: %s\n", __func__, strerror(errno));
>  }
> 

Otherwise LGTM.

Re: [PATCH] selftests/mm: Fix thuge-gen test name uniqueness

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

On Wed, Feb 05, 2025 at 08:22:04AM +0530, Anshuman Khandual wrote:
> On 2/5/25 04:23, Mark Brown wrote:

> > Fixes: b38bd9b2c448 ("selftests/mm: thuge-gen: conform to TAP format output")

> Just wondering how this fixes anything ? This seems like an improvement to
> the current behaviour.

My test automation was getting pretty confused about what was going on
so I'd say so - the test names are a pretty important external
interface.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] selftests/mm: Fix thuge-gen test name uniqueness

[Dev Jain]

On 05/02/25 4:23 am, Mark Brown wrote:
> The thuge-gen test_mmap() and test_shmget() tests are repeatedly run for a
> variety of sizes but always report the result of their test with the same
> name, meaning that automated sysetms running the tests are unable to
> distinguish between the various tests. Add the supplied sizes to the logged
> test names to distinguish between runs.
> 
> Fixes: b38bd9b2c448 ("selftests/mm: thuge-gen: conform to TAP format output")
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>   tools/testing/selftests/mm/thuge-gen.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftests/mm/thuge-gen.c
> index e4370b79b62ffb133056eb843cdd1eaeba6503df..cd5174d735be405220d99ae796a3768f53df6ea4 100644
> --- a/tools/testing/selftests/mm/thuge-gen.c
> +++ b/tools/testing/selftests/mm/thuge-gen.c
> @@ -127,7 +127,7 @@ void test_mmap(unsigned long size, unsigned flags)
>   
>   	show(size);
>   	ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
> -			 "%s mmap\n", __func__);
> +			 "%s mmap %lu\n", __func__, size);
>   
>   	if (munmap(map, size * NUM_PAGES))
>   		ksft_exit_fail_msg("%s: unmap %s\n", __func__, strerror(errno));
> @@ -165,7 +165,7 @@ void test_shmget(unsigned long size, unsigned flags)
>   
>   	show(size);
>   	ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
> -			 "%s: mmap\n", __func__);
> +			 "%s: mmap %lu\n", __func__, size);
>   	if (shmdt(map))
>   		ksft_exit_fail_msg("%s: shmdt: %s\n", __func__, strerror(errno));
>   }


Suggest converting size to MB before printing. This will print the size 
in bytes which is confusing. Otherwise:

Reviewed-by: Dev Jain <dev.jain@arm.com>