From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C9C4C02192 for ; Mon, 3 Feb 2025 17:52:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B3BD6B0085; Mon, 3 Feb 2025 12:52:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 763606B0088; Mon, 3 Feb 2025 12:52:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62BC36B0089; Mon, 3 Feb 2025 12:52:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 442E16B0085 for ; Mon, 3 Feb 2025 12:52:02 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BBF5612038B for ; Mon, 3 Feb 2025 17:52:01 +0000 (UTC) X-FDA: 83079376842.14.A7E0EBD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 9E0F9A0002 for ; Mon, 3 Feb 2025 17:51:59 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xqmg35VD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738605119; a=rsa-sha256; cv=none; b=RYtqhy2J+e4K6VwEbDklqPgLviLFFth99p4/iRb1Aqy4IHoWVbO8OICaWuCmHSP/5Yarbr iTxvWeeikvG2oy7BKwccK5zkg2X54KEZI785WR84u47E7MkU956sPKVI1VBP7yO5p0G3y2 MpOYtGSG7/4hUJN6hYVIUCFH3D9I2Ek= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xqmg35VD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738605119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=970kTp5gWYS91tMEVbu8ABs0xJMnmrm1jfXZ4raiIRA=; b=bApf6BVSXMeM69qLWLdTt8E+1mJlLtgvEc2113cpu9DpGs7gJG//dpd2+hIycjvQufYLx+ /ilT0FYox1D3PZZn2Cuws9kPm0/zxSh62m2cILuXGZP6g7yZRLkylJ8dY5foxTaMSdsHhg OY+X5q73ESKM/JIRm5e4sWdEYtsOWvA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738605118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=970kTp5gWYS91tMEVbu8ABs0xJMnmrm1jfXZ4raiIRA=; b=Xqmg35VDJ3u/MiV23DOY4iXPOjJ5ZbOkPZgQ+FxLSn69gC34rBvvdsEGWFTAxcsMSFJOYR 6e0jEWvGR+iIl8M6gZS0RTi8OBgRQ4AFDsYzP5hyKrgg+FTvoiTUkKZLml7kR1G03EAhaE 8V6YmRn+wrKsVV7zstE5aX5FP+luBd0= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-qc8B5v7ZMne1SKqt3Hg-9A-1; Mon, 03 Feb 2025 12:51:55 -0500 X-MC-Unique: qc8B5v7ZMne1SKqt3Hg-9A-1 X-Mimecast-MFC-AGG-ID: qc8B5v7ZMne1SKqt3Hg-9A Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1A57C18002A5; Mon, 3 Feb 2025 17:51:54 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.72]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 985741800268; Mon, 3 Feb 2025 17:51:51 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 3 Feb 2025 18:51:28 +0100 (CET) Date: Mon, 3 Feb 2025 18:51:24 +0100 From: Oleg Nesterov To: Mateusz Guzik Cc: ebiederm@xmission.com, brauner@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] exit: perform add_device_randomness() without tasklist_lock Message-ID: <20250203175123.GB1003@redhat.com> References: <20250201163106.28912-1-mjguzik@gmail.com> <20250201163106.28912-2-mjguzik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250201163106.28912-2-mjguzik@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9E0F9A0002 X-Stat-Signature: wc3w4n6i5on9shmfdiycgzhbopgpkzsf X-Rspam-User: X-HE-Tag: 1738605119-69444 X-HE-Meta: U2FsdGVkX1/UZA7JgsJzzskEgDpsbh8Qrcik4R58B/sCpvO+vzXc4rVzV1jBqrsBByrx3WsESfiPeqVjlU6BQhdMXqxs/OmZPcpIF+g2UbrpZUioaWCUNN3yEvRYBZ/OI9g3zrrySl5Hq3LO4npUfhQjs57blLOmdP1pMUzaK7h6a/WngZZ18hQZtIsgvYQcG0xI9S8ElJulK/7wUG0DdIdu4DaVQKFQoqB16geS3F3aTZjV9SZlUHMMr6orIjFENBJgXl31D1fyrWZA5HS1mQetFsyHkFaswEmLdFDJVDhApb1esFLd1XdWdElA3yOIKzXKrS/93+ml7O3wkYujOPQT+yRNCAFVUgUGQHLu/pZhv0VfJDvUPJJMsDX8TPco04pFkHiejRc3bdGdXWQo4QiqGDm2s1brbVQYeoLphdDXIsYo/BN8EL21cxtOM/iaxlARfggnQ1BtDOmTOT3o9Jgp9irs2IT4/arfpyMHPegEMEmWLIh9+uHb2D8QjFhLCByTCNbmcQ2+S+ez1rWxIeTiAia3hfBeiSAkgJf8oKcMTBI5yU5qawBGhKxuRQsmSq9Z+/U7gK3mYqhd658+Mxc88Z5pZ1XkqI3qjnxTme2NucYWjzcEdkztUIzu/8gmdnXRzMZGFa8wcwJ48ooMUlSH0CkGSpqIL/GH51SNMp7MLipYWkg/NIXsRBtnWzX227f/lqKZ5iZAx+m7BIG/6GNzStG3fVTj7Wp0LWuq/ipsHon85+M98TbCgd27dS2ihB12aNnNUTH7iod3QKbYKAoy3lHmPdQVABGQ5SvbPz0NnFNiz4Kz73Xw2O5hykAx4QHFL407/6eJNrRgYHNEuALea1slD2Q0nm4SCGJFcj1I1qcJWiG4WESXSw1e8q7tdXlFPXo+4rBkYhkrXo+GRhEBPtTcqyUcIN/K1urCS/2TfuuQqohqsYZgMbKTspzaaLkbQ5klFshz/IbQGYz 5w7707qD gee03+wDCWarVvYSXkJ0KW/TP8vRGjhFMHkTIG+MMAdrE5boXX6RGN8pm3w4FTycfMgw5jiphZI201dME8RM+hSMHS07iWsp6171Htzj4DvJEw82B7B976WqoYpYrdbTaGC9+4Q20v2tVyxNSoHUBiu6BUQAwJuhpU+7Es12WOtp+5B14DOrYD0c3GJQ/qbs2rJc+nEpOkps8MBs7L/Y9t3GpZeNPiIpz2NReYHs/oJt4seFd/l5nm1gCKEREy/wegi9k0877f/ZK3aDQbm8mDwtNBzTyWoMLLoyAr4vuJcJyd2FZOITzK9nB7XmbBmUgi+gNPzbfKx6mZ5yBdb4vwI7fRR7Kg43+Sfmt X-Bogosity: Ham, tests=bogofilter, spamicity=0.014984, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/01, Mateusz Guzik wrote: > > + add_device_randomness((const void*) &p->se.sum_exec_runtime, > + sizeof(unsigned long long)); I won't insist, but do we really need to keep this ugly "(const void*)" typecast? and perhaps sizeof(p->se.sum_exec_runtime) will look a bit better? Oleg.