From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8849C02196 for ; Mon, 3 Feb 2025 17:47:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36BDA6B007B; Mon, 3 Feb 2025 12:47:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F2DE6B0082; Mon, 3 Feb 2025 12:47:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BBBC6B0085; Mon, 3 Feb 2025 12:47:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F01AB6B007B for ; Mon, 3 Feb 2025 12:47:46 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 81E98160339 for ; Mon, 3 Feb 2025 17:47:46 +0000 (UTC) X-FDA: 83079366132.16.A8F8990 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 7CB2A100003 for ; Mon, 3 Feb 2025 17:47:44 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IZKakpFl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738604864; a=rsa-sha256; cv=none; b=uMd3vxQ5I67VLoP0Ro/sFRwOGtd7BvxMTvBYuLR4zxvMRNYdpv6ArC6InvOJtalaNvTjyo GLp3IthdGKpfTne0SWDIOKhabrNQ3MVXK/OM+/VwJcS6WGW/NiwtZAA74cZMLVaQ3c5kfW tl1x+6PdSbcz7f3EgleZVBRxF8jG0gU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IZKakpFl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738604864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wf8DeKimNBu7vRPukjIt1145Uefa5PAmCrQ1aqwjiXI=; b=zZmDyDVwZ2gAMrU4zoxl4VrWzFIcre3z9Z6wab0B+q42L8U14NkZBwntC1R+Y4xCHPO5Fv zoVThIdimXSlYAm8QXNOVKdsLk/qNx2oBr6fxeiXAtudcouDx/o77I1tSKGOnc5j7TVhIJ 47vqDMPYJNVqN4pOVkArPVUrsbkHQcM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738604863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wf8DeKimNBu7vRPukjIt1145Uefa5PAmCrQ1aqwjiXI=; b=IZKakpFlBaS4tpiatD0oloRFXdKIYVbP1XY1ebPfc4wBDjdtIKvVzucOT1Ku7DR0FZ/JEF E8A5GAbb8r1a+l1JOwnxgmJkOo5Dg3twPVBBgYvkn+cvxgUEEE4olK2hBtHpyXzkADx2sT ASUDFU/8iulc4TX/6FHPmpAf723x5e8= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-MaAXbB8UP0Gc73UcxpJgWg-1; Mon, 03 Feb 2025 12:47:40 -0500 X-MC-Unique: MaAXbB8UP0Gc73UcxpJgWg-1 X-Mimecast-MFC-AGG-ID: MaAXbB8UP0Gc73UcxpJgWg Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E282B19560B4; Mon, 3 Feb 2025 17:47:38 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.72]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 42BF61800268; Mon, 3 Feb 2025 17:47:36 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 3 Feb 2025 18:47:12 +0100 (CET) Date: Mon, 3 Feb 2025 18:47:09 +0100 From: Oleg Nesterov To: Mateusz Guzik Cc: ebiederm@xmission.com, brauner@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/6] reduce tasklist_lock hold time on exit and do some Message-ID: <20250203174708.GA1003@redhat.com> References: <20250201163106.28912-1-mjguzik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250201163106.28912-1-mjguzik@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7CB2A100003 X-Stat-Signature: z9hqzahiqcdxycbwetu4i7hiif6gpgeo X-HE-Tag: 1738604864-155528 X-HE-Meta: U2FsdGVkX1/bHHe+i8ZbJQCfb4h4e1dOeq7bs98TXCMXpSo2LVT28v8mRZESc3MjVlWGmP8mTZZwcHRpl7WoH5Is3ak8tB8XOaavirGbllvvjyPVShvdjVAGthL43EfBxZewyQ/fiOstvbUSUcpHT425yZAUUH7m3lGySPekCKgUZxfdfLEI/93d+eSIxkGk5bK72gQXXtWzS99Yg4XQG4zPzP3RPgkA8cxY3tnhQVYMrWQYJYOSmpvBo3cFkJdEMqXXBcFRn3Miot6lF2qX/1TSOtKM8aTkPP7kJGDszRAdAVJ8+oePKu65CKDfcACZLu7lz9B80c7dEOBiNvQuCppV8MG1YLMS3UwTKrapLXyiEHjclQO/kP+AHvljaRc2e5AL5C5ih6Bx+JTRbXEhSvn2X5WkTyhfjbcHIf3seMcARq3HF/AohWSnLdXyxusk9F/O8PrfA30XNgmg+6JsQcLNKiGKq54vujDU69YuPgbikuWH2xZwNDtCXookAh3ELPdSwvzMzp177NDl/RAFPYbmzD2yQwlz/hxWAbHkRkw7/cx+8aVbvX3sE+C4xA0BUZjRSlua9wNijWRKyEdXtbOY9a6IWXGGTDL4ReMa8bUADhauewFVjm/EK1/aEDiseCorLN3hoCv1O7ZnEokd010jqh7hH8Erd29HPSc0om5Ac+LYpXKsrQtlc7PJQZmK/dbLRXIIX29o4yBu8487rtzkrwj1vTV7162ej5fMkhpRB9Tl/k15fJVgZWgbsBpwXAECxv05VDy/77QEVMAocjdnecAafWmWuuOGQ9CuhMwNCIusIUPl+x3a2nWI2ZcBjIW6yzMkszTnJ3nHPbAjTBtBGzV7ydr2IPqMR+tRGm+FLLwMU1Lit2olmWxKlO27QFF8Xu2elbluk81ijLx1t6GRUV2YKEHl1aFYIX/ybik89AaIt7MoaWqmX+CaSmnPL0wRqUoyxmF2tZvOAV9 lN/COpV+ Hrx+yir9jRE2YuTcLPGjuhLU2AO6+stH79k41QKZ3ilF3UiJEWg+jr6I26JvG3Q4rfTLV7SeXxxvO6SSHskvkm7gqssX8s1a+SvAnqV29SDm6EAPd5Jusb8Ece4rEpN/WoCTmVHgmp57U011pOBbSOpa8tk2fpWfHLwaSp/r/ErgC66cIAsElONHFEgnVLeaA0Djaj0C8vxYKJ9RsVOdXxMlosZuqcFQJ4LRINxkXFGmZFS4/EmYXVOkBXlS1Nph4p3BV1LG74PlQrodOc82FjZ69LTv1Mk9uiwWoiidTe+hO+Uk+docnsYsUO6ZN5ERGN90KbYiFgb8en3zatr++JE5JvK9fF5syLVlhHz9juwBojZuyIL1wY+z1yU06j4u6a8D0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000422, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/01, Mateusz Guzik wrote: > > Mateusz Guzik (6): > exit: perform add_device_randomness() without tasklist_lock > exit: hoist get_pid() in release_task() outside of tasklist_lock > exit: postpone tty_kref_put() until after tasklist_lock is dropped > pid: sprinkle tasklist_lock asserts > pid: perform free_pid() calls outside of tasklist_lock > pid: drop irq disablement around pidmap_lock > > include/linux/pid.h | 7 ++-- > kernel/exit.c | 45 +++++++++++++++---------- > kernel/pid.c | 82 +++++++++++++++++++++++++-------------------- > kernel/sys.c | 14 +++++--- > 4 files changed, 86 insertions(+), 62 deletions(-) I see nothing wrong in this series, feel free to add Reviewed-by: Oleg Nesterov I have a couple of very minor nits, will send in a minute... Oleg.