From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E028AC02192 for ; Tue, 4 Feb 2025 00:47:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DE2B6B0085; Mon, 3 Feb 2025 19:47:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 566DC6B0088; Mon, 3 Feb 2025 19:47:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E11C6B0089; Mon, 3 Feb 2025 19:47:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 12FF36B0085 for ; Mon, 3 Feb 2025 19:47:38 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8272F1205F0 for ; Tue, 4 Feb 2025 00:47:37 +0000 (UTC) X-FDA: 83080424154.24.8499E13 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf15.hostedemail.com (Postfix) with ESMTP id DB92FA0009 for ; Tue, 4 Feb 2025 00:47:35 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=i9J0TpPL; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738630055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vVD/XqsgZlz0gc6CZocCdSLgoXdul0z7tFYeG8wHl0k=; b=jFHRItHIRYA0SkmPIkycSmgcJhh69XZJO5gsV7ePMhloyOVZ6+HZNtN0lOo3IyL+cGEURB 6zAW5FO14nOwVFqvKsFsCet/93OZdf6zc+mkz7oJ/c/U1QIsG4f/KZ3ftvHlJUgauUwJVH Xb0hlCgpJDdAx2M7GzR/Cz8IL0wl/QY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=i9J0TpPL; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738630055; a=rsa-sha256; cv=none; b=1CbGUQ8D0EcnUVrMPSw7E1MkB9X0n/keeDm5Zb4sUQA4W9FdUGcf12fLH0d4a86vrlS2D+ Ts5SFyHzfTJmkXl6Kz0w331xWb2jayYjuoYWqAwjrshbku9cvOy0e8GqTIVtIln5bN4F3S W3+/73RJQ9k7zwQBNbqsQCve0uApTc4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C637EA4201C; Tue, 4 Feb 2025 00:45:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FD2BC4CEE4; Tue, 4 Feb 2025 00:47:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1738630054; bh=jmDmBKgdg+tglC1hAuRd+I3gUe9Geez71dH7vuTJP8o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i9J0TpPLqfCwqIhS4yhFauZVhJ4TuUZuMbvB3R02l6ePYKSpNO1W0zS6x3mHYYi7g 7Fg5HQqTWVm1ZBZwjcKxlLwfFwz/bbtYtagxrbQdIz3DeRqWX1PETn+wfCt+vq4vMi /d3R4Mq9rATcGZhoTRTxbAC8v4fPS31ZNgZU2mvM= Date: Mon, 3 Feb 2025 16:47:33 -0800 From: Andrew Morton To: "Kirill A. Shutemov" Cc: Kairui Song , "Matthew Wilcox (Oracle)" , Jens Axboe , "Jason A. Donenfeld" , Andi Shyti , Chengming Zhou , Christian Brauner , Christophe Leroy , Dan Carpenter , David Airlie , David Hildenbrand , Hao Ge , Jani Nikula , Johannes Weiner , Joonas Lahtinen , Josef Bacik , Masami Hiramatsu , Mathieu Desnoyers , Miklos Szeredi , Nhat Pham , Oscar Salvador , Ran Xiaokai , Rodrigo Vivi , Simona Vetter , Steven Rostedt , Tvrtko Ursulin , Vlastimil Babka , Yosry Ahmed , Yu Zhao , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCHv3 06/11] mm/vmscan: Use PG_dropbehind instead of PG_reclaim Message-Id: <20250203164733.f806902a6e5c91523c9e00fc@linux-foundation.org> In-Reply-To: <42h65xowqe36eymr6pcomo7wzpe26kzwvyzg44hftqqczc5n6y@w2z5wvdrvktm> References: <20250130100050.1868208-1-kirill.shutemov@linux.intel.com> <20250130100050.1868208-7-kirill.shutemov@linux.intel.com> <42h65xowqe36eymr6pcomo7wzpe26kzwvyzg44hftqqczc5n6y@w2z5wvdrvktm> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DB92FA0009 X-Stat-Signature: x9ua43a7ig68wjw5d9wcrfykx7hddbuh X-Rspam-User: X-HE-Tag: 1738630055-203889 X-HE-Meta: U2FsdGVkX1+PXVdSD2Lyby/0eimvXdo2xVL/euTosy8xJ3GJqB3zFbZJ1FmuxFkBkuo0fL0cQzF1gYfz0WqLnBT6g0tvY3ZhaRdzOoEWgOW9gh0GpEAx50lNrGfwX21OWW6V68otpJ95OIdiF88WgReaIKatQlqxqRM1W9r5BnSayxqli8zPEyFQcX5FT/AjkgafxTNcGzti9Z4kgTvr/PbgYaZCN5f6aRt+/7ubju4Ne9jfGnPzrkSRf4ENLgiulDfwFpFfm2KUsT74utIFQeC2TK2fNsWzlsAeuLYTs2JCyGuzFjP5Q7X9qbeJQUycGewkBd97Qc8a0bmFm5CYOjXzOtqvmDrmcO5cuLthVfExTnWxAS2f5fRaVq3CUEkEohwPhpSKOwK0NIocfwbMxZQ//K5fZJab7g63ubCKB88lbSP08I9o3DIzGURckBo5td4v+P5A23gJidh/dqad3gT8LC5ETyo4F8XUP00j5Rtgtl+PaT9jeBUoIqeGikqtl6B9zldRcVtRFafNZIUdWfNiY2VMRbcnSqF2CHR+CsNMcFjSAQPPaGXD7Sd482nRgCz0MnOHVk3xMPIRKt0DNnefILPoBXJJ4hk8aYfFZlWNCKfXVUm1kihKA3ldTMqFb3mAvPkwbiIAZuPeEDR1Dha6EZvTIss3oceq16wrooA8ar/uJ0fj1GNhTUdT1+UwHa6L4OKvWGM7m5wYucyeRGKy6sPQLlt0AaCJ2HE5/fdB2q747SOn9zPCdIV+sVJQl1daoNq0HSshg4JzLu7TqFYOsc5nHqv9rQ7evdkVqo8okST8h9ANKShpAih9gvfRXzzyLDSTz0JjbU+Wm0ED5JXmaalKSTQoRWdXy6s40EWO9xVl4EY3AJ+rYVIrT0NBzP4yhsqQZ+pcsoOHzWyyJDxZtt6VvtEnAtxaPjuq8hIg9A/OS3uzRdIhctBXry23CuTMiQhdN0fWYxnLvy4 Xk6Q14BM kuiQl4beTLej8UvRCe3OCAeN25vVI/MoJoaI8qFU16M3KJTPQHJVGNrZMr7hK8Lt0h/EQzcsNYvfTonH8DOFRMLBwspQRKzeODPXwGGoQ2gvwVPFH9R/Zjtd/BhCLsd+0gDmcvlDdTuQFhHmxqZEWglqKRUMX2W5AwtikDi4SFPnwjrnpoDBn6NpWQmP9w1R8cjDFlwGPcNbKe0fuyNP+9QEaHz4LWMyA1wrYNRNoKbcb8b+GBoj1gDU4xt6p9nbhuySoPIy5CJ7/up42MAwqigNBXEj6uJYdSAcRUqEljjtKAexpy4uWEFSFQ2gEGcTJCEN/7ev8k45C9enrx3NGKoqqwMg2LIEs04MHqpBZKsABQXFoGSfSORCEHOakLeucMHK751xlJQtLohMQlP1841jhMr3UPSIbhYLO7K5BPovEYAFCJ007jQVT4p+Oj/5B+aPOwI3qK7HAREUpj6ipM1kRJRaQNRcXZ/X08ynM7yIByfOmFOPBFpAmkLy1NKRoNKPXbmD4rqcniriIn79bGnqjZW2c8wSBKXtwy8WouDFsoWPb8XeID21XaDdTXPtvuTVXO6qCAkv3HnUPz5qdjWBHWZXXAoIrL9Wz2Edtx79nb+NcpA8qiV/uqi0eSJmDAYqo9Tb2SSCRVh+LT6PadK10Xddp6yNS4v4kuH3j70lhR2+CzrjNBhyaixCPhKXrpCMlXJW3RxOm3n2UyrdUunSacZsJ6Ad4oOBlcuUJVuaTIhdyIwVIR+y4SQ4afPJb3JbFvwVJVCQLvvM+DHoIeK86inBtWBZO8DPOrYyVDLeTk/u9/ruEjrO2sLd0KTZLIkH+9TpawVaqYZwkvej6xbYBxCeR+5cryJoMOen7TPYOjSwenAflhW3boQweZZUnmHzAKaHWCqDrPNLR4k/oMorLhQoSD5AH457SdcBJoAUG2K5xz1W5ztnvdMZMNxFRH5eHcniYJ+sl8LU6vWlLZZ9iEElB c4SQMxXx lhvBD3r8z4RWhnG/TqyR3dATqoJVvRwvH3lkfnnp77EcETw4eksQ2Q2mBXdox60xSB3WCE92KLb4o0NfFYHDDc7DcuRdtDthzxkYGVdK2AsUeX38xF5V90IeF1xIxrwiz1qvf6uK/uEI4+iW1Hwsk2lu9qKA0yU9VkXXsbubaKfoMxsLoEXw6IPLApWgnbWbTdjNNoAbzDUuVl4VsuGl3B28tqlg0XC2dzxWxNKz5UpBfJKR8syP2KEYH44pQuEvOavrwH//6xrx/rWZ9p39Olgbg71TF6GC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 3 Feb 2025 10:39:58 +0200 "Kirill A. Shutemov" wrote: > > diff --git a/mm/filemap.c b/mm/filemap.c > > index 4fe551037bf7..98493443d120 100644 > > --- a/mm/filemap.c > > +++ b/mm/filemap.c > > @@ -1605,8 +1605,9 @@ static void folio_end_reclaim_write(struct folio *folio) > > * invalidation in that case. > > */ > > if (in_task() && folio_trylock(folio)) { > > - if (folio->mapping) > > - folio_unmap_invalidate(folio->mapping, folio, 0); > > + struct address_space *mapping = folio_mapping(folio); > > + if (mapping) > > + folio_unmap_invalidate(mapping, folio, 0); > > folio_unlock(folio); > > } > > } > > Once you do this, folio_unmap_invalidate() will never succeed for > swapcache as folio->mapping != mapping check will always be true and it > will fail with -EBUSY. > > I guess we need to do something similar to what __remove_mapping() does > for swapcache folios. Thanks, I'll drop the v3 series from mm.git.