From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E848C0218A for ; Sat, 1 Feb 2025 18:19:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E0366B0082; Sat, 1 Feb 2025 13:19:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 668786B0083; Sat, 1 Feb 2025 13:19:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E27B6B0085; Sat, 1 Feb 2025 13:19:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2A1B26B0082 for ; Sat, 1 Feb 2025 13:19:40 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A4C481C91DD for ; Sat, 1 Feb 2025 18:19:39 +0000 (UTC) X-FDA: 83072188878.26.B8CBE04 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf13.hostedemail.com (Postfix) with ESMTP id B0F6620004 for ; Sat, 1 Feb 2025 18:19:37 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WDbqQ66C; spf=pass (imf13.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738433977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SxnKuQKrMFisnjQoJYcahdpfPfugvdcfaFsvhS5tvMY=; b=0Y6NzWCLaBIxzOp96zKbY2gMaFoyYx82OwfeOQKeXnvfNvw32k8FHDCMyagQr2L6fPLkA1 ab8Xz0PsWmXnr8bL4i8vfdDOGP7/EDdZU/Xvo1NAes8YtLSjKwHocsQxxHyRp7NVGGpltK aB1f62mMuR2fxR8CMOALBPytF8uqPZU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WDbqQ66C; spf=pass (imf13.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738433977; a=rsa-sha256; cv=none; b=SVQW1Bcp9PB+bXQ+d0BKDp957aSofSNuLaLmnTxR9cEkU4SxkgFwLodO1kFHChfxKhjJbp wXnqWkkJzJoWVrMJSMqZdoAAQqer6mmqMK6ai7ETSVOLzAbrIgfCEoyzgYCWCblpMj2swO tjOt2Xbkqmmuj7ly2g3CXCVpbzyZW6g= Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4361815b96cso20982045e9.1 for ; Sat, 01 Feb 2025 10:19:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738433976; x=1739038776; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=SxnKuQKrMFisnjQoJYcahdpfPfugvdcfaFsvhS5tvMY=; b=WDbqQ66CxVOJbIVsu/5ApUBmYFQKqTMthveGagZY5FzfOD7F3ameNshbeKr2mC6jMM cisB3Hs9zfb+oxWIuRPRMFpNAYydAxDGXCF9BwB795lcVGREtpcdXWXCqtmaQIg2J8vy QwOTB2WxvmnrwjPl3cuBQXM7m9cGMoUW4ijmvqAzea4c9XRX/vChXzdwUynU4lXBGt// oAIL7bjf84XxFoJytpEmU6prNar/VgFEhBglcbrru9Z/SEh8Thu86lrsxiI4ULXLcNeI Co+CLE3lkSJq33SYVbPp2pG6SN1RqxMwZ+oAUSqMHqJFXEOK4nkBdMxuFFAH97U2dmea UErA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738433976; x=1739038776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SxnKuQKrMFisnjQoJYcahdpfPfugvdcfaFsvhS5tvMY=; b=LMkUiZy9kOG2OuBMViWFjMQ7FJogn+bWeI3ibLaUpt7vPjGCmUaJv7dSbG2gYmHFau E79jse9mkbugE5NOwuDuuXUCucowReITzcE1DauogeZeupAJ0aU2WpCOG2REaTHzS7A2 vlscmH5o/U2x9whE6Ji+Jc5GMFbkF0g1kUxhpFmhP2PUBsU8Waa5Of/7wtEJeVv4xqUc 7wCVcFD/PTyTAqRlTE2GY4HyAjurgIqW+E0LGrVLT65v8xSzdpnj2lo1tJc+9+dqC3Oc NY/cF+exSCB+l8t/d6jCHEe7sTE3K9bbKE+OKuGFu771BJTb5HwUv6jraWbKQsuxv5q1 TT1g== X-Forwarded-Encrypted: i=1; AJvYcCVFR0Z52TizzWzrI6Fz+Z9g/ZkpjPw/iLlQJ7Cfj0X8TP8eD1JuhbftUZwr8WxVOsAHHQCk7+Kv2w==@kvack.org X-Gm-Message-State: AOJu0YxLTajS0IuM1bwcpAcCpjQy+xNttXkhxAAlKNnKDSXMK0lD38NO 2YwnAJOZP1P59NLYGcpoAihHoEttW3EOGqTTZauAd2AqfQC8pVWL X-Gm-Gg: ASbGncufQTMbeMNuhlt/Tsvx7GKDHS/DICtxQHWP96j9msNTxxkf4OMWoOgRhdDESYy ULw6chUbuuAL51KiTZqSnm+wS4FnWHf6u2RL84qXEXoh/xLWhlVXeZaxQ45ZzeJmUR/b36PaTuR AHdudVHXBbnY2ohMRJwvsombLjt0pX3v4St0pLAqSjh0QW7tVRITluUbn0Jn+vGCyc4yOsNdWhM 2GGRuzFRYJqNVEOPXhoWynF0Nlls9Z+kuoLXRBvTFZx46uS/CcdD6+9MTBR44ark1X4yJMX33vH +GI6d4xW7Q3oJ/4j5InROY18yMmpq2jcA4Umxed6DIAEo7I2oyjMRg== X-Google-Smtp-Source: AGHT+IFF67KlYecUL0WmxKFTDoupCkyQsPEKSCULBGUTcLaEj+DN0Nn3mH6LnycLqR9SDA9Hwk/z8g== X-Received: by 2002:a05:600c:524a:b0:42a:a6d2:3270 with SMTP id 5b1f17b1804b1-438dc410c08mr125944455e9.21.1738433975969; Sat, 01 Feb 2025 10:19:35 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438e23de016sm95980555e9.9.2025.02.01.10.19.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Feb 2025 10:19:35 -0800 (PST) Date: Sat, 1 Feb 2025 18:19:33 +0000 From: David Laight To: Mateusz Guzik Cc: ebiederm@xmission.com, oleg@redhat.com, brauner@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 6/6] pid: drop irq disablement around pidmap_lock Message-ID: <20250201181933.07a3e7e2@pumpkin> In-Reply-To: <20250201163106.28912-7-mjguzik@gmail.com> References: <20250201163106.28912-1-mjguzik@gmail.com> <20250201163106.28912-7-mjguzik@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B0F6620004 X-Stat-Signature: wkorxr54s7ous947jnkujza3571h36tg X-Rspam-User: X-HE-Tag: 1738433977-969296 X-HE-Meta: U2FsdGVkX19JK/GQJ1AhTLEdHJjU/d+uK3+GhQxclxSLICXEa01bsl70EYiQdKgoJTVvtDHlkx1kzdkPNq3zi+zjzP1egmOL9Nn0g4ma7UuIkPco3V1ZRpURAefWdNBW3K7Vd/+5MtSY6pSswExDoiksr3uGpJecq2BGEXWahu4dx9PYlr6Oqp6eDS+VjuRnDw4yqu+6Z/HPWjdFVYFf5bQpMK87IwfcWIgQDV0KGwEGOp3p1z/BBPcukFVcPFWaEeGqqzdr1XA/J7jSTIisdcVTcqDgxaG8W01Ysac+/sohVVpZBJfNMpwjMpgQbtSawWrjPfPVGE4jHmsAX12Qt5dUaNin2V9BCz7Nrhz8nQNw1/OgMN3EgnuF/EaBnjIwiZMnutCDkX22fKIk7OoBttKh/S+UveeOfBeSTk5dMwtgndBRXBK2Lf5/odFQ0BaunsgYbAVd5nbKoXnI3ujREiFys5l7BKQkmkCqCfm7ncN4FCsgfV2J4EHKRB9tpr9UQQItumXan0PnURytrGCrBGkZRFS9J5VqR1yMHP7lUMsVuWwfjjx70V8mUOj+MJCGQmDmqP2YwpoyBf9zlBmio3D+siCfDPlLCN2OGR8PV61vM/1dKd7ws+A0rawDUl+u+G/QT0Hm0fS2lHXg+wHZPO7XzA+QqeWY4b3QExgsfr/+NiOmetX+7D07M9jocJ5ISJXfcI91sDH4CToqrHq4OjCSQ4fBjc1Gz5oNEBUa6aM4J07lNCaGr08M9w6o4EnP9OuRggibtvbLbditn820zPPYeQcpwAzfkrl4Y9s3zd3PeWn7owKZrHEVbNOBHCBOPaUunVvBg21Sa98mv8G7138lEfc1iBfBQcUrkVp64aq77H5ZjIgJMYezG28W9Vf/a5jyfexMuHs5pW/8tktJT7I4I1C93or7/duvOegX7WLo6nIgRdu+U3OYbrBiv4HmL/rZWjzpb+OmF9YLpDV JwSg4epg 4n3ChMTHIOvicSu/bcWqNyE0WMeFKVtaz8JyjnyYKStUFvDoQvm2pzOEgdsbLFvLBjsvbzRpWc8wfg4N+t5FJLhI9U/9w1kdQgQB0at9XIRGLkwItkRck/jUsK1u2IRu8JKoc9OoLxhOIVYjZ1k4vwQS1NDB9HOf6hyafAgNYBDR0DRubbS+kfMbrDzs/95MfNvR4T3oQ+/Ek3ureOhE/WtlJkLefYkHm8MUMHUi8Gh9AVpY9tcN0QBFFJF5U+qpwCzXjqrpE3eUMUOn3/KMRAKa3r+3LYkysedzzjMvb79S2JYceCdOgiTnxcVQtLbfqU60xhN4KGbxsLeLKEb/rQmHhR6MN9Yf4T0wwxSd1ASciNB0K0ezcEKPVRxiPmYl59t71I2/9odV963zLODHeZwq8iZY2jEQr1cf8rwjzv9S7AMcfuHwow0dXI+KoQSNBpJWbrHO3sK2WNhOkxyaGcyvRnw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 1 Feb 2025 17:31:06 +0100 Mateusz Guzik wrote: > It no longer serves any purpose now that the tasklist_lock -> > pidmap_lock ordering got eliminated. Not disabling interrupts may make thing worse. It is a trade off between 'interrupt latency' and 'lock hold time'. If interrupts are disabled then (clearly) they can get delayed because the lock is held. Provided the lock is only held for a short time it probably doesn't matter. Indeed, unless it is the worst one, it probably doesn't matter at all. After all spin locks shouldn't really be held for significant periods. OTOH if the lock doesn't disable interrupts then an interrupt will increase the length of time a lock is held for. This can be significant - and I mean upwards of 1ms. Network interrupts can tale a while - and then the work that is deferred to 'softint' context happens as well (I don't think a spinlock stops the softint code). I've a feeling that unless a spin lock is held for 'far longer than one should ever be held for' then you really want to disable interrupts. In this case if you get a network interrupt + softint while the pidmap_lock is held then all other cpu won't be able to acquire the lock until the network code finishes. The same issue makes futex pretty much useless in anything trying to do audio processing. David