From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6895FC0218F for ; Fri, 31 Jan 2025 17:58:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBEE56B0092; Fri, 31 Jan 2025 12:58:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D6F2E6B0095; Fri, 31 Jan 2025 12:58:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE7FC6B0098; Fri, 31 Jan 2025 12:58:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A15FC6B0092 for ; Fri, 31 Jan 2025 12:58:32 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BD73C1C83F7 for ; Fri, 31 Jan 2025 17:58:19 +0000 (UTC) X-FDA: 83068506318.01.6220CF9 Received: from cross.elm.relay.mailchannels.net (cross.elm.relay.mailchannels.net [23.83.212.46]) by imf27.hostedemail.com (Postfix) with ESMTP id 390A840010 for ; Fri, 31 Jan 2025 17:58:16 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=lNpF1Ute; spf=pass (imf27.hostedemail.com: domain of dave@stgolabs.net designates 23.83.212.46 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738346297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xj7nAF1HokwYhi8a8kaMtwzRSfvG3L4b/uXwqS9N5Cs=; b=nT6Xy4Xlv/fRw4NhWXwEVl1j2t6ekcasn/QCn5zcIQv/GVlJ9gHpiZElMP2Jx+C5d4+JA+ LohaOTMmpWJTd6ZTAbb3i33MN/CVBGl4m4JROoLTubdjS8O4Xr/uz2Gr0ItsswOO0X6CnA 5moRaYMMmoCsictN66iKeQQLyogY/mk= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=lNpF1Ute; spf=pass (imf27.hostedemail.com: domain of dave@stgolabs.net designates 23.83.212.46 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1738346297; a=rsa-sha256; cv=pass; b=Qsv+rJ/9RGP5thg1bD5Qk+idSMvdvPP/MOZ1r+Z3xoO7W4ImzhFqLqsoMljKGrGKOkH37+ ItDpLM0ngf3AyRZ9ExhbkFHXE7fYoWIdsGjdqGSK2MIVuUpyQLVrjTZkHP5OopatmzRS+I 3hLwdk+qDs4ajgBLItpYuQlrbi9Op6c= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id EC05C8A51DA; Fri, 31 Jan 2025 17:58:15 +0000 (UTC) Received: from pdx1-sub0-mail-a215.dreamhost.com (trex-4.trex.outbound.svc.cluster.local [100.116.71.144]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 5D0238A5202; Fri, 31 Jan 2025 17:58:15 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1738346295; a=rsa-sha256; cv=none; b=3EmE0PCDiiZoC4JBu0MtSfrbz+6+rT6FKFt/Jv8zoLnfFMIF/fD5uJatzJI1g4OwtCuNMa NydLN2jvDMTHUi4imHCGficb8IR4m9ZjGDVzI6o+nEV8Up+MAf2UXT7/dGjwlWrkV754er KB6H7UAE6ATS3vaIrvmfDHDZceC2yRTN9xqd4/NozkAyTHtLsbcXAe5PudDy+eHgNbCBO1 FV7pqkP+2Kdlc3h0LZ4Lw7L+SEjeDgztehWCaeL8a/ZUW7SRPR22E39Ffm1ohCQvZHfp27 gYpl2kOWd4GU8dUXJfqyjbXzxIGvvAUxWma/ja2NND1Vcx20qYFksX245g5Asw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1738346295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xj7nAF1HokwYhi8a8kaMtwzRSfvG3L4b/uXwqS9N5Cs=; b=GF0y7DUSrJhvQPPWIpzeQUiKm+UMM2Ln7HBEY+XyPZQc2XamuFrQSXV8B+bBfOCKyEy1Gq ToQTWofjAlo8bMniOvvj+4ggPOnxGYso5j0BZdEqIpdvzNm90+iTDuM1dhwxGN6IqY91/C Aq+mpJwHvJScJ1dLkTHuizKcPsoeH3zwrhVOkFHOW8v7RCMlqYkgKqnNziGADZ/j9AgL4A Hj6tXUaPRHGDzAC6gwfBLkqaxX6TYc0HYEZx20vuDAxqi4aswIMnEc5g88O+vqC3zPJAD5 cWaOwBTTWjF4AtYPlEb8LgwMYFitDZa3Yq6pwsX5q3qdkYJwvZ2wyns8neg3Dw== ARC-Authentication-Results: i=1; rspamd-8586946c78-5m7bq; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Juvenile-Continue: 52beb83522fde22f_1738346295649_334098669 X-MC-Loop-Signature: 1738346295649:3239223652 X-MC-Ingress-Time: 1738346295649 Received: from pdx1-sub0-mail-a215.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.116.71.144 (trex/7.0.2); Fri, 31 Jan 2025 17:58:15 +0000 Received: from offworld (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a215.dreamhost.com (Postfix) with ESMTPSA id 4Yl3XQ4lDSzL6; Fri, 31 Jan 2025 09:58:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1738346295; bh=Xj7nAF1HokwYhi8a8kaMtwzRSfvG3L4b/uXwqS9N5Cs=; h=Date:From:To:Cc:Subject:Content-Type; b=lNpF1UtePnKosIswfrACFOtjekaSXQFRR8a0tVIFi76znsk9WgCBMTAkzJ8t2smOf XEwSe3KR9JPfyydx5aUlUPfY/pDUtDI1zOxn7HdMs6+qRSLyN1HmXHJqbB89PW8sMb aLQ6TA2CR9lE8YlPZAUX5kpTrlnpQVkswmmqmRw21wOtv+tdmORf9cD71XeoQtmWq8 +nkJaXGTgNc0LTeQSjmJcjn2ytRYLWeeLjmAHq34WYty06jqfsd9qfhZ+o6v+tiohd sMgnVSjE5LsRhTHaT3mBI857OGrvTqNXAmEFqigoJBRY4f/v1+QsIuiBhX2DCaXjpX Gn46mlRM7gfYA== Date: Fri, 31 Jan 2025 09:58:11 -0800 From: Davidlohr Bueso To: Lorenzo Stoakes Cc: "Liam R. Howlett" , SeongJae Park , Andrew Morton , David Hildenbrand , Shakeel Butt , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v2 4/4] mm/madvise: remove redundant mmap_lock operations from process_madvise() Message-ID: <20250131175811.37fcmoevcdpeoaj6@offworld> Mail-Followup-To: Lorenzo Stoakes , "Liam R. Howlett" , SeongJae Park , Andrew Morton , David Hildenbrand , Shakeel Butt , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250117013058.1843-1-sj@kernel.org> <20250117013058.1843-5-sj@kernel.org> <20250131173132.uqjwrzj7e5vx2sbv@offworld> <7k2gs6xmx2q7la6kle5xpn2p2f6bccbiv5lrdowp5hnecxpijx@rzwxdhcl6mc2> <5fc4e100-70d3-44c1-99f7-f8a5a6a0ba65@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <5fc4e100-70d3-44c1-99f7-f8a5a6a0ba65@lucifer.local> User-Agent: NeoMutt/20220429 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 390A840010 X-Stat-Signature: buer9p3kccxjrupsbw3icxusiorxona1 X-Rspam-User: X-HE-Tag: 1738346296-353353 X-HE-Meta: U2FsdGVkX1+tSAqU1PIh/Sp5JS/wBAHnK31KjpjVpcH52zqqkZwqB7NMRaHSm+lqv2rkpBUJnlYOriM7uM24MREd8s8Ep/22cqTka0csCnujvTYKw5LP5VGTldraQPdAeeY7RWJLqIek/b3el6Jj7Gtmz1hHUFFqGOS9j4xNj7nTtGKr9c+nYIzdf16O84DWOo6UGdzEiANdAcGtl3t3I4KQDQJ7k5PKw61bcHuzTs+lw5a+uN404E3/CB2cZVZ45Tb7iLa+cRG0z5+MPlz22OE8QJbh12NKp1+9URtnQin/EWO7PY2YTH8G6Yvy1ayTFUa3kVeSNT+Bd0y2DVn4UuzPHdl5CmxtqucOYRjaqNZ5MKg+DstEGi1vhKFcLwxM2xYlg62dcPYGKBa5leZoLeO0DXRzalZnY/jgs/cGBLidthVhk+EiKxJZZw3VnNmn6dGUl/0HO8D4zhO0aZSGZU7i5TmNBzt4fqsVCIquT7kiNKKtyjJ0PjUrCTCuwLATYQW9FBO3Mr0NbY8tyBieIdOtHdlaQTOCPa8t7mzZlXvnWR06PjiCoCEO98C7KgRRCDklXrflxClN147jBQibQodgmAh+yejercubVgxK6BUYfaBWygyHVi234tEdhKrqXT9nbS1jC7zYz0IFyxpK6y2WeYIPwXLAMO0uCfYFt88TiEoNUeAr0UCxb2KUSQfOQBs75eYOg/cGhf6FrF0kx1HAzE7j5URNmHUnIv4knBaGOrjxgFjG6N1dctvXaXtr0Nw6J5tE5cMyym0tusmGBIb6x12V0J3E2wn7QeN6tMH6GXODckj+0FAyQDDo8s4EA+8ZK4lI8VY6HYOvvsCM07JwTAlUdmGpasnA/ub6QJZeQRPiqMooHyw6j5lGMWDAxoDMQdQh+cnw4iouC5XVkK0O6m6EC1PPpRySjwmQvH3doPi5ibjltYTlrIz+ySVxrwWFbPOdKNjwa9CCPTN DLs8LX/K CWnjyl6O3EcC5QDUExCdxftZYamilFsqgt0z4vOVFvf5z0uyP/Gyyr4BgiJaw9loWuCBBvDoYp32zkF6C76/k/3Ki80CPcFmRd08KW6isHPDgraO8qa3LcmgrP0wOYJ+nbfwxgDArU4G+FtE09xmBlsA9CjVLfwFRnw5t+Kag5kI53amJwwt+qm6I/SR+/Eo8zo1+tmjfpc2qViHHN6bVfI2Gma2FgCQt/HqkE7/1GcWkFJm3rssGZnW2lVczOsGgyssTWin2xFSFH+T/iuAsihjnwm1vYAM36Qnuut8D60BN5Am+uUBrlw4PVVLRK9xFYlrrZDkQ66hTiI4vrIzuDp5zK/c26Qr9yGxReVy/lOBcQSnCo3nJ1W8zqrH7zQcqtgTEgZQxsh6OdMk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.064692, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 31 Jan 2025, Lorenzo Stoakes wrote: >Keep in mind process_madvise() is not limited by IOV_MAX, which can be rather >high, but rather UIO_FASTIOV, which is limited to 8 entries. > >(Some have been surprised by this limitation...!) Ah if that is the case then I'm fine with this patch as is. > >So I think at this point scaling isn't a huge issue, I raise it because in >future we may want to increase this limit, at which point we should think about >it, which is why I sort of hand-waved it away a bit. Agreed. SJ, feel free to add my: Acked-by: Davidlohr Bueso