From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC09EC0218F for ; Fri, 31 Jan 2025 16:46:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FCED280002; Fri, 31 Jan 2025 11:46:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2ACDE280001; Fri, 31 Jan 2025 11:46:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1274A280002; Fri, 31 Jan 2025 11:46:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EAA3D280001 for ; Fri, 31 Jan 2025 11:46:45 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 59CE080D9C for ; Fri, 31 Jan 2025 16:46:45 +0000 (UTC) X-FDA: 83068325970.18.E357468 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf03.hostedemail.com (Postfix) with ESMTP id 4CF9420010 for ; Fri, 31 Jan 2025 16:46:43 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ps1FWgzI; spf=pass (imf03.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738342003; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ti6v0mAqwVoxspgjnXTmtkuGfTItRUrcJbmGXMiisyw=; b=iUmsG8pDcYSNvtd6DEZXNGX84FhcqpomdH2R9bsaXL5ZKWIOg0094heVgSiD1yU36s4jtH u+aaJ5TbI2uzdzsjGgKOxiZwVfObREzJ5FfUsndeO0ziZ2cvSw+N40EkzuQAOBWx7GYPpe SNkL4QVCiyB5xeaExkocwaSX780wrY4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738342003; a=rsa-sha256; cv=none; b=FAOPb8qJaT0fWHZNkqWX50PRjRY6DlgF8cjmKtRQ/OpufqpZbtPU7W4oiOb1P3KqqZpjuq VhWE7zGmsnYpi5PfKHiZ9gLqyylYHtBXRMtfhSsPjRGKKfbQ4WRl8Ad6RY7FDEg8s3bkYw qfEHxIAiXFuk1dHERI1U9XpeX2AENsE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ps1FWgzI; spf=pass (imf03.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-aaf3c3c104fso446875566b.1 for ; Fri, 31 Jan 2025 08:46:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738342001; x=1738946801; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ti6v0mAqwVoxspgjnXTmtkuGfTItRUrcJbmGXMiisyw=; b=Ps1FWgzIeJ957M0qs56WXfZGDM/In+vb6qjrr7BeCg8dvDGZE5DlXBPp1207kZu+os ZeA3yJ7TOr3/Rg+38pvnSDx8DauSTFL/ie94/JUMvLWiUei7F0z8GJBg5b221uS1rlaW n0/GtJVgt4t/n9C5z1ZW89POyancRzIt/YjH4LQGF7ZCpYGN2/VoIMYk94MrKKNdQ/bp e+pnMC0mycBMbKyXF06JyT/cRMBtNEuWXJx/RQkzhOYr7kXyTfCjIctMXrPr5ac96xeT W3pcl6FBYLnzbvgmyScsVYV7cBCcjgd1d3hdazhujLYIjnTk/OlYLWzkeRLo9yqcTncw 36hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738342001; x=1738946801; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ti6v0mAqwVoxspgjnXTmtkuGfTItRUrcJbmGXMiisyw=; b=Nv8xOz9zoBJsqUCzLaa5EjdkZJOJ5SxbF3ilm2uOarsLg92xUhFD1Pjw+OWfpo8u2k pAF7TghwT1t5sndC5JvATWOMAZGA/XWQK1E4Mpl3YQT2Nu18i8pY1OZ7VIyqBsQ6HoRw 9bs1Bp14rwRfYWqT+LZ+mfh/z1p6XwFJcNtsVCz8seSg+D5pUztwvEb5yuge7hGZ/zE/ DXb9ZdN9P2G77wnfvRi3zA4ip4oWFTe8CcdtMiUVJEBXNcqeoPFwbwEQHH7uyRBGXrgx GkzPvDlMN0278YNv8m8vY8U3xjo7dFfymDbFV/l5IMvZKd94YYZl57g06yuKP843ICUd h25g== X-Forwarded-Encrypted: i=1; AJvYcCWb09h0zMOp1uHEUE6U/uJjWfP8LoVITnbz+HZkdJSAsAteC5zBVSbAA/bHVHFTrQedXkdunhunXA==@kvack.org X-Gm-Message-State: AOJu0YzXf3GXDo2tYGdq5waQYmkNUcTkPywNQ3z/gCdIZK9b0UumOne+ PdNVqnjzKSYsjVJGH49KFXzBONB6rfCYazQ1lu11bqmf1bq3UzGL X-Gm-Gg: ASbGncs+9atMXQBq/hY+lUG0r3HpsnuOg87rtYqlZEXfn7+P/+/0912e0MPjM8xck8P HeRWjTEBnw2bQMtXVVQq4ryaiOHQA12RDJyNXa5M0h/LES1LkH0SWGHjdETZkp/Sf85UkR0EgcB fs0513TuYuqlStaisBnKfDyl8Npay1DIqpUZwEVXbxjNie6PjXqzcTkzMiGfyJiMYed2IGcttfz n8w9bo3WRgGBzRBU7tUVGZ4aTFquNL9cfgrCGnNXG8IW+AzWse70O/zBQg3lVaf/vYKwUKJrVZH xj2DOdV0mwDN7NQ= X-Google-Smtp-Source: AGHT+IE8L2sEwFg9cs9BJUBl96elJDyfOGN4H9qYrXvv6utIRe8b6ee1zZ65Z7FYi5kOo6o4N46feQ== X-Received: by 2002:a17:907:6ea3:b0:ab7:647:d52d with SMTP id a640c23a62f3a-ab70647d54dmr330955266b.51.1738342001244; Fri, 31 Jan 2025 08:46:41 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6e47f205bsm322338766b.86.2025.01.31.08.46.40 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 Jan 2025 08:46:40 -0800 (PST) Date: Fri, 31 Jan 2025 16:46:39 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 0/7] spanning write related cleanup Message-ID: <20250131164639.o2j7dmwymrcmufh6@master> Reply-To: Wei Yang References: <20241127012753.3393-1-richard.weiyang@gmail.com> <20250117054942.w6vgrllnaasjaww3@master> <20250124013412.2vpf7davx63s377d@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: 889hw5xrjxfcuxxqbssskmsw9e6ud9o5 X-Rspam-User: X-Rspamd-Queue-Id: 4CF9420010 X-Rspamd-Server: rspam03 X-HE-Tag: 1738342003-77853 X-HE-Meta: U2FsdGVkX1/YCbf+elVGrXo0P/ieJzANI2w+RxXAPp+FmgnUeCfZ/wFad2mx/tpsKBiTQMdGxFt8Yr1K5M6FkShsMKxqglTReCc+KAhGvv0O9fB5No04J3NWfsJQNK6ymxDnuCfMCIbLmn6ISsQtlkkTmRbhC0AgQAg2zanxWKzpjBTh4B7PM/6OZ/fK4I3NeMusus/uRypA0xhgeXCZUv2sQ2pxeTapC+HFsYO4asEf4dEqS0VcptWkaWkc2xi4Jr/JPMvfsRDmVhXKsnwyYwc5v3iRfRWuGdNjhNc8RySsuV/oiWUkJPM1vZlV5g2xJwX8AS/BWk+GczC6/3/22zwYSCzgwmZfEmI2FhZcSjAV9y5uaRQqVkO0TLhrOEYlosbfG2Rd7AfGL3QZItvOGt7pwyg4rVRxi43XXKXQmlY9OizSxUHdk5HbiN0X2/smbwmU2Gn7gvoLXB1jzesH8dAQLJgRqWU5FI3qx2EWj4RYKXorlNP9fNqkGGouonkfiUcD9R8AwZ4pmM9k10cMNNKHfg7JpM7KrgzxKzOgyKT5gSsYJNG/t5iKmzlTd9SlUg6qCPUc5+fLQ1rPysmehQDpFANecpxypN2n3B3zSzlGG//72PQUo8wlK30Uv6BBK3asCvLWhsmhLUxNrjAs0WQsJTe65ncN2VhlSPwd0Ylf752jamnx87X2X+TJk2Rs+yPj7Jb5sbc2hgYg03nExszAGDF1If8nrwat2Na9rw2dWQECR70wS8jmktuNKxUv6+65SDU0LeHdjoplC+htpBhLowQDHsbah1FJ4Del3vZ7WMUfeGiyZyXlExgV5mvDJf0gPbO1xiSNr2SsRzMzonwGWdtx4zS5PNxUL6Gc2Pn3afNkQT+fcdoFEL4Av6uE7ACPK408NJ6MWg+j8Tpl4pj/bWrz7wvrgmkzZEhj3f8fOf3gMGezDXIZljgCq7GaV15wcRRSIF5KQRjzIL9 IzhHXUqN 8g2m0MDwR0AXGo80B8hOXoVvrsEDpXJOtlYLysk5i7HB3bgbUYPyQ/ZRH4JjRaQg49K5YUMZJXWduFGzTd6Qhqm3lVpPBFdDJieh58DZzUqGoK5+VzRGo9Qo/9zB12bN3vvg1c6pCwt2ywflLTbLAm8n0KxsmlxyZHHZUsUkru147O3TSqTpO9g8emku72J3IoiwHP5nOWM4daFhhl0HobcH13r12JD5thN4lSwDpuwaz5xSb8IQEQdJaX4tdQ06V8A9Ntre4NSpAkD7YA4imiDykFpEVLUx5+u0OdTAwMcjvvXo4hYZT6kXiHAKSTfHKhKSx4sH0hy97qDrXl+xunbAJygCH0npK7FVhxdADeKGMTSdMeyghElveJD20qLBffkXryDYbojk5QhZ10HJhSH6+PhDZ5Z0or6rnK9m0sfKCBg4chRD5OvN9TkMhCHgjw2KdnEK7rxJuym06JnHMMfOecBsO+YGxvZ/T0i1hjfLfTtN674nzHMSj2JimXf5GEizNos2Sjwdh4QvFm0ocfB5OxGuQ7uo+oik7ACJir3eHqNMgugD18quqnWvbtKQvHGd1bcDPHKw8785J8BLKP97WNcmj2RvCUfmrYfaDfzHePQiIVnFAK3DAuvrOllu40oAaCg2rkek1y7FYrIYW8BakXqGUHessJR/IKjtBKx/uki4E9ujbyaNIUGce3HsZbE7j X-Bogosity: Ham, tests=bogofilter, spamicity=0.020331, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 27, 2025 at 09:36:11AM -0500, Liam R. Howlett wrote: >* Wei Yang [250123 20:44]: [...] >> >> Hi, Liam >> >> >> >> Would you mind taking a look when you have time? >> > >> >Yes, I'll have a look soon. I don't love changes that dive deep into >> >complex code that results in no gains (performance or feature wise). >> > >> >It's also odd to have simple "this return isn't use" and things moving >> >code blocks to be executed only in certain scenarios, as the difficulty >> >to verify the latter is much higher. >> > >> >Can we please limit changes to areas where there is a performance change >> >or coupled with a change that is needed? ie: stop sending patches that >> >change things unless it's with a feature or improvement (performance or >> >otherwise). I'm just not convinced some of these are worth the >> >cost vs risk. >> > >> >> Ok. >> >> So you would drop this patch set or still want to take a look? > >I was going to look at it, but after I send my reply, I received a >report of an issue caused in a certain configuration that caused the >stack frame to grow out of the configured 1024 limit, which was tracked >to a patch you added to simplify a previous function. > Liam, I tried to locate which of my patch introduce the problem, but not succeed. This is the issue of -Wframe-larger-than=, right? Would you mind letting me know which one did something bad? So that I can avoid such thing later. >So, I think we should drop these patches since they don't make a >measurable difference and are not without risk. > >Thanks, >Liam -- Wei Yang Help you, Help me