From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9BC5C0218A for ; Thu, 30 Jan 2025 08:59:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0ACB280275; Thu, 30 Jan 2025 03:59:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D93522800D0; Thu, 30 Jan 2025 03:59:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B98B5280275; Thu, 30 Jan 2025 03:59:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9848A2800D0 for ; Thu, 30 Jan 2025 03:59:51 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 49A7644C57 for ; Thu, 30 Jan 2025 08:59:51 +0000 (UTC) X-FDA: 83063520582.20.65F6FAD Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id 9A1AB140004 for ; Thu, 30 Jan 2025 08:59:49 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=s51TA5iz; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf26.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738227589; a=rsa-sha256; cv=none; b=747v6BptbVYuw8VRxYu/3iZX4xH2Zcr15B/uDOTURho1YWgZSc38xDYCPLGbmLcWmBm0RC aatAsyCZakdi2Cfw44EyX2ygL4MJGOwnRRpsim97y7rRbibAnja2DgQ3ntcyND/csR+LfG 5oJVPNlXa2mn3Fmh62nMeE72uTvF/8Y= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=s51TA5iz; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf26.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738227589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=vQYkeKprk8QBB+ifNt5dRfdD45z5poGoLEKA49jE1wg=; b=e7YSC11aAWeLQpgEPANgGo4wNT/9l5CtQBipCYaAVvoCWZ0DGBIoID7f92DvGw4Q8uatUu z02JG7Eevr6q8IfzhXoM90dfLqJxmM+34jwnU2wg9KEohOm0XxAbYRY1mGcB3tbmEBgd+F 3wjTfLVpjn7J4EGx/CBkIsypXNxzNwc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 6398AA41CB2; Thu, 30 Jan 2025 08:58:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D65EC4CEE4; Thu, 30 Jan 2025 08:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1738227588; bh=kuztF21rfhyfULws2z1Gttcnd70hOBYfLotgHAnBaBw=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=s51TA5izpnKvR85co3UgcenQwfLe44RqMQLEJ2kg8QJfsDM/7CuapQBx/N30ngZqR qfb95iF3D0XLSbE/+PGix0zKYZkQ1saVpljyHHJKCDZg8BtZWT2jLsic5ZxXSOYkjr IFYxN2rj7sTtagzi9+sMKnGxx1LIAi3gLa+oUQdY= Subject: Patch "libfs: Return ENOSPC when the directory offset range is exhausted" has been added to the 6.6-stable tree To: akpm@linux-foundation.org,brauner@kernel.org,cel@kernel.org,chuck.lever@oracle.com,gregkh@linuxfoundation.org,hughd@google.com,jlayton@kernel.org,linux-mm@kvack.org,sashal@kernel.org,viro@zeniv.linux.org.uk,yangerkun@huawei.com,yukuai3@huawei.com Cc: From: Date: Thu, 30 Jan 2025 09:59:31 +0100 In-Reply-To: <20250124191946.22308-8-cel@kernel.org> Message-ID: <2025013031-tidy-deodorize-9dce@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9A1AB140004 X-Stat-Signature: 9su6jtwhbmkt9uxduho8ppmppa9fm43i X-Rspam-User: X-HE-Tag: 1738227589-993170 X-HE-Meta: U2FsdGVkX199zJY+8DnmFS+fK3Z3sC5+IFTM7wu+KosHY6mK4VXu6JWmF5h7LGQUP0aZcGK2zlYAlWFRe3dcF5wvVXyF3cm5fzEnaIOomjUPoVGAisxUirkuDA+0ZBX/yyf6ECCRO1Va2kWaQP9T2fDyCXOpVvZn6t3QkNURGQIMeDnOVX2Ok+LzQCSbXRieroV6hve6R6WXTZqabk8/XQP9HHo1c56324UeBGW/Fg7hZi+0T71i6riVtungMQYpYZ4yUEugLKSFjm599Mk0ckc70a4TIzwj+NQDm0OP08M0z7p+NJB4yIQ75inEOnThUnxatNQhxwfP5oXNFm8XhEw98UHeEV3LOqM+9uQkGSrcRPnSzPNRFVg6Ka9BTzsZ93PwNvkWSffscMkERhNtlyinBjWw2yCr06GIctG+cwC6Q8iSFQ3K22ZxidyyKvq4sbf+lyx0PJ7LScSgqgS/+3VMPvpt+xU3gz+N/XrgidmagFe1PbGiGyytqpTfOeD/F2wPydakCs0pMUWZ9csI+cTkVcsVopx8KhSULrmurLse5EyOJN5rHCqh5kCbWyVBs6uwci8/frFtLaAyhbjRZVMaJQsPBB/0zxaTXu0dRrW99H6POTBN2+XcIxe9ggaAUr67aeZEUyOTRgmTATg0KtivV1v0PjleOt8Kt7gqbMUt1MFYH1SbwTuhdc+LZ7NkqVlEzgytURFWb686pejjGtiCGhVcv7y03SuZh6CMzxi/ZI2tKbo8ym9VSRwhLPvCUgV2hbvQgDLaTc4X+i2C3NUCXX4hz5FoqkUtA6Km27IrwG9l0FuLHmQzz9qrUlcahxqh51zjFxTeL6xuXTHYVhvFB/4lpyssSy46rOe6O5rxkq8KYNgWFyS1NziS89YMTLeXn6cSIee2ZmtdMtqeF7RTMHJVFf0Lag3/DEaibO72pEH2X14Svyin0rOXCCdzHwTcQI3Iti6ZH7MUIzW guTdHUmA h+vO+/rfba4fq3PzRkruUQxTkxBtHvloNzMe4c6OyX8fnhcLzfPyb0oJPk5xG8DuD18fJqw6UePiAPPHiC+0c6QiUR58kzOM2usfUbMPLFayNLOaRFc4NnUmPYRi6SHfY3tTJTZ0lWVl4dL7vVKY6l90L2jTG+gvFQOIicSCjgMqmz3FiBIA4sZIUT06xUykPGvTvkiQevZrwNa1J3cqTtB88AbjwB5padTzg72l7WoSeFcrP/vHpf/4+4+l9WNkvPo+LBstW5jEViqPKmbKbNxJMGTlHJ7+EX41nQLK7gLlkwHi1bJgsjCKZiTIXQqDY+LfTOjZxOUYJ0s6TUsLpTndFkKKzvLzBlt5e4s03xfhn5O+PzhXtXH9/cS3VKeLmb9CggM8tHwlSnBfi3XL92ISpOUbMmHFB/HjJt2YPZt4HkQqV6zNx2e1v033Kq1ZrMNaB5JxSme6OX1ImFTUfl0mK8xN832VQDXVvtnAc/n3sCacD1C5HBBdnImyw1qksHMCy88bbb35HQjZl4jaZxDSqscS3m0qdMU+XuyswjFE6f0smGQoJ1Dxe/OCg/bDojdCC9OO9Tb9NWsRb20+HS9magQ/mZK9D4m68W1/JgiLhNJMQcr7Pt+nYuJDU3C2Cq7LydOWl4xT/pFlNtqawEkwk3cFJG1P81lkzG7ya6tUNMCu9hTPlUpHNtQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This is a note to let you know that I've just added the patch titled libfs: Return ENOSPC when the directory offset range is exhausted to the 6.6-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: libfs-return-enospc-when-the-directory-offset-range-is-exhausted.patch and it can be found in the queue-6.6 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From stable+bounces-110407-greg=kroah.com@vger.kernel.org Fri Jan 24 20:20:27 2025 From: cel@kernel.org Date: Fri, 24 Jan 2025 14:19:42 -0500 Subject: libfs: Return ENOSPC when the directory offset range is exhausted To: Hugh Dickins , Andrew Morten , Christian Brauner , Al Viro , Greg Kroah-Hartman , Sasha Levin Cc: , , , yukuai3@huawei.com, yangerkun@huawei.com, Chuck Lever , Jeff Layton Message-ID: <20250124191946.22308-8-cel@kernel.org> From: Chuck Lever [ Upstream commit 903dc9c43a155e0893280c7472d4a9a3a83d75a6 ] Testing shows that the EBUSY error return from mtree_alloc_cyclic() leaks into user space. The ERRORS section of "man creat(2)" says: > EBUSY O_EXCL was specified in flags and pathname refers > to a block device that is in use by the system > (e.g., it is mounted). ENOSPC is closer to what applications expect in this situation. Note that the normal range of simple directory offset values is 2..2^63, so hitting this error is going to be rare to impossible. Fixes: 6faddda69f62 ("libfs: Add directory operations for stable offsets") Cc: stable@vger.kernel.org # v6.9+ Reviewed-by: Jeff Layton Reviewed-by: Yang Erkun Signed-off-by: Chuck Lever Link: https://lore.kernel.org/r/20241228175522.1854234-2-cel@kernel.org Signed-off-by: Christian Brauner [ cel: adjusted to apply to origin/linux-6.6.y ] Signed-off-by: Chuck Lever Signed-off-by: Greg Kroah-Hartman --- fs/libfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/libfs.c +++ b/fs/libfs.c @@ -287,8 +287,8 @@ int simple_offset_add(struct offset_ctx ret = xa_alloc_cyclic(&octx->xa, &offset, dentry, limit, &octx->next_offset, GFP_KERNEL); - if (ret < 0) - return ret; + if (unlikely(ret < 0)) + return ret == -EBUSY ? -ENOSPC : ret; offset_set(dentry, offset); return 0; Patches currently in stable-queue which might be from cel@kernel.org are queue-6.6/libfs-replace-simple_offset-end-of-directory-detection.patch queue-6.6/libfs-re-arrange-locking-in-offset_iterate_dir.patch queue-6.6/libfs-add-simple_offset_empty.patch queue-6.6/shmem-fix-shmem_rename2.patch queue-6.6/revert-libfs-add-simple_offset_empty.patch queue-6.6/libfs-use-d_children-list-to-iterate-simple_offset-directories.patch queue-6.6/libfs-define-a-minimum-directory-offset.patch queue-6.6/libfs-return-enospc-when-the-directory-offset-range-is-exhausted.patch queue-6.6/libfs-fix-simple_offset_rename_exchange.patch queue-6.6/libfs-add-simple_offset_rename-api.patch