From: Andrew Morton <akpm@linux-foundation.org>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
hch@infradead.org, urezki@gmail.com,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/2] vmalloc: Introduce vmap_file()
Date: Thu, 30 Jan 2025 16:48:36 -0800 [thread overview]
Message-ID: <20250130164836.1163f66bede77ec4bcc9d4b9@linux-foundation.org> (raw)
In-Reply-To: <20250131001806.92349-1-vishal.moola@gmail.com>
On Thu, 30 Jan 2025 16:18:04 -0800 "Vishal Moola (Oracle)" <vishal.moola@gmail.com> wrote:
> Currently, users have to call vmap() or vmap_pfn() to map pages to
> kernel virtual space. vmap() requires the page references, and
> vmap_pfn() requires page pfns. If we have a file but no page references,
> we have to do extra work to map them.
>
> Create a function, vmap_file(), to map a specified range of a given
> file to kernel virtual space. Also convert a user that benefits from
> vmap_file().
>
Seems like a pretty specialized thing. Have you identified any other
potential users of vmap_file()? I couldn't see any.
If drm is likely to remain the only user of this, perhaps we should
leave the code down in drivers/gpu/drm for now?
Also, the amount of copy-n-pasting from vmap() into vmap_file() is
undesirable - code size, maintenance overhead, etc.
next prev parent reply other threads:[~2025-01-31 0:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 0:18 Vishal Moola (Oracle)
2025-01-31 0:18 ` [PATCH 1/2] mm/vmalloc: " Vishal Moola (Oracle)
2025-01-31 7:09 ` Christoph Hellwig
2025-02-03 19:23 ` Vishal Moola
2025-01-31 0:18 ` [PATCH 2/2] drm: Use vmap_file() in shmem_pin_map() Vishal Moola (Oracle)
2025-01-31 0:48 ` Andrew Morton [this message]
2025-02-03 18:53 ` [PATCH 0/2] vmalloc: Introduce vmap_file() Vishal Moola
2025-04-08 14:04 ` Brendan Jackman
2025-01-31 7:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250130164836.1163f66bede77ec4bcc9d4b9@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=urezki@gmail.com \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox