linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	Yosry Ahmed <yosry.ahmed@linux.dev>
Cc: Minchan Kim <minchan@kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Nhat Pham <nphamcs@gmail.com>, Uros Bizjak <ubizjak@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: [PATCHv2 2/7] zsmalloc: re-shuffle zs_pool members
Date: Thu, 30 Jan 2025 13:42:45 +0900	[thread overview]
Message-ID: <20250130044455.2642465-3-senozhatsky@chromium.org> (raw)
In-Reply-To: <20250130044455.2642465-1-senozhatsky@chromium.org>

There is no need in having ->name at offset 0, it's never user and is
being followed but a very large RO (after init) array of size classes,
so each time we need to lock pool->migrate_lock (which happens relatively
often) we need to jump over that RO region.  Swap ->migrate_lock and ->name.

Move ->pages_allocated is modified relatively often, move it up
right after RO size_classes arrays.

We modify ->compaction_in_progress and ->stats only from compaction
(defragmentation), which can run only on one CPU at a time and,
depending on the case, may or may not be common.  Move both to down.

Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
---
 mm/zsmalloc.c | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 8972b4b56cd3..2280ea17796b 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -204,18 +204,15 @@ struct link_free {
 };
 
 struct zs_pool {
-	const char *name;
+	/* protect page/zspage migration */
+	rwlock_t migrate_lock;
 
 	struct size_class *size_class[ZS_SIZE_CLASSES];
-	struct kmem_cache *handle_cachep;
-	struct kmem_cache *zspage_cachep;
 
 	atomic_long_t pages_allocated;
 
-	struct zs_pool_stats stats;
-
-	/* Compact classes */
-	struct shrinker *shrinker;
+	struct kmem_cache *handle_cachep;
+	struct kmem_cache *zspage_cachep;
 
 #ifdef CONFIG_ZSMALLOC_STAT
 	struct dentry *stat_dentry;
@@ -223,9 +220,14 @@ struct zs_pool {
 #ifdef CONFIG_COMPACTION
 	struct work_struct free_work;
 #endif
-	/* protect page/zspage migration */
-	rwlock_t migrate_lock;
+	const char *name;
+
+	/* Compact classes */
+	struct shrinker *shrinker;
+	/* Permit only once compaction at a time */
 	atomic_t compaction_in_progress;
+	/* compaction stats */
+	struct zs_pool_stats stats;
 };
 
 static void pool_write_unlock(struct zs_pool *pool)
-- 
2.48.1.262.g85cc9f2d1e-goog



  parent reply	other threads:[~2025-01-30  4:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30  4:42 [PATCHv2 0/7] zsmalloc: preemptible object mapping Sergey Senozhatsky
2025-01-30  4:42 ` [PATCHv2 1/7] zsmalloc: factor out pool locking helpers Sergey Senozhatsky
2025-01-30  4:42 ` Sergey Senozhatsky [this message]
2025-01-30  4:42 ` [PATCHv2 3/7] zsmalloc: factor out size-class " Sergey Senozhatsky
2025-01-30  4:42 ` [PATCHv2 4/7] zsmalloc: make zspage lock preemptible Sergey Senozhatsky
2025-01-30  4:42 ` [PATCHv2 5/7] zsmalloc: introduce new object mapping API Sergey Senozhatsky
2025-01-30  4:42 ` [PATCHv2 6/7] zram: switch to new zsmalloc " Sergey Senozhatsky
2025-01-30  4:42 ` [PATCHv2 7/7] zram: add might_sleep to zcomp API Sergey Senozhatsky
2025-01-30 14:21 ` [PATCHv2 0/7] zsmalloc: preemptible object mapping Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250130044455.2642465-3-senozhatsky@chromium.org \
    --to=senozhatsky@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=nphamcs@gmail.com \
    --cc=ubizjak@gmail.com \
    --cc=yosry.ahmed@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox