From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBFC8C02190 for ; Wed, 29 Jan 2025 22:46:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56B3A280273; Wed, 29 Jan 2025 17:46:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 51ADE28026F; Wed, 29 Jan 2025 17:46:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BAE3280273; Wed, 29 Jan 2025 17:46:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1A90128026F for ; Wed, 29 Jan 2025 17:46:52 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CCC16120503 for ; Wed, 29 Jan 2025 22:46:51 +0000 (UTC) X-FDA: 83061975822.09.5CEDEA1 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf17.hostedemail.com (Postfix) with ESMTP id B250C4000E for ; Wed, 29 Jan 2025 22:46:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=P2UpNPuy; spf=pass (imf17.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738190809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GmvxfS/EO0PIn6aCNLLuoJebE/8xsvo0sCWW4T8X2eE=; b=xE06tyyyVCSIwkKw2bos+k5HOoPZjJtbSZLYeblQFRXIAunNF6O0VEPV5JfRtt2FPfys5+ Kp3y4OD716ndQddYs4gDNXd/CBdS9SwdPLoX/tGnfAf7ZvMu3Qg3biIS8yn0fFoTS6PyOV yfLyd13CXOB3w+grsGOdfG7CfFtvVWo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738190809; a=rsa-sha256; cv=none; b=iM4ZFlObhgCTZhvCRBG6yrhpQjW0Q5B/Ey22RzuOYwE/yytqw9VcM5Ye/xfyx/+Qjs/vfp xt1oo9o9cDkxqCLjYYHv0aJNIx682sDKMN6R8YzVBk2WaDuaEvjvaLn5jKAyfnfHENn/li GmA5pQa4dypBQXNsKjkT3cQ3iRgB0nw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=P2UpNPuy; spf=pass (imf17.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-385e06af753so74602f8f.2 for ; Wed, 29 Jan 2025 14:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738190808; x=1738795608; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=GmvxfS/EO0PIn6aCNLLuoJebE/8xsvo0sCWW4T8X2eE=; b=P2UpNPuy6TsgrjAJghSZ2Tzr33/nJMt/bImoOrRI1qS2JnARdy1vsPNI3cnoSf49/1 6jkj9HJol6i1v9qFj094e1rfzyvJd46m7L2Q4DwwKrnBH1R09fyyAEu+FXc025jq4U0i Qk1E7ytp8oTA9OPnPfLmF5+fhsUlUkYrMF8wfcpYkRZBb8fXFq+jZKxD89qUcMwcclQ5 szPtoIarTtRKJauR/FAv6DiL/LsytIkouYCtucF2/Um0n1lUZWKIujv26XoNSHKeQUZV nrafPVIT/qU67BgiMR9w5IBfNiyG6jnPEvB6j8GnnIPEj42M8/M62VHrDfJRqqTsNmXs 96UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738190808; x=1738795608; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GmvxfS/EO0PIn6aCNLLuoJebE/8xsvo0sCWW4T8X2eE=; b=w3zOqxkkjvyzj3a7dgG4I7ikodnpg7pmFuGp5/aqql3onvxmcsUbFFxDtvyzmpUPYq 0F9Ui4IOpuVdILRyoLtEn8gL+XHn33DsTz+8Jams0zkKK5rEvMnB7TP+vrxasI32GWvZ UDaPr3aVLutiTOkbqJosZKU+fjkoKvKrgK9u2608+nCh8F5YnxQ9gjaXM+HeKLDg94V/ pRl6kajlUVoC6XuLoPB2ahZfpFWP3FDe8WCyXAxnrYSGuM2ltW8hrvLTND9yWaKjyuoE qJ97SxlDD4zi11LWR5WI/+MwmJb79iUv9j+7R1Jo3nA8+r2tbb2H1NJqKozETfwaIqae ylxQ== X-Forwarded-Encrypted: i=1; AJvYcCWttaZ2LMD50bjsfZjXtvOefofCwLFEbxC7+nUWp22qgs1RxpHnqJMPF+aajb2R4O3QSSt8wNPjCw==@kvack.org X-Gm-Message-State: AOJu0Yz+m+kr6XvDDMN0ex1Nl1sFery68Ljynylm3sMvACWwz/yO75so mo2ESBQD7Qe1KLrBBPEK53EsvTyMRUzXzEO4UFs+9TG7jBeObk2x X-Gm-Gg: ASbGncuamQ95CWgk+AaJc7z8y1oXTqj4pxnWcUXRfxdK/ok+zgkzhNvSyV/zio0bvX9 a0XIBJ7m/2ggzumG0gBlAAXigN33TqIu6eBy167s+fFW1GPCA/XAHkqjVUuuERTZUilJUbBEzx6 y9T35tggyjUhySKJkCoWr6jI+7RbvDB6eZ+WzlhULhnqTRXyQNV+/gPRDzoDFulTenp5rwBdEem xBjuy9nn3ksXZUwkEoLkhZlX/tSH33JhZm2KgKzaCDhD1lvXskchqKddGUIWHu2uYOO2J4LSAIf Lr7Qv3rI/sHVPDJjh9r9Bjo4NA21mGE4/iEhZTqrCGBOQY+vDvJzTw== X-Google-Smtp-Source: AGHT+IEbiT0NntEOD+phSpXzHaEDeog5yXd+fKeNamOBs2OoNyYQ2pruZWg7BKcGdm/hSVEfYQUk+A== X-Received: by 2002:a05:6000:1788:b0:385:ef39:6ce9 with SMTP id ffacd0b85a97d-38c5194c69amr5482326f8f.21.1738190806495; Wed, 29 Jan 2025 14:46:46 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438e244f38esm1406115e9.26.2025.01.29.14.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2025 14:46:45 -0800 (PST) Date: Wed, 29 Jan 2025 22:46:44 +0000 From: David Laight To: Vlastimil Babka Cc: Bart Van Assche , Ivan Shapovalov , Andrew Morton , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Pasha Tatashin , David Rientjes , David Hildenbrand , Joel Granados , Sourav Panda , Kaiyang Zhao , Johannes Weiner , Konstantin Khlebnikov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] mm/vmstat: Fix a W=1 clang compiler warning Message-ID: <20250129224644.0f7228db@pumpkin> In-Reply-To: References: <20241212182425.ad1f7894cd0f00b2e34bbaed@linux-foundation.org> <20250122015818.3308696-1-intelfx@intelfx.name> <6a45a521-71a3-4087-9320-b8aeecea205a@acm.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: s1w3nrp3r963366zewa6ue9mhp9g4w73 X-Rspam-User: X-Rspamd-Queue-Id: B250C4000E X-Rspamd-Server: rspam03 X-HE-Tag: 1738190809-138751 X-HE-Meta: U2FsdGVkX19oArDi31DOg/VZPsI2zizy4c95/a5mC21PYeOnu5X2f7NB3V3tzf3PdeG54CY9zWv94JwnY7ZrwvYSInrtdJAIH7iNhmm8CUHkUai92MwAmvzRPoRF+qx7sagk2/BrGOF79xsnSu22hu8qJxN+0tBdp/VmbwAR1a561N52kQoKo8v8bMWWgpyErOybB5m8xPc3wUozBGBBNp0ZDo7cx0+uLcikNCft/5h388QqE9FL0Ad+w3mW54YBMorLjzElrgsaNz8Y+4eNUi7VZZ9WC+JakALSFI1trNuGEfFtfep//n0NZt87G29O6lb7D5HGVlsN1Vbpcf/xjc8ZeQxgeMFKm4aZZAN2IsYKfA8eNCJ3mh6l5FKhZpXWq5zfhSOL46q3E1vfxGgOUpONXZ5HHQSIuN1hdv86+9Qzl8wrg2CWpA3S+f0TqobzLR3h6B8TBg9+eu4U8BVxMV4jkBWAySmyBbQklZ8dCTGJk6bcprzAts9k0BdloKWSb3xi3CwmWAWDWywrDXdmHls4il/j5+D3qgrJW0ddj5YVCzioOmprRA1gHg7K0gTO5Srk3xwVsHa7s8k2P9uxoN2dEAhSV0ae2+2/FO8n9tb8YCFoNPX7Cd9Tzx+c0OR5FYDBWMElheaGrr1nB2lnLKdX3EyL/R5VQ+agYIhcVRerMJI+8U7T4O+jtPRmIld2gGq3pEyaIwgaLaP1/n4tDdrvhhfxkwS2Lgi+YkDQ7jmjqoCj0t0XEHWi4Mx3SesZZIv4WgXD8PJXq8O1kLuWYDS9L4XreCvQL0qVkMhCrLMgZDv8Yyipd0I8Vz/nx0vrWEkq05c/PmiFpIEfNrgi8N2LiTzpOg56pkZts4afD4JS/WNksM6i02tjbml4E4YgcNLPcYyDhy8N2t0zkEoaFc70VjEqh8WW97tII5c+Qi80fmh8Fxi4tP9Ntg135/QxVtkW6MJqj4H+gaGt3z6 qXpeGMGZ OLz3gKf93erbVvS/xLZVcNV2Rr952epFzGbVKboeXpgXLtY99kEK9iRH4VBbxmdU/KbQfCvKR3N/FPq7VcyfHyNX6t3/OuiDaj8WwYx5z4CZ8JZWnMoq6sZUnumH3/SYQgVPYhKDdZST9bzfqzua4moDgBhg7lHaIHUSuZ3U3enq/lsvZCg/+64L1RlXHSy3vouh9BGRpzOpGox3psNROjgkghqfuQn69v8wTIYXmrY4LrpEl+i2eZDh8IeAfNZckdZIKdzLYafkA3fr+VMsXdzkFfVWWvWDSItTysTdPQhbl4rMnf17UrdBD9c+X62QPHg+ZM6UK+kaX8YN2NqwJNIhtMyIluazebwbT4yLMKJilpTjwSUZm70teDxgNG112hyfKlcINkutabODP9KjTxzgYN4ExnJ+AAMYX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 29 Jan 2025 11:22:00 +0100 Vlastimil Babka wrote: > On 1/28/25 22:36, Bart Van Assche wrote: > > On 1/21/25 5:57 PM, Ivan Shapovalov wrote: > >>> Spose so. One always suspects that adding a typecast is a sign that we > >>> screwed things up somehow. The relationship between enums lru_list and > >>> node_stat_item is foggy, and I'm unsure whether this is the place to > >>> make the transition it. Perhaps lru_list_name() should take an > >>> `unsigned int' arg instead. > >> > >> All of these *_name() functions do seem to expect arguments in range of > >> the corresponding enums, so perhaps keep those args typed as a form of > >> self-documenting code, and do this instead? > > > > If nobody objects I will submit this patch for review after the merge > > window has closed: > > > > Subject: [PATCH] mm/vmstat: Fix W=1 clang compiler warnings > > > > Commit 30c2de0a267c ("mm/vmstat: fix a W=1 clang compiler warning") > > suppresses some but not all compiler warnings that are reported by clang > > when building with W=1 about NR_LRU_BASE and NR_ZONE_LRU_BASE. Hence > > revert commit 30c2de0a267c and instead make NR_LRU_BASE and > > NR_ZONE_LRU_BASE integer constants instead of enumeration constants. > > > > Cc: Ivan Shapovalov > > Signed-off-by: Bart Van Assche > > --- > > include/linux/mmzone.h | 22 +++++++++++++++++++--- > > include/linux/vmstat.h | 9 +++++++-- > > 2 files changed, 26 insertions(+), 5 deletions(-) > > > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > > index 9540b41894da..92ed919ea99d 100644 > > --- a/include/linux/mmzone.h > > +++ b/include/linux/mmzone.h > > @@ -135,10 +135,19 @@ enum numa_stat_item { > > #define NR_VM_NUMA_EVENT_ITEMS 0 > > #endif > > > > +/* > > + * NR_ZONE_LRU_BASE and NR_VM_ZONE_STAT_ITEMS are often added to > > enumeration > > + * constants of another type than enum_zone_stat_item. Define these > > constants > > + * as an integer instead of enum node_stat_item to prevent that the > > compiler > > + * warns about enumeration type mismatches when these constants are used. > > + */ > > +#define NR_ZONE_LRU_BASE (1 * __NR_ZONE_LRU_BASE) > > +#define NR_VM_ZONE_STAT_ITEMS (1 * __NR_VM_ZONE_STAT_ITEMS) > > Seems an acceptable approach, dunno if this multiply by one is any better > than casting to int? I'd probably use (enum_value + 0) rather than a multiply. And, if you are going to use multiply, I think it should be (value * 1) for the same reason that 'if (1 == x)' horrible. David