From: Frank van der Linden <fvdl@google.com>
To: akpm@linux-foundation.org, muchun.song@linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: yuzhao@google.com, usamaarif642@gmail.com,
joao.m.martins@oracle.com, roman.gushchin@linux.dev,
Frank van der Linden <fvdl@google.com>
Subject: [PATCH v2 17/28] mm/hugetlb: move huge_boot_pages list init to hugetlb_bootmem_alloc
Date: Wed, 29 Jan 2025 22:41:46 +0000 [thread overview]
Message-ID: <20250129224157.2046079-18-fvdl@google.com> (raw)
In-Reply-To: <20250129224157.2046079-1-fvdl@google.com>
Instead of initializing the per-node hugetlb bootmem pages list
from the alloc function, we can now do it in a somewhat cleaner
way, since there is an explicit hugetlb_bootmem_alloc function.
Initialize the lists there.
Signed-off-by: Frank van der Linden <fvdl@google.com>
---
mm/hugetlb.c | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 0a27659d9290..7879e772c0d9 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -3579,7 +3579,6 @@ static unsigned long __init hugetlb_pages_alloc_boot(struct hstate *h)
static void __init hugetlb_hstate_alloc_pages(struct hstate *h)
{
unsigned long allocated;
- static bool initialized __initdata;
/* skip gigantic hugepages allocation if hugetlb_cma enabled */
if (hstate_is_gigantic(h) && hugetlb_cma_size) {
@@ -3587,17 +3586,6 @@ static void __init hugetlb_hstate_alloc_pages(struct hstate *h)
return;
}
- /* hugetlb_hstate_alloc_pages will be called many times, initialize huge_boot_pages once */
- if (!initialized) {
- int i = 0;
-
- for (i = 0; i < MAX_NUMNODES; i++)
- INIT_LIST_HEAD(&huge_boot_pages[i]);
- h->next_nid_to_alloc = first_online_node;
- h->next_nid_to_free = first_online_node;
- initialized = true;
- }
-
/* do node specific alloc */
if (hugetlb_hstate_alloc_pages_specific_nodes(h))
return;
@@ -4921,13 +4909,20 @@ bool __init hugetlb_bootmem_allocated(void)
void __init hugetlb_bootmem_alloc(void)
{
struct hstate *h;
+ int i;
if (__hugetlb_bootmem_allocated)
return;
+ for (i = 0; i < MAX_NUMNODES; i++)
+ INIT_LIST_HEAD(&huge_boot_pages[i]);
+
hugetlb_parse_params();
for_each_hstate(h) {
+ h->next_nid_to_alloc = first_online_node;
+ h->next_nid_to_free = first_online_node;
+
if (hstate_is_gigantic(h))
hugetlb_hstate_alloc_pages(h);
}
--
2.48.1.262.g85cc9f2d1e-goog
next prev parent reply other threads:[~2025-01-29 22:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 22:41 [PATCH v2 00/28] hugetlb/CMA improvements for large systems Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 01/28] mm/cma: export total and free number of pages for CMA areas Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 02/28] mm, cma: support multiple contiguous ranges, if requested Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 03/28] mm/cma: introduce cma_intersects function Frank van der Linden
2025-02-13 10:11 ` Alexander Gordeev
2025-01-29 22:41 ` [PATCH v2 04/28] mm, hugetlb: use cma_declare_contiguous_multi Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 05/28] mm/hugetlb: fix round-robin bootmem allocation Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 06/28] mm/hugetlb: remove redundant __ClearPageReserved Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 07/28] mm/hugetlb: use online nodes for bootmem allocation Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 08/28] mm/hugetlb: convert cmdline parameters from setup to early Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 09/28] x86/mm: make register_page_bootmem_memmap handle PTE mappings Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 10/28] mm/bootmem_info: export register_page_bootmem_memmap Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 11/28] mm/sparse: allow for alternate vmemmap section init at boot Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 12/28] mm/hugetlb: set migratetype for bootmem folios Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 13/28] mm: define __init_reserved_page_zone function Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 14/28] mm/hugetlb: check bootmem pages for zone intersections Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 15/28] mm/sparse: add vmemmap_*_hvo functions Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 16/28] mm/hugetlb: deal with multiple calls to hugetlb_bootmem_alloc Frank van der Linden
2025-01-29 22:41 ` Frank van der Linden [this message]
2025-01-29 22:41 ` [PATCH v2 18/28] mm/hugetlb: add pre-HVO framework Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 19/28] mm/hugetlb_vmemmap: fix hugetlb_vmemmap_restore_folios definition Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 20/28] mm/hugetlb: do pre-HVO for bootmem allocated pages Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 21/28] x86/setup: call hugetlb_bootmem_alloc early Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 22/28] x86/mm: set ARCH_WANT_SPARSEMEM_VMEMMAP_PREINIT Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 23/28] mm/cma: simplify zone intersection check Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 24/28] mm/cma: introduce a cma validate function Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 25/28] mm/cma: introduce interface for early reservations Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 26/28] mm/hugetlb: add hugetlb_cma_only cmdline option Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 27/28] mm/hugetlb: enable bootmem allocation from CMA areas Frank van der Linden
2025-01-29 22:41 ` [PATCH v2 28/28] mm/hugetlb: move hugetlb CMA code in to its own file Frank van der Linden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250129224157.2046079-18-fvdl@google.com \
--to=fvdl@google.com \
--cc=akpm@linux-foundation.org \
--cc=joao.m.martins@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=usamaarif642@gmail.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox