From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B0ECC0218D for ; Wed, 29 Jan 2025 21:09:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98CBD280087; Wed, 29 Jan 2025 16:09:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93D1F280085; Wed, 29 Jan 2025 16:09:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82B91280087; Wed, 29 Jan 2025 16:09:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 64E16280085 for ; Wed, 29 Jan 2025 16:09:30 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D6D391A03EA for ; Wed, 29 Jan 2025 21:09:29 +0000 (UTC) X-FDA: 83061730458.18.5E0A641 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 42A9C4000E for ; Wed, 29 Jan 2025 21:09:28 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HPVd0D0Y; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738184968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kOCA+ndg4/uhMTpfButby57pR3H3CxV9c0caGzDn+Ok=; b=P8WMdfsh/ebZCh/dgduYYoAO49ZcN/1yXieAe4tGdC5vl12z0L8bpLjDOV3PZHbZgHxkKf L4owIo9My8nNQQFeJ2/FCH5qSc1ttw8HeOn8sBf8nI6cNzJ6oZvpPcjKwiDFK86f6SBHSd SKTB3nsWSEwCNgHMU9OXWlkoUpah7Dc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738184968; a=rsa-sha256; cv=none; b=KphvSQ/IeSWfdokR+vUK5WngYutS9k0+cBbX1DcH/O7D9w4rDw091lvfjBDhfMCnh+Pyb1 xW51EVjZc07JghD/UksbZrCaYRgG+LXQoJ0NjNhxV64xHYP4B9pTZmqWFw06F6ulfUb4v7 BICFTfLsYbENZaQ2G3J1uFByAGJcHsg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HPVd0D0Y; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 188055C5EA8; Wed, 29 Jan 2025 21:08:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F249C4CED1; Wed, 29 Jan 2025 21:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738184966; bh=TQTIBWYLRPxqyD893pnd2s42NyRI4UfYRTS8Gad1wik=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HPVd0D0Y4Wtuu39XDsPx0nToqlQkIbkBr72RYBBhQpVeRC/FWIEmmfwjPRmVNHskt 9ayUJDkvHMfeuj2yV+ni1jgOhmZ71FP7RdDNicPw9OHSp42WEeE9dNZKQNc+WEQBD1 8Gx76rKSYP0XraqB5W+ezbPLPm9YdK3PC09S2Rca74K/foXOLbCLvNzHfGJTDM23dh C1LY+1tS/nACMRSG7hnGcs50kgruXMbNc/A13ANWRLdGgJ7MOe3YGsnoG8xSCpYIV1 //CpSWpsLKoMVcn02/E6cKP1cLqBJlNBSioidFcF7IuPFC/W7zfAAdbYKpVBCw0z+P m0tFP9sfYV4BQ== From: SeongJae Park To: Shakeel Butt Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v2 0/4] mm/madvise: remove redundant mmap_lock operations from process_madvise() Date: Wed, 29 Jan 2025 13:09:23 -0800 Message-Id: <20250129210923.1861-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: xpdrpadhxxoonozoqsq9rzuf8nu1ir8d X-Rspam-User: X-Rspamd-Queue-Id: 42A9C4000E X-Rspamd-Server: rspam03 X-HE-Tag: 1738184968-837601 X-HE-Meta: U2FsdGVkX1+Ipm+hcPnFnnAZ8JVa0AupQYmkz5203lzO6AaWeqoNG/IYpqQIxH+ihpJ3wQj39ioaPcDsC1EXvKs03ziB029SZO91bMzO6+fXIWalgWJ53JNWHmCIb4Y8YvZEEO2T6gn750G4gKl/Bujn5ebhJyhR9u/gDOkErVgLps3g06FZrMcfNHpI3GeH0KX1YEz4roFGqEXtKwQ1lX0mLDiLv8vHDac1wYZoAGV1Jegce0L7gsNDufmdcmmPsq8R8v7G6UDA1ImbHglWD1RmoEKeEuOjMrj3XRCXn66j+akvDfWMfVOZvyGb/tcvHRra1iF9+vVknEqsPe3rpeMp9Gw6t9QROOB3dWqq0fsHHJXfMuhN3pajz5JvA3xP4padOTnSF06yon+XPB5iFTr1U6ckyRMglim+KG5PVoHDuh2Q+q7n/+7rvufi3OF/g5R6MPwIBhB3Wq0rsUXsQ9fNGGPG1w7bpa8vq9BsrAuSwHeKDH6AXJxzw1paMppLJRulSvn8+SWEhuU3Gjfx7GksE6Dvfu6a4SXOlcFkjiCjen8asCLJs8qnvPjbRSTIWjsBBMF+lha9E1cQLn9LDFxl0otvApeCjFd1RftqMN9tep9Vom+LYm90Kn/jZcQG6yenTVHHGIF+psKriYXt2FcV3B8gbCGNTsupLgDAAYgwJKRiuGaF2BxlpkPYexF9KgiaXpinnyjJyKUe6JRkqLLT0zMeOoa7i/DNAwEwSzNxtTuRZz2pMZi+Yb/mOFmCWO78tisZKo/ZvS9KfDF/IBU45wwhqeTtRiQLgbeq6rbhBmh+TlzAitwVJh7/8PFKpVNMUJUrzjtCqfkA+Ftg8ts3fkxsy6EqdB2zKWbFkTTy+g4UAY9NFL+kpOl3SRj9DdS2kW0GxQnyy6bP7PcxlsO6Jv+n2VlbjhDNifCZvVCTMhaoL+nYtByMXTtvsgNc62OAebd0vMaeJek5R45 CcVfWpjx suxGje1DanexxKYp243SxGf7+gtv3E3nmRwZSwY5cTUIGTDs3TVR6kaJJ5drcl7qe41KvzZiaGpQzv3zQZjDlmXRR7rmMfOBNQjCDdOURrROiI6WjrlXOKM2hF9T+2yI5ocX6+s0FFGRPUc1apIfsmblHsC7cudsaVPSwKP9AcxFdgDnTHl0ldifHTSV3J0Ief1SMHTOkOVLGnhMaPpp+Z52NJrXffKXhMmBWuZbUu3Ff+Wtf1i54unugR0WGr7ccXCSfB2oZNBZG750W2OfrpMkvdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Shakeel, On Wed, 29 Jan 2025 11:22:29 -0800 Shakeel Butt wrote: > On Thu, Jan 16, 2025 at 05:30:54PM -0800, SeongJae Park wrote: > > process_madvise() calls do_madvise() for each address range. Then, each > > do_madvise() invocation holds and releases same mmap_lock. Optimize the > > redundant lock operations by splitting do_madvise() internal logics > > including the mmap_lock operations, and calling the small logics > > directly from process_madvise() in a sequence that removes the redundant > > locking. > > > > You skipped the evaluation section which was present in the v1. If you > decide to post a new version, please include that otherwise we can ask > Andrew to pickup the evaluation section from the v1 [1]. > > [1] https://lore.kernel.org/all/20250111004618.1566-1-sj@kernel.org/ Sure. I will run the evaluation again on the new version and include the result on the next version. Also, thank you very much for reviews :) Thanks, SJ