From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2DC8C0218A for ; Tue, 28 Jan 2025 10:15:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C15A280223; Tue, 28 Jan 2025 05:15:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5722C280222; Tue, 28 Jan 2025 05:15:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 439AD280223; Tue, 28 Jan 2025 05:15:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 24268280222 for ; Tue, 28 Jan 2025 05:15:48 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A93EE120FF3 for ; Tue, 28 Jan 2025 10:14:52 +0000 (UTC) X-FDA: 83056452024.15.1396EEB Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf14.hostedemail.com (Postfix) with ESMTP id 5E8E0100015 for ; Tue, 28 Jan 2025 10:14:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=pisH4tvc; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf14.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738059290; a=rsa-sha256; cv=none; b=CeHSW6aC+3kTPQ9e/yDvGFqgsyyjyNTuKfZU/hLglEuluiZ8ckrx2zqqZ9u7iqcTwjEPTe L8sGG3uioNofJLykxQEA1jMpvAJjarJ6H8kn+RlCjqUx5Xsv6wkbm+f03ciG0CGUCCPwUs OAERih10IwDb1lCjj6kFasj9Nggktuc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=pisH4tvc; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf14.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738059290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T+OJo5OrtdbsUfbDREZKvi2Xm/rwCKQG5dGU4viVWio=; b=eXCV1F20GPad/b8uuBgq753nrZ8+5VSIPJFgHZrhVMzB/TWhCmbTilGSYy7xT2W1ExgWyr ru8QA8wj5nUw1RD87/t6a1y62Rd1hWXHzhs8qXmOtDeHRxuMXTbmkHih7wPxf2befUIYJB 9BkTghn7q7x432L/jBe1zzmCa0a1SoA= Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-467918c360aso59862501cf.0 for ; Tue, 28 Jan 2025 02:14:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1738059289; x=1738664089; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T+OJo5OrtdbsUfbDREZKvi2Xm/rwCKQG5dGU4viVWio=; b=pisH4tvcEZAnSNt8R45k5LedyP6cR7CGscoBheYjMNO/Npp+lMLP/q0zU+d8QFIa7/ 9OpnSVLYVSL9HIXUAX7I+UKnKMUWcjllan0dXYPiQQl8o3ovA2Y7PR9XIA/5HfhzRPvC I7AJQArpnQYxz01LSxTHZNPWP6pmmFktEBrtkOomQal5VWCvXSNgDX+asOO19NHBjoeK 7PWECXOy2f3Zglisw23Kr4SmyPTSbyIGq1SzRATNghJWeX9fDlbZ2KzvV9+7rVxplKQg PLJf3OXGK8h1FGFBP2epBULn30WZEwJLdgBIFjC7bbpRt1M20XdmkOw57IjjwVWuQoJQ 6sxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738059289; x=1738664089; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T+OJo5OrtdbsUfbDREZKvi2Xm/rwCKQG5dGU4viVWio=; b=PRQ+SqPTHrjAQXyahkqX/CqXtVcRmPBv9nrCtGq6/nuXwJ1Qb/QsA9hbNEhJo+711R +bQ0YD3ihcMHdGLYr+hwbv6ENofUXXlAHpxBovR9N8H7uQ4ymPJoXS7G/1l9mBu347fA vZAr8qEro2w+UUQx5RFY1waZv9Q1hu0yOzc4EolwdEPnM6BANFJhyRk/eLBsbQBSMrDU Xm36REx8CUMyYPMTuZav3AmVEDBkixpVg++aS3WM8ijEph+iCCwVTNcu2uDVSPFpVreT 4lsPc8WOr3zux6cNCNPVpvwa4czP7dGGNwl7IcyRyglDMVZ+c/zq/vX2P5R2YbiQpek4 EnMg== X-Forwarded-Encrypted: i=1; AJvYcCU9QrbIwnAU5u++x95blqjjKVsWbXcqHZpBaLFOr9cK1gJCjO6IUk1q2EGxTS4KUGx8N1TSZw97yw==@kvack.org X-Gm-Message-State: AOJu0YwwuEIkSi8S/2qCha/iPdap7zmpNB/vmnRHngm6uA6CrA0VwDgy nNWsqqW1ESvvPOSGilxI6nc9QkWgBlGgEUZ4v6hjT96maaSaD+Njj1p4uE9Q0Zk= X-Gm-Gg: ASbGncvKvGkOYEWtfhDTCjumGRENyo5mvFd2PTxnenKfAnHION2xETI+qwNf2+7GC8y vbGCFL9jmM/+lX83PKRAwYqMC25SuTyn/Z090cHe+Kdam0REJ51gp3LB4NNWg6RA4GxFYSRpqGl kYwf66GmEQE0StXy4wiF/Z0Y16dACbknT00ru2/FqvtkrJ8/17y/K+LGK+N5OJe9DtKVB1cCIUo uouM6zpZCE/9e5qIdBSCmN/oOpUQrfBy4YzavrBzdkMPc/Z6nPk5/di3yzCW/p9/3E8kGI9Ts/U VJnYjL7oMSqmeA== X-Google-Smtp-Source: AGHT+IFALe6WVLHYMuH9iT72w4NXQewmaC4+fVCySImFG7ZmNiWWkYcz7G2f61JtCoHmT0Mt8hGVxQ== X-Received: by 2002:a05:622a:52:b0:467:6cce:44ba with SMTP id d75a77b69052e-46e12b96babmr592982961cf.43.1738059287990; Tue, 28 Jan 2025 02:14:47 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-46e6689dab7sm50327711cf.44.2025.01.28.02.14.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 02:14:47 -0800 (PST) Date: Tue, 28 Jan 2025 05:14:42 -0500 From: Johannes Weiner To: Yosry Ahmed Cc: Andrew Morton , Vitaly Wool , Miaohe Lin , Nhat Pham , Chengming Zhou , Huacai Chen , WANG Xuerui , linux-mm@kvack.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev Subject: Re: [PATCH 1/2] mm: zbud: deprecate CONFIG_ZBUD Message-ID: <20250128101442.GB691108@cmpxchg.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5E8E0100015 X-Stat-Signature: yw4zd33zjb7433f6wecict9bppyn1nm5 X-HE-Tag: 1738059290-643904 X-HE-Meta: U2FsdGVkX18FY+nPKwXWMd+/urElpqJSgAKGYdURtVlrSCWd9NRT9FEiibLqiYqzHdY5amqIc6Hid3aSB49XNYQUjzDqbAXIUNUlQFwyrgF2KrTosjjpm6i/rm9h6qGH68lgiM1uZ/+WBEMkACV6ijfffm3v/8x+5VkKV54PyeAKjKeHjJ9LTnLf1ae/uffdRw775LdZ7YVb3RCMMC2k2yEyQcFDlXbiSJViXS9yn43jD7Xo8h9419uRE53AiKZnZE7oWRHI6CG8j137M4nhxzfA1iGUNXXs5KarIwQJ2xjBcxKDCBgIUkFaPAODR5kZMYUaJiyVgrn94GEnq+Gc7DxmQxRahlgUpBlHc0Hxl/JN647368EhlO5F1KqJcvZmSxI681nb8Nlyk9aLU7DjLX72hy7t/IA8qNMA/LxVZfdC7QoEpzfZ3G0/H4qxe5jeYUFhty2KxGLi7wJ8jTa12OURGYU10dQiyldvJGG6sJ6cSK5Jmtq1KqjggqAjrtGJIofOnRcN51wqov8krBUqoi2yYWbD/RcTv7yA1bV4sDgpvQEiF3t4YQ2yKrNgMXDA81NY0eO07TQHJO5gEmhcyWpoiCZgGg+xDThO5cD5vxo51EoFGeZ+y0FUeIPDO2wYTWrElAFejOEfNlawx8xeu8scn5DUaFEaMRJc6bAG7T/AhBbHe4xsqypIbQ/MQ+bqrvaoeBVTYwQJf8mQSYVDyIfmppN3oI1HGcPeV+79clKAoXWNASpAEvIltPuPjWutUHsnVxVS7k582QmxCys0QFgM+v8km+E5rmZZZD9s8oRxvGKv+bPMyoGXKePHm4fMmB3K+L3Q7I4yANIeiRqqescqCrZ8iEsH5h/SbFoIFUqBSN7NojdlSvIFynaiYfhAlg55Wp9nQR253rPCO+UKqzV+e71v4loKLACZJCJ3yxysTuC5jtC1jxodg++MbUGYdAIirx2ApGO3ReS5WZr 2bE70cuD YD+bhT4FH7d1DMjA4h9VfWlUDLRkTsDVmmM17MschGU7us3KxZeidXzXF5Gfze8fy/IYHHK+uhPB7H0Pjqpet+oYhpUn0LPXXZMqdCtYhA1YyFxzHaqXDs9gtkGjYfRPoJornjNdTbjQuUOHwOg5ZAOSh4Rz7iSirFIKjSTDxZXE8TuicH5kHuol3GgiBaow7uepD/j0tyb0tohU/D4hxqmGrH/eEU2RrowISv/ubG9fwFf4BkbzSSZ+atR0WGRB9NmqGviU6+dh7WthuuCAdRp0xsJ9Q33qYMQlJaApCGBMqMEfA10iON+hDnytiT9UXbSrFVV2/2sgV4VhQWG+wy9Yudstp3GMlBsyyeBhxkY12VuCEY85mUIitYDs2s03zOa91LQ7gCcI6rZ8k2ELhxysSB8WQM32EQuekUkozasSkhJ06U27RJQgR9E50IdGZL/atrScY6HN9OTAavNGWSTYgWRaDfYNqaHPu7FhtOt2hbTxdiXJT4axKa+N9tF8xPum0fOH9ooe4iHVevemTeQQKBDVq+fWk/cpRhOLIJ1nkMEMZXOveEUbG5gI9ZIUILcTJz+3D/PaPbD0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 27, 2025 at 11:58:21PM +0000, Yosry Ahmed wrote: > The zbud compressed pages allocator is rarely used, most users use > zsmalloc. zbud consumes much more memory (only stores 1 or 2 compressed > pages per physical page). The only advantage of zbud is a marginal > performance improvement that by no means justify the memory overhead. > > Historically, zsmalloc had significantly worse latency than zbud and > z3fold but offered better memory savings. This is no longer the case as > shown by a simple recent analysis [1]. In a kernel build test on tmpfs > in a limited cgroup, zbud 2-3% less time than zsmalloc, but at the cost > of using ~32% more memory (1.5G vs 1.13G). The tradeoff does not make > sense for zbud in any practical scenario. > > The only alleged advantage of zbud is not having the dependency on > CONFIG_MMU, but CONFIG_SWAP already depends on CONFIG_MMU anyway, and > zbud is only used by zswap. > > Following in the footsteps of [2], which deprecated z3fold, deprecated > zbud as planned and remove it in a few cycles if no objections are > raised from active users. > > Rename the user-visible config options so that users with CONFIG_ZBUD=y > get a new prompt with explanation during make oldconfig. Also, remove > CONFIG_ZBUD from defconfig. > > [1]https://lore.kernel.org/lkml/CAJD7tkbRF6od-2x_L8-A1QL3=2Ww13sCj4S3i4bNndqF+3+_Vg@mail.gmail.com/ > [2]https://lore.kernel.org/lkml/20240904233343.933462-1-yosryahmed@google.com/ > > Signed-off-by: Yosry Ahmed Can we just drop it right away? The two cycles for z3fold were basically in the "not worth bothering" category, since very few downstream production systems rebase that frequently. zsmalloc has been in use on everything from mobile devices to large servers for years. It's been the default since 6.6 (Oct '23) for zswap, and the only option for zram from the start.