From: sooraj <sooraj20636@gmail.com>
To: linux-mm@kvack.org
Cc: sooraj <sooraj20636@gmail.com>
Subject: [PATCH] mm/nommu: Fix NULL mm dereference in __vmalloc_user_flags
Date: Tue, 28 Jan 2025 02:22:52 -0500 [thread overview]
Message-ID: <20250128072252.10259-1-sooraj20636@gmail.com> (raw)
Problem:
The __vmalloc_user_flags() function attempts to acquire mmap_lock
via current->mm without checking if the mm context exists. This causes
a NULL pointer dereference when called from kernel threads (where
current->mm == NULL), such as during filesystem operations.
Fix:
Add a NULL check for current->mm before attempting mmap_lock operations.
Kernel threads don't have user memory mappings, so VM_USERMAP flag
setting can be safely skipped in this context.
Signed-off-by: sooraj <sooraj20636@gmail.com>
---
mm/nommu.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/mm/nommu.c b/mm/nommu.c
index baa79abdaf03..df13c1c78d5b 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -152,6 +152,11 @@ static void *__vmalloc_user_flags(unsigned long size, gfp_t flags)
ret = __vmalloc(size, flags);
if (ret) {
struct vm_area_struct *vma;
+ struct mm_struct *mm = current->mm;
+
+ if(!mm){
+ goto out;
+ }
mmap_write_lock(current->mm);
vma = find_vma(current->mm, (unsigned long)ret);
@@ -160,6 +165,7 @@ static void *__vmalloc_user_flags(unsigned long size, gfp_t flags)
mmap_write_unlock(current->mm);
}
+ out:
return ret;
}
--
2.45.2
next reply other threads:[~2025-01-27 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 7:22 sooraj [this message]
2025-01-27 22:42 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250128072252.10259-1-sooraj20636@gmail.com \
--to=sooraj20636@gmail.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox