From: sooraj <sooraj20636@gmail.com>
To: linux-mm@kvack.org
Cc: sooraj <sooraj20636@gmail.com>
Subject: [PATCH] mm/hmm: Prevent infinite loop in hmm_range_fault during EBUSY retries
Date: Tue, 28 Jan 2025 01:34:22 -0500 [thread overview]
Message-ID: <20250128063422.7604-1-sooraj20636@gmail.com> (raw)
When hmm_vma_walk_test() skips a VMA (e.g., unsupported VM_IO/PFNMAP range),
it must update hmm_vma_walk->last to the end of the skipped VMA. Failing to
do so causes hmm_range_fault() to restart from the same address during
-EBUSY retries, reprocessing the skipped VMA indefinitely. This results in
an infinite loop if the VMA remains non-processable.
Update hmm_vma_walk->last to the VMA's end address in hmm_vma_walk_test()
when skipping the range. This ensures subsequent iterations resume correctly
after the skipped VMA, preventing infinite retry loops.
Signed-off-by: sooraj <sooraj20636@gmail.com>
---
mm/hmm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/hmm.c b/mm/hmm.c
index 7e0229ae4a5a..29e3678fede5 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -547,6 +547,8 @@ static int hmm_vma_walk_test(unsigned long start, unsigned long end,
hmm_pfns_fill(start, end, range, HMM_PFN_ERROR);
+ /* Update last to the end of the skipped VMA to prevent reprocessing */
+ hmm_vma_walk->last = end;
/* Skip this vma and continue processing the next vma. */
return 1;
}
--
2.45.2
next reply other threads:[~2025-01-27 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 6:34 sooraj [this message]
2025-01-28 1:00 ` Andrew Morton
2025-01-28 1:16 ` Alistair Popple
2025-01-28 18:04 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250128063422.7604-1-sooraj20636@gmail.com \
--to=sooraj20636@gmail.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox