From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1D2C02188 for ; Tue, 28 Jan 2025 02:00:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDBC62801FA; Mon, 27 Jan 2025 21:00:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B8A792801F2; Mon, 27 Jan 2025 21:00:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2A722801FA; Mon, 27 Jan 2025 21:00:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 850CD2801F2 for ; Mon, 27 Jan 2025 21:00:15 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F095C160A80 for ; Tue, 28 Jan 2025 02:00:14 +0000 (UTC) X-FDA: 83055205548.22.E824389 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf01.hostedemail.com (Postfix) with ESMTP id F3E8E40008 for ; Tue, 28 Jan 2025 02:00:12 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NoA6i3OD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738029613; a=rsa-sha256; cv=none; b=5qo2WKf2UK4NBmTzQlxw6sKWvljLo6e1hFSFmFmQkI/CA++bcnCDAMqwYFbw3i1Lypw3HV 7+9DFbwrEsODpk/a7WW6SNDzqyMZXsivbk7hQc3WDIYRHzm/KLbRPEORNDDCMvKIxnFf0V OEdrCuJKa6YpV5jrygd9wuLmINNx2eE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NoA6i3OD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738029613; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UFkcVRcv33UuGXp1WIGgvQq7NAyeF9TfzmWIio+s6Ks=; b=RrNC0SOTMExYR/CnPbga2nK+7i3rAffGlTGuEHThO2rO5hJSLUUQiNgylvhzUskYFbhmHv 1lXfiVI89jKKh2bxoV+FV85nc7q/fGCyTB9NJqpuuYYqWm+o5b81mOOpkpIjkOe19zg5oC tJ7SANRPuge5m5UB+ASTSpWLZ5Tqx9c= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5dc149e14fcso7783649a12.2 for ; Mon, 27 Jan 2025 18:00:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738029611; x=1738634411; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=UFkcVRcv33UuGXp1WIGgvQq7NAyeF9TfzmWIio+s6Ks=; b=NoA6i3ODl6ZlIg7lgKjgBAJOkU24S0KD1wdQXCbTCEQujoIR30CGgpCr2VUGKImgkP xu7wJ5PnbRGZIWDAxZS8+o1NkL6217YncfzP6SNYWOirNBiPSf48RGLtDVMVmwC1P8yx wSGQIxP2bowfh5WeDV56vBMELNJzgJ5wHWuiB/VrzOmnRdKC7zc76CgsVpIIqljn1WI2 xEjhJif1onawQ2b1gm7NYbvHguusp0UO1u0WSS0zXNznwHgx0Ee5Vq0N4/1vhMOtlJUf iflCjLTARpBaeO/aAq93ufHJj5CFRmnvPXmY18jqATJLoQUGQ2G0Gls753a4IiRf+Dc0 PCDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738029611; x=1738634411; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UFkcVRcv33UuGXp1WIGgvQq7NAyeF9TfzmWIio+s6Ks=; b=cXfJBO6/AtLLwinarI6XzLKpXsOj8d4eauHEIE291yjU3SbmoYs1b6MvAJ5uit6o92 0WKK/Q0e6/OlI+7WNHlzDAe07mvt7eN/twOrnThb/gUHjUuwHVDs1hENqRdeTY+kibsp C7UrbMUgQcif2B35BTigliqrrk82gCMPUJhT4VHaBnxmAMac0ugQE4I/yEkuT3pp078Q kfqM1+w+3P1JsxslMwsEAf6u2VyzIbkqmkFGZViesedCXoTBirYxYBQcCdGyD4PT7DRx j/IjWHLb0Zimyt4FspdE9tz2Pxn71N3u7V+5wDRDVup3KWQi+MGsuxaGKCUT5dI3yL/V 6yDA== X-Forwarded-Encrypted: i=1; AJvYcCVsfeYdhKG7zwem64lUGqpA4PI/rSi/JffDuIjKm4cuZizTnv+b2EnDehQ0xkXLU3xnP+g9GmCk9w==@kvack.org X-Gm-Message-State: AOJu0Yz8PvT+2n2id09puDPUSNZOXbJ0y1sOxaPcVIN/dZXeGRGx8+1v QV66FErTHbUc1aaACrsBKcX+crw9GOPLT1oDtkFVLJKgwGeSpI1C X-Gm-Gg: ASbGncuWWYe7bhSJKoKVyKQAdBEusNJQUbIQq5y0ge4c1/j0OD+dLfk7kBTc5YtITIr 3jGWQs5G3R0GJK4tH9mYJsrs5Jgg9wEM4maP2mh0ouR0Ouj0NMtnT8fH4vPF2us6YAANh53K1TY 4mSzryEpzg++wckUERQKY9Z2M5B2kp2XvSYgeAThBBapQCaxd7v8haZ2GFFrOUcrVZPT2xrKid8 1ft2Ya0nl78fYaWLs692Y8ndopmJp7tvmR15cHNLek9OeB2CcOd+PG+M274PWAG08kyJ9R9cUnT 9Mth X-Google-Smtp-Source: AGHT+IFnHoLOlQNiJ36SfnfFlNv6vbXDzFN3MoH2rMJ32YzZq8G0ca40jX+ZruD7er828W0A6JriXg== X-Received: by 2002:a05:6402:54e:b0:5db:e7eb:1b4a with SMTP id 4fb4d7f45d1cf-5dbe7eb1e11mr19118272a12.10.1738029611250; Mon, 27 Jan 2025 18:00:11 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dc186df3e3sm6240424a12.69.2025.01.27.18.00.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jan 2025 18:00:10 -0800 (PST) Date: Tue, 28 Jan 2025 02:00:08 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH 0/2] vma: fix unmapped_area() Message-ID: <20250128020008.ex772bsfvfyg7x5n@master> Reply-To: Wei Yang References: <20250127075527.16614-1-richard.weiyang@gmail.com> <4xusynvnxd5u6eklrxclwgnwr6tq3jvket7liwwmirsiyrbzi2@dvnzhzg7mwnj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4xusynvnxd5u6eklrxclwgnwr6tq3jvket7liwwmirsiyrbzi2@dvnzhzg7mwnj> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Queue-Id: F3E8E40008 X-Rspamd-Server: rspam10 X-Stat-Signature: yf5dnqq7ddx6rt5e7pg5pogzphrjz61g X-HE-Tag: 1738029612-672713 X-HE-Meta: U2FsdGVkX1+S2CExT8zTMEqIC3/lk4mmLaw/x6DkzeIMtHugqHbUWGfOLV/64mafYiGC2c9MUPsXc2QhCRhlbx2/gxip2bOyAZ2p5ivsusiUxF9EqCcSgmlTVbxFTx/yufZa6DiywyW1eXCIToUO2Tl2Ia1WwbzOZSoQabTB78GsP0gFvUZ1R34gIHtMlj+1VRD5cI88TG4FksTRpPhzHkRh/hS4o0z4M0TX64QUD350g0Y5YTqbPZYqJGRz8y1ofX6XNSGk4XYvmWvYgo/XpnpXwJqf9ZvUOhvqahqFnzuYWNCWuJRTQUOf6oVA/EBPWcwgAoSGsyYfL5qsecDt7a/1yErcJGAfmKaG8Y7I4wH+CQKt7rhxs2DaEX8FedNSdBcl4TCOxlvWkeebV7GHtKxuFuXdl/xuoBEFB2Ottos3XQRm0Mge3p+lOCQrN/HyEp8A2t18+pzu03jMRLVngqPvgg93BHnx/Fom03he0O31AV3GtdyGF+tEMs2C29Pie/+fGQdMV8ZBjSDI7cOb1GWb0zCh97j/LHI4efZFeZPFwjxwWmIYQR1TteUWMMQd3XKAfa4p0S39WtnZIsab8Fwe5zvX5uXScPH3uf/k76OHo/zdeRNdMR/8M0yROOAlbb1hHoIwFi8i/PtwdEION092BwsqSctByPd0tLGHc3p/jpu2f3AOfAJWXs9t/DWZeg1FVWyyFK3zZqQZjgiTo+JjYsm9FuDMzvvXauvcEbikIeDWqjXVZOLWgEIolWd5Tsq6mXMO9/JijWJoGDbxAgFBb3d0HJTbwBr7b1OFDLm5UPal9vuWeC8WNhNFFHqtIA9uiWDMIRgTyu+XyyaB8Jm9Gs8P5GTcwqk9S28LwnHPxsq3Ozzxet4dJpbWf2JdtwP3+63Zd0VPZ7cKe4v2en6IrA9WH1Go47obc9nl9TWPxXA9OL5arHsOqReqxzv4ZCdMfB+r/v8BK50r92p xLGyjkOp lrGWgGlFB7M/bEewOZCFqsa9cFTq0FGzfCd0t7kAMsH1cXEDuNdFgKUSFVFb+SFntILoRLHMqnpuyMuijYSX1bk/4SpLWmUNu5kN9PmKFDEZRSIUTkUhbNWgAXzY+B84NtclRhE/q+GXePtMF+F80Gl6jAuFDaOgI/AgDDo8tXm7q6K2UyVOBmXjRiLB7is55L60h9sD/Gtuifb4JlWEwBvUOJfovZ+tkqngJF2CLt+FBh3O4pQ+U6ulMuJKb70vpwT/MqbsmBeOhRC5RVz/NiWHuWw+gTPOj/cDf3sNAvzMb7JMapQ3WiZaKsDPQir+FAS9jmN6mFdfsY8eqgiYldR9tkpbroVqOOfR5fBcXWXbkOB7S+AcOacnyDg/Bs/GdA0ugEsjbLIhfGA22la3G4Ob19KMP8fS2e84/nrexjWtqhvNrbfXB0s6vquybS5Pzq7HpAdzIFmr9/qL2V8mBAegU8JwK3C+hD1h6NRqD5zIVJYwFO+Y9dfU5pgpOXh5fNg8wz0KLDI/jnrX4bzFQTh1rR89a2j2iKx55a35huPJ/oOBBtm4jCIbn9jMPdsDsFPRd4d/gI0YLryviWhx1SPVnfzBBCEiB6phsQP2k9E0Csses63Sg6IHYcsnFt7bbXHe4JH+9mJUR/96qkGqz7ADnH0V2ZebufLJKXMeHoJsYyGBPBZ8/7HmPzJQ4hTdwlkr58Y1Bs5DwSVqHWGNcLyKxP5cAvTvqouWINJ/+NBXkrcI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.008257, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 27, 2025 at 09:19:24AM -0500, Liam R. Howlett wrote: >* Wei Yang [250127 02:55]: >> The gap check in unmapped_area() seems not correct. >> > >This is not an acceptable cover letter. > >You must have spent a significant amount of time trying to figure it out >and spent about 2 seconds on explaining what you think is going on here. > Sometimes I am not sure what should be put into the cover letter. Will adjust next time. >I'm not convinced there's an issue here at all, and I'm not going to >spend time on it after this cover letter. It seems like you are also >not sure there's a problem. > >If it's important enough to fix then it's important enough to explain >what isn't correct. > >If it's not important enough to explain then don't bother fixing it. > >Thanks, >Liam -- Wei Yang Help you, Help me