From: Wei Yang <richard.weiyang@gmail.com>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, lorenzo.stoakes@oracle.com,
vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org
Subject: Re: [PATCH 0/2] vma: fix unmapped_area()
Date: Tue, 28 Jan 2025 02:00:08 +0000 [thread overview]
Message-ID: <20250128020008.ex772bsfvfyg7x5n@master> (raw)
In-Reply-To: <4xusynvnxd5u6eklrxclwgnwr6tq3jvket7liwwmirsiyrbzi2@dvnzhzg7mwnj>
On Mon, Jan 27, 2025 at 09:19:24AM -0500, Liam R. Howlett wrote:
>* Wei Yang <richard.weiyang@gmail.com> [250127 02:55]:
>> The gap check in unmapped_area() seems not correct.
>>
>
>This is not an acceptable cover letter.
>
>You must have spent a significant amount of time trying to figure it out
>and spent about 2 seconds on explaining what you think is going on here.
>
Sometimes I am not sure what should be put into the cover letter.
Will adjust next time.
>I'm not convinced there's an issue here at all, and I'm not going to
>spend time on it after this cover letter. It seems like you are also
>not sure there's a problem.
>
>If it's important enough to fix then it's important enough to explain
>what isn't correct.
>
>If it's not important enough to explain then don't bother fixing it.
>
>Thanks,
>Liam
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2025-01-28 2:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 7:55 Wei Yang
2025-01-27 7:55 ` [PATCH 1/2] mm/vma: fix gap check for unmapped_area with VM_GROWSDOWN Wei Yang
2025-01-27 12:08 ` Lorenzo Stoakes
2025-01-28 3:30 ` Wei Yang
2025-01-28 6:32 ` Lorenzo Stoakes
2025-01-27 7:55 ` [PATCH 2/2] tools: testing: add unmapped_area() tests Wei Yang
2025-01-27 12:26 ` Lorenzo Stoakes
2025-01-27 10:50 ` [PATCH 0/2] vma: fix unmapped_area() Lorenzo Stoakes
2025-01-28 1:56 ` Wei Yang
2025-01-28 6:38 ` Lorenzo Stoakes
2025-01-27 14:19 ` Liam R. Howlett
2025-01-28 2:00 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250128020008.ex772bsfvfyg7x5n@master \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox