From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DFC6C02188 for ; Tue, 28 Jan 2025 01:56:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56F902801F9; Mon, 27 Jan 2025 20:56:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F8F82801F2; Mon, 27 Jan 2025 20:56:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 371E02801F9; Mon, 27 Jan 2025 20:56:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 101D22801F2 for ; Mon, 27 Jan 2025 20:56:27 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 70B481C7F4B for ; Tue, 28 Jan 2025 01:56:26 +0000 (UTC) X-FDA: 83055195972.29.814C2F4 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf13.hostedemail.com (Postfix) with ESMTP id 68D8720004 for ; Tue, 28 Jan 2025 01:56:24 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KXPWaJN3; spf=pass (imf13.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738029384; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EWU6AwZp8J7ygQsAgOSiEIc6X64AlE6QGqWBqVt2uXY=; b=OByZulS1HHhT3tKi0n7ZopMNtXmK9S7xr/CSVQUQQUprV/lshO/LG5Ya1tPTy3SxvJWJ7b QzGfBKlNvVdH9o0H87j1Q3YVmLLOIWlng92R1ntd5S0wp9QSLA3HZqSVl36xHUkPwdk4v9 w7fZMbyGer4B6syyQosxt7dm8K0Jn9Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738029384; a=rsa-sha256; cv=none; b=5MUBlQ5AQvY2jnyvvpd5ewYvJNqW8u7kgWtFohif8hpOOmKtyC+Vk7e4t7kcZkQR6Y5ke/ x2vgccgYfhBouXnp0yGpRoWkpwrGcCFTnozz9nb4yTBE+zKkU73by4gqOdKujXJSBUnxkz /JGL5PB4mqBzxWOq0CvusU6nC/iqTj8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KXPWaJN3; spf=pass (imf13.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-ab2c9b8aecaso930572266b.0 for ; Mon, 27 Jan 2025 17:56:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738029383; x=1738634183; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=EWU6AwZp8J7ygQsAgOSiEIc6X64AlE6QGqWBqVt2uXY=; b=KXPWaJN3caVcyoVFH6VrkdE8PPQkq60Xw6V1jpq3rf/iRV54zkbVisOcVbAfEx6ls5 0rPGl1U+9ungDOKPntvV0c4x4h/7Ol+hJ4O5quMQTiHrATguNaA9RDs2n1GjJbnEZf3P iHgI8mvHKWXqjsN35AamAx/0TEfm3lHCEIJEbgYDfQaElAMOJD8Pgp4rQA4csgGUCXjY KJMyZ+nAi47ab60wkUXKQIUPtIKyCfnx3DD2iMdIfulCfD5sMrQfA2KQWkHpMEJlt1um 3sODvmbaYycrZtGUArflcMrIWz8Ea5jH7mgKt2ZIj7iMr8WlgibVgaPpH4dQrIabB8Bc TgGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738029383; x=1738634183; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EWU6AwZp8J7ygQsAgOSiEIc6X64AlE6QGqWBqVt2uXY=; b=J1yisCrDBvhpJe1AFAb8t1UNTrv4THZqs578mwH/4IJhrNBnOyBq66htZ831GVFx+E 9S2WxjfIxMGOfMZaMBacYFQXiJ/TxzktDTwYuMYQgKjUACCHQbczEJNC9jnbcbMofqDZ kdGGHBbwTvENh8kgWaasMyoRKujNeAzxgMKIiUpmGK5vMu+g/+0bAa8RkH2ysDRMNGeN ncXW4qfkoBLKe9PA0XAfXDKSDvxrgoLIUzX9ev4Ev7q2UALqh1bD3tJxOj3fTOTuXCCZ gGgb1N8OUxOelTbZtxZilYC7kRpa/+YpJUELOLKRn7Ca8FqdZCf77smG5d/fhEgUD7Bi p7BA== X-Forwarded-Encrypted: i=1; AJvYcCXwfpoS5zai2fYtnNB4d+bls+rOiIBmcSJEvsXrFm/KIlZagCBuQVyN45WovWlZY5I3pXe9vEz8gQ==@kvack.org X-Gm-Message-State: AOJu0YyXrGMEH/yy8EpLff8WBIF85sB+dldZIqAjrku97yeht/2bMfnh FjpeRkhP5MzY/GGhVCOixkblISO9VhxzDRGyCHEwpqlAIJkhpIxh X-Gm-Gg: ASbGncvCWq22ZDRiuFrKkYPUjy3SJsIIcgZXCkOLPn9hM8CvxjxiiklHh0dK9IV6fZl FiIldynGmPp6lGsO19ywNvwqLx7ZMZ/SdXGwKY4wYteJhqo+04M/9I/ZBTgp+Ac0qa2aFQ53SLl fb46DpF4lZaWBJX27NLnGlboDMPZ5uA88CWwjUZ5+UI1w1fs5h/LcJg0N0+qXnnZQlrhGzByeBT tCEucVTd8OiCGXKO+MGdWUsCPaqVb7xC1bDHQJTaIre64ph8HjRWYtaOjegLnEl5b6PBHzyZiSh VwSH X-Google-Smtp-Source: AGHT+IGT9wQo+q1PSq8Iqd61Wt7pljIBjysMlZxYH9ljoibA/8m4xh904m/i6lExgB2zQq3i3XgSCA== X-Received: by 2002:a17:907:7296:b0:ab3:4c32:aa6c with SMTP id a640c23a62f3a-ab38b10cfa4mr4144509466b.20.1738029382501; Mon, 27 Jan 2025 17:56:22 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6760b70a7sm681498766b.116.2025.01.27.17.56.19 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jan 2025 17:56:20 -0800 (PST) Date: Tue, 28 Jan 2025 01:56:19 +0000 From: Wei Yang To: Lorenzo Stoakes Cc: Wei Yang , akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH 0/2] vma: fix unmapped_area() Message-ID: <20250128015619.w3rl2dcbdg2f43xd@master> Reply-To: Wei Yang References: <20250127075527.16614-1-richard.weiyang@gmail.com> <2b7d4b72-5628-44d7-8e6c-2c8945b805d6@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2b7d4b72-5628-44d7-8e6c-2c8945b805d6@lucifer.local> User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: k7owuymekib8ockp1pahb6ry4xrzctbh X-Rspamd-Queue-Id: 68D8720004 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1738029384-341192 X-HE-Meta: U2FsdGVkX18Ca50P9vEmvn4mS2QdzsPROGvPM/YdezGEPuzShpV1lQTkCJ7G6mYIKAwYDephS4X+nJQ7gl9/PyF4tS1awWQj8v/ojXRn01uo5EhtheflWmrhu1FsDBSoHbR5cX2oqbzor9Z6uzQtKOw9exoV7UqZp1eA+5Ji1z2jk2Wdso3VKTdQ+R4Piz/ac/cjAN74VPcrrNzA/5bIvyjv9bw5V2riZq94UsWFIGHOn4EcG9f6z943ztyZ6dQ9GV+wK5QAq1jV0OJTwmLdtJe/34DffHejMGOM/hKQMkU/HqP43qKhwg09K5iDpkcGDCvVwV9d9pGY8RVOzHvQcTI8ZmQBJRIldlsQkBk123R1X9bwutrmyopIxZshmqH3ouq02+IkEZEwAc9T/5ALcy83fk8mXzeGziFrcqCX9gXJViUGVfbO4tJM4ydNE7rdyZnp4lqr8rnS2mHS/5JqBEdiApJK64cIv6YRvDMNft5C6CMcqDQN5b8mneJQsKYntn96z675kWyc5X7AhGn9yuakm/i8dYZ/4RGIDmrPS1+YiZZHcWkT47cOANxfqMMp6mIIerb0ps3GS3Qbx7RAL/LWRhojCVe2T5C6f4cgL5Pj0Un8Da+oZao/DXqCrKZjilnhDfmDqOlbS0fryN9zEHHkrOOBy2N3mF7gZRhdFR8dk3ATmyP6xI3lozO7R3EOY2jc3aUG/eY7r5vgh06ilg7i88VIroMcRtLBxtGd95hqa/0ayRFrGIXmuKg287mCV9U8FVy+lJlbdwHrbpxgbWvdtN4VnczJMDefeTuEjGYj9kWh0xl10O8YA0B9V0p9xkYe8y/szqYzVceWjkzBW+gOfLMeQi103nIsi8rwKFLhjb96Ej9T5uXrVYAYx88wK6b+ejDVoqsJ+xeNayFb5t011IndoYCFPZ5G+05Xs7Vj+htNvAmNXS0bBsWsoUuR5bYqYRzzoE3qfKZe0mE KnAfVTKv CqJ4EisLHn4xQhbkE+XfFJO8uMCQmTqkmYGTz+U2mKtD0ncy9h1sWAiBEL4N1sFR+cA4bZAhG/Zt+Whqlrnn82CvjsEEfPnQdYqcLXDMv8j1bHzc0puA4b5ZIVIAnEr5EkDWygP380SX4uRdDUsD7GNECCeIWxlvFTjL3tg6Qvu7XZBAbFKexxaJfmeSVAwXqJVJbgsC9qBHg1+mypq6xHtfmqi/L2jd0Ue4mt6f0LqLuuvO08rfhLybpwC+K818b/TmIFv9AFShwiLmo068IKEMmWdYoS+9ZxbItt3wPiVR5qlCA/n0zQLYae2Vw6YcJevztHHMXijyz5XOkJGqgX+PiN7/4suQbyZEGwJ1CgQuazZB1zZpGKbuYTSStRb8YGmJnPBl4brdtnRpG6GohcHrjCSEX2qhPeWrKYlqYS6LBao4GTed4bOL6Ai7plw17mbaPy8jX2551eSyZYqmk3XBa4iHMaBAnKmxmMSPCIC3ZWk/a7UNps5Pr91b/TD1yh0GyKExuqd2Eqtqz+s4DD5rCooRseYJQygILLi7X3mE2fF8Gdf3yU0ImJGxus+r70WAAR/V798+QZ5TFQhbPnmVP4WBbjZBSBIpnxDRakx40zhbZTYVS2+mCzGZu3kuLjuxsaWdt38IqZOY8p19fo2jhzcSfVowHd5FyrZ3IC23IZ2tEA/5W4Rwh5CzgoI1p8+4pm3XehUqyn+ynQrqFaoySNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002159, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 27, 2025 at 10:50:17AM +0000, Lorenzo Stoakes wrote: >Hi Wei, > >I seem to recall us having a very recent converation about holding off on >patches like these for a little while to which you agreed, and then you >sent this pretty much the very next day? And during the merge window? >Honestly not _hugely_ impressed with that. > Yes I remember your suggestion. I send this because it is a bug fix to me. Per my understanding on your word, it is ok to send a fix. If I misunderstand, I apologize. >In my view this patch should have instead started as a query to Liam about >the gap calculation, this would have been far more civil and would have >allowed us to determine for sure if the approach you've taken here is >valid. > You are right. I will try to be better next time. As you mentioned a query before sending a patch, this is preferred, right? Hope I don't mess this again. >Given your history of sending entirely trivial patches which we keep asking >you not to send (mixed in with the occasional actually useful patch) it is >KEY to communicate to ensure we're on the same page. > >If you send meaningful commits, we want to merge them. Arbitrarily sending >something like this, at this point in time, when you've been asked not to - >does not help achieve this aim. > Thanks, I would be more considerate next time. >On Mon, Jan 27, 2025 at 07:55:25AM +0000, Wei Yang wrote: >> The gap check in unmapped_area() seems not correct. >> >> Add test cases to verify the behavior. > >This is an -entirely- unacceptable cover letter. It's two lines dude. Give >some details. You're actually tackling a very, very specific aspect and >scenario in some of the most sensitive code in all of mm. > >You really, really need to be clear on what it is you're doing, why, what >workload you were doing to hit this, what testing you've done, what real >life things this interacts with etc. etc. > >It makes our lives easier as maintainers. Right now I see this as 'another >trivial Wei patch', you need to provide details to prove otherwise, if that >is indeed, not the case. > >Also your subject line here is horrible - 'fix unmapped_area()' - actually >you seem to be (in your view) correcting the calculation with respect to >upward-growing stacks. Correct me if I'm wrong. I mean even your patch 1/2 >has a better message... It needs to be more specific to what you're doing. > Thanks to you and Liam. I will try to do better to not waste your time. >> >> Wei Yang (2): >> mm/vma: fix gap check for unmapped_area with VM_GROWSDOWN >> tools: testing: add unmapped_area() tests >> >> mm/vma.c | 2 +- >> tools/testing/vma/vma.c | 177 +++++++++++++++++++++++++++++++ >> tools/testing/vma/vma_internal.h | 2 +- >> 3 files changed, 179 insertions(+), 2 deletions(-) >> >> -- >> 2.34.1 >> >> -- Wei Yang Help you, Help me