From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66F68C02188 for ; Tue, 28 Jan 2025 01:36:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02B7B2801F8; Mon, 27 Jan 2025 20:36:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F1CCF2801F2; Mon, 27 Jan 2025 20:36:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE4462801F8; Mon, 27 Jan 2025 20:36:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C0C012801F2 for ; Mon, 27 Jan 2025 20:36:18 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7F963A0A1A for ; Tue, 28 Jan 2025 01:36:18 +0000 (UTC) X-FDA: 83055145236.17.7E1E8BF Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf17.hostedemail.com (Postfix) with ESMTP id 8322140007 for ; Tue, 28 Jan 2025 01:36:16 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CrGj57in; spf=pass (imf17.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738028176; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vB7/BzHPinntBVyq1cu++VrXejkNR6ZDjsGuTinFeVE=; b=wpP/j4v37lXp8e8mCwMrdG5fFDxgsG1LS0NIYz4nQVZNFzSKOcE1aGcQ0kATUHZGjbREiH zhXxyopqBgUtmCOs0wcaAA1Fx2TSmGcpb0cSmThRo0XsXrbEBWHIh6ZRHDwekcfa+jemeO 5TQtRRMpYe01VOFll8pStrKhKQU9nVg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CrGj57in; spf=pass (imf17.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738028176; a=rsa-sha256; cv=none; b=s6yertBqGtSCeZ/PyVYhsKUYejNkb/J19oP5uZBweTqcT+RlTZSHA4lzbrGSZZ+aPx4zqk J+d6gDK7yqjwsMCeh52OnkvTMh6pXfXrQ/V3A/YbLnp1XHFA7b2H1PsjCSG0HzO5rapsYb rqlyYHQMFpTiF4cswxFDlRfW+EiMYUE= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5d4e2aa7ea9so9945416a12.2 for ; Mon, 27 Jan 2025 17:36:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738028175; x=1738632975; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vB7/BzHPinntBVyq1cu++VrXejkNR6ZDjsGuTinFeVE=; b=CrGj57inYiXq01MnjhPcCTG2jpBISdBXxPy/cRbkx0vPRUR4xBkdn4+U223kKsKUXt T5NdPriXger5VFqqFAnCZZb4Dl0TcY7LGoPICFXSVc9i5RhK9283wh/INfR5HVSoFZ2y emrVyUqj7cKi248o9rdO15EGkClCRNbkuvJxvyyIMgScG3hwGZ2wssrb7EONIjmNHvKn ekqM3vbAwnoPVjJKsffHmcRm1oVm8xnIyBL1BQtV8enW2LC6kOwGvQf+eOy060JtMdsf qGb49VEG8WKSZfTegpHcQjFfMvxPIHF0G3N35G4J9VM1p1cQH51QHqqkj2VHvliBubQm U/WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738028175; x=1738632975; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vB7/BzHPinntBVyq1cu++VrXejkNR6ZDjsGuTinFeVE=; b=V3qfYl8BjgzXytxn+QQ2eIzUJRjKNY6QgZU0t7pBxgm8jDBRBY6sIH9SArhmM7mptX XKufnSso593S1ZJ+TsDsBPauoAUPJDxVqUocLoAvjDHYcp8jjAO6PFkNwxrFnF0ile8h JVFOq19DOWar+CUrWb9E1dyEIUPnSzpf6TSbzDKwVFvE+zzTGVpxLkTRa+aUfdkl5csY Q7Cclkfpeh53fvBUseJJIV1Apr/KSTvn5KAlvsc+mtSKSsz3vtu5KFQaNTftIBkNcroo RNfw8pReX4QBeG4t42ZKCNFIwkpnJBlwH9m/pihyMsVXRotIIaUFAsEVW4GC1mZgr+ye +r4A== X-Forwarded-Encrypted: i=1; AJvYcCXV1pa8BTWHPLAjgYlXT6rZvwhCDCjHtSPQCs0hbP0nD20bbrXQUIYufHUgGn+t7hKnk1vHu1jXXg==@kvack.org X-Gm-Message-State: AOJu0YwNBKzyFqJ1DE14j/CKghJwc5xhfg58PbflW3vHZbtriD9DwI5j IIwiQze7OW83wmq+Ncg4bkX83S/6IcnOVLPa3PbK5Uydu1Gdnel5 X-Gm-Gg: ASbGncuI5nCvzlKobXyoFKIo0yhqFs7dHa2SIJCQvUTF0EcUC8phxApXbxrGtrRAOYL /bLtAWSpzT0khRRnBHBu7YA6/N9fydnAToz65wGZiOa20QxZrEc0gtNrSHKiBlTRpXPY06PcQEB V8EiiQ8QPMh6pT70TWQVq9E3vrw0lavMwtZuoNh2qpcIyvtJso9V+91W8smo2m3Ip2a47LO3RqS FoOxJfMn0tT0zbeUGAzdELqXGFVc9StjsBkKmRg0X1af8NSi9siQZE68XfmQuT0jDsYTncfE37e 2fUP X-Google-Smtp-Source: AGHT+IG7ss8wUa3fd0qfuZhljJLuZL/rNyObAcErRmWzcESymuWkgsE9Tpx7sAhcNElHSQHIifGnQA== X-Received: by 2002:a17:906:770b:b0:ab3:9923:ef4e with SMTP id a640c23a62f3a-ab39923f855mr2572797066b.22.1738028174565; Mon, 27 Jan 2025 17:36:14 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6760fbf43sm672554366b.154.2025.01.27.17.36.11 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jan 2025 17:36:12 -0800 (PST) Date: Tue, 28 Jan 2025 01:36:11 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 0/7] spanning write related cleanup Message-ID: <20250128013611.2c27dcaa5dq2kcth@master> Reply-To: Wei Yang References: <20241127012753.3393-1-richard.weiyang@gmail.com> <20250117054942.w6vgrllnaasjaww3@master> <20250124013412.2vpf7davx63s377d@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8322140007 X-Stat-Signature: j513qnyhr9iu67mpxsejtsjsdnqjhnef X-HE-Tag: 1738028176-842941 X-HE-Meta: U2FsdGVkX1+csxBOd+v/96QZlkhalSkDSGZPwzhCUA74m8bq3aubcaYRpN/YP27u/bbjmGgaxd/pW5xVWLTiSWX6fHPi874tReGGpsUQvWiLIBwkxiFtFJT5IKR2Lu4pD5OLMNA40E29nMR9wUSmH0vgQbtY+1h4Yc9L8BbdP+V5JCrXeiqqKoq7mwDmwoshr6cyZnc+ae5zkCLTGhenozhY9jQ/gELy4xFpUPgA8Kb+jBELbOjWd6mwC4TXQOgPjGVK3vXIqPA0ZdO/i+fOO0eIRT3ZXMpeWkzKmZZ8EI4ItCR3L9PX6Gtq5KWErgPq+yAE+7xk6nt7lveZTaEK8O6Qq2muvnof6IS3CAPylM6V+CTbePxKmJqLUK1uqyGHlT/oyBw2pKYEVkJDOyLm+jYw4yjFPut+xTx8sjpknrx2H++lLQm2Dx44qPzVr48u4gYVui6b6FPyRYicDN1GmDh9SbY4rJZfHXsBwm0V7+tC+V7jtbjcziSkl93Bx6RBXMtu0g9SWn7QNie2wwUUjgtbvYVGH9IKMbjSviLWpvUqXGdWXElV9hPWCng4XMgIuth79qHCdRg90r+p/8rVBPxAGZHsZTgCP0oqy4QIGKfEWmbbIxYb/VwRFK/1ra3J00/OT8Z8wYy5ONdnpIPv5FDG2ZnucrTPkci+j0Aa2vRS2x69yqu7eaaqf+d20Wxg4WLHWC2MRiTpof8Up7WGQQsH0fhvk0+3q0iyral5KZ41FtVdUXJv+nbTRITydNYY05QBczfiRrrycUB9HuS1451RRhjLE9rCZwiRGjM8aVjSrPRpu54orxkjUk71uO3oi2hEyXy0FOORK4JOwAhvFALE1LEVGqKUQ0wlQwCtY+jlwzqTL7e6/ctgy9h0QTHJi1YjYpM4KlHXLm9mKcjkVjlkb36vogEXLp1+42Ag7FZJZY3CM2KVoMUwVORQKaZrBdhN1dUKoqcliRbVpms qBDE+JLA LOeFZPW8l/hZXYu82h2YNUZtAsG7O/aUDupi57Y85C1N9WRnvsyWh+D4mkrM09dRj+UzVbYG7OAuSj7C7Ke18DOlzHHtgk3nBpuZ3IS3g9Nkt0J9SYpQctWPd6Bk+T+AnQFUMIzwuGzHuKwbNLBzm+A0yBAybISIk6c/JdCYrHdCtrdt2ubfljnPzVRDhe0AXsP3iUM4Q+skUJshis1q6PqS8CVCmXtHDIy29sDJ7moE2rhmU1FoH9bd4fLkvrl2yqu+yIhQOIgrG53vU7LtTY3sxNYQUUWzt8yOfMi20ibex6XJ0zOyAtQmMFWyyRA3o9SMet9zjWYlehtacclz0sHKOFqxlzk6fXMjFLyqSlQVSDNZe1PDsxn3/HNjeHR4aPUzl3vqGBQoTg5awN8CPcWKhKjbMTviiRSHItTwjFnFU8HeQdE/yJj5sRrfmuBfNbbsdZYFJ45aDCsRew5a24VM5UDvI3Rm33eG5/kaBWPCBUMb0whP97/1K4LdQ6PQR8Yb+cxRbXFIPe0tjCpwB6UIVRA7ZJ4Rf6JlgVsan27phXkAmxMy58McdB9TGxFx7IJvy6ykC8feGTrqcCUOGufE9ZaTcFBn5Sx06xxFFBceqJVb6QI7NcSZSvPtQN8F/MFyZ9hFEpQVsBG6v6/fWRZ/Xizdr4xCSLUfCzxK+LS/PSdE/XAqALqFwo1f9Vvs5BTrYZGi7es+wkQeSxBVlaQknP9uaUBhcOHW9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 27, 2025 at 09:36:11AM -0500, Liam R. Howlett wrote: >* Wei Yang [250123 20:44]: >> On Thu, Jan 23, 2025 at 12:52:40PM -0500, Liam R. Howlett wrote: >> >* Wei Yang [250117 00:49]: >> >> On Wed, Nov 27, 2024 at 08:31:13AM -0500, Liam R. Howlett wrote: >> >> >* Wei Yang [241126 20:28]: >> >> >> Here is some cleanup related to spanning write. >> >> > >> >> >None of these fix anything, but do fiddle with code that's pretty >> >> >critical to the kernel. Most of the changes will be immeasurable in >> >> >change but carry risk to causing subtle changes. >> >> > >> >> >Some are simple removal of returns that aren't used while others change >> >> >things because you think they are probably the equivalent. This seems >> >> >like unnecessary chrun at this point. I'm all for efficient code but >> >> >this is getting a bit much, some of these are just preference of what to >> >> >use that will already exist in the cpu cache. >> >> > >> >> >I'll get back to you when I dig through them, as some need a deeper look >> >> >for sure. >> >> > >> >> >Liam >> >> > >> >> >> >> Hi, Liam >> >> >> >> Would you mind taking a look when you have time? >> > >> >Yes, I'll have a look soon. I don't love changes that dive deep into >> >complex code that results in no gains (performance or feature wise). >> > >> >It's also odd to have simple "this return isn't use" and things moving >> >code blocks to be executed only in certain scenarios, as the difficulty >> >to verify the latter is much higher. >> > >> >Can we please limit changes to areas where there is a performance change >> >or coupled with a change that is needed? ie: stop sending patches that >> >change things unless it's with a feature or improvement (performance or >> >otherwise). I'm just not convinced some of these are worth the >> >cost vs risk. >> > >> >> Ok. >> >> So you would drop this patch set or still want to take a look? > >I was going to look at it, but after I send my reply, I received a >report of an issue caused in a certain configuration that caused the >stack frame to grow out of the configured 1024 limit, which was tracked >to a patch you added to simplify a previous function. Sorry for that. Would you mind letting me know what is the problem? or cc me in case you will fix it? > >So, I think we should drop these patches since they don't make a >measurable difference and are not without risk. > >Thanks, >Liam -- Wei Yang Help you, Help me