From: Michal Clapinski <mclapinski@google.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Pasha Tatashin <tatashin@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Clapinski <mclapinski@google.com>
Subject: [PATCH v3 1/2] mm/compaction: remove low watermark cap for proactive compaction
Date: Mon, 27 Jan 2025 22:50:19 +0100 [thread overview]
Message-ID: <20250127215020.4023545-2-mclapinski@google.com> (raw)
In-Reply-To: <20250127215020.4023545-1-mclapinski@google.com>
Previously a min cap of 5 has been set in the commit introducing
proactive compaction. This was to make sure users don't hurt themselves
by setting the proactiveness to 100 and making their system
unresponsive. But the compaction mechanism has a backoff mechanism that
will sleep for 30s if no progress is made, so I don't see a significant
risk here. My system (20GB of memory) has been perfectly fine with
proactiveness set to 100 and leeway set to 0.
Signed-off-by: Michal Clapinski <mclapinski@google.com>
---
mm/compaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index a2b16b08cbbff..29524242a16ef 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -2253,7 +2253,7 @@ static unsigned int fragmentation_score_wmark(bool low)
* activity in case a user sets the proactiveness tunable
* close to 100 (maximum).
*/
- wmark_low = max(100U - sysctl_compaction_proactiveness, 5U);
+ wmark_low = 100U - sysctl_compaction_proactiveness;
return low ? wmark_low : min(wmark_low + 10, 100U);
}
--
2.48.1.262.g85cc9f2d1e-goog
next prev parent reply other threads:[~2025-01-27 21:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 21:50 [PATCH v3 0/2] mm/compaction: allow more aggressive " Michal Clapinski
2025-01-27 21:50 ` Michal Clapinski [this message]
2025-01-28 1:17 ` [PATCH v3 1/2] mm/compaction: remove low watermark cap for " Andrew Morton
2025-01-27 21:50 ` [PATCH v3 2/2] mm/compaction: make proactive compaction high watermark configurable via sysctl Michal Clapinski
2025-01-28 1:18 ` Andrew Morton
2025-01-30 14:18 ` Vlastimil Babka
2025-01-30 18:15 ` Michał Cłapiński
2025-01-28 1:07 ` [PATCH v3 0/2] mm/compaction: allow more aggressive proactive compaction Andrew Morton
2025-03-17 1:02 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127215020.4023545-2-mclapinski@google.com \
--to=mclapinski@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tatashin@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox