From: Andrew Morton <akpm@linux-foundation.org>
To: Frank van der Linden <fvdl@google.com>
Cc: muchun.song@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, yuzhao@google.com,
usama.arif@bytedance.com, joao.m.martins@oracle.com,
roman.gushchin@linux.dev
Subject: Re: [PATCH 02/27] mm, cma: support multiple contiguous ranges, if requested
Date: Mon, 27 Jan 2025 20:19:07 -0800 [thread overview]
Message-ID: <20250127201907.17a230262bedaf36c5185575@linux-foundation.org> (raw)
In-Reply-To: <20250127232207.3888640-3-fvdl@google.com>
On Mon, 27 Jan 2025 23:21:42 +0000 Frank van der Linden <fvdl@google.com> wrote:
> Currently, CMA manages one range of physically contiguous memory.
> Creation of larger CMA areas with hugetlb_cma may run in to gaps
> in physical memory, so that they are not able to allocate that
> contiguous physical range from memblock when creating the CMA
> area.
>
This one breaks my x86_64 allmodconfig build, which I find surprising.
Did I miss some dependency?
mm/cma_debug.c: In function 'cma_maxchunk_get':
mm/cma_debug.c:51:38: error: too few arguments to function 'cma_bitmap_maxno'
51 | unsigned long bitmap_maxno = cma_bitmap_maxno(cma);
| ^~~~~~~~~~~~~~~~
In file included from mm/cma_debug.c:16:
mm/cma.h:56:29: note: declared here
56 | static inline unsigned long cma_bitmap_maxno(struct cma *cma,
| ^~~~~~~~~~~~~~~~
mm/cma_debug.c:55:49: error: 'struct cma' has no member named 'bitmap'; did you mean 'dfs_bitmap'?
55 | start = find_next_zero_bit(cma->bitmap, bitmap_maxno, end);
| ^~~~~~
| dfs_bitmap
mm/cma_debug.c:58:42: error: 'struct cma' has no member named 'bitmap'; did you mean 'dfs_bitmap'?
58 | end = find_next_bit(cma->bitmap, bitmap_maxno, start);
| ^~~~~~
| dfs_bitmap
In file included from mm/cma_debug.c:9:
mm/cma_debug.c: In function 'cma_debugfs_add_one':
mm/cma_debug.c:169:33: error: 'struct cma' has no member named 'base_pfn'
169 | &cma->base_pfn, &cma_debugfs_fops);
| ^~
./include/linux/debugfs.h:129:38: note: in definition of macro 'debugfs_create_file'
129 | (name, mode, parent, data, fops)
| ^~~~
mm/cma_debug.c:176:45: error: 'struct cma' has no member named 'bitmap'; did you mean 'dfs_bitmap'?
176 | cma->dfs_bitmap.array = (u32 *)cma->bitmap;
| ^~~~~~
| dfs_bitmap
In file included from ./include/vdso/const.h:5,
from ./include/linux/const.h:4,
from ./include/linux/list.h:9,
from ./include/linux/wait.h:7,
from ./include/linux/wait_bit.h:8,
from ./include/linux/fs.h:6,
from ./include/linux/debugfs.h:15:
mm/cma_debug.c:177:51: error: too few arguments to function 'cma_bitmap_maxno'
177 | cma->dfs_bitmap.n_elements = DIV_ROUND_UP(cma_bitmap_maxno(cma),
| ^~~~~~~~~~~~~~~~
./include/uapi/linux/const.h:51:40: note: in definition of macro '__KERNEL_DIV_ROUND_UP'
51 | #define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
| ^
mm/cma_debug.c:177:38: note: in expansion of macro 'DIV_ROUND_UP'
177 | cma->dfs_bitmap.n_elements = DIV_ROUND_UP(cma_bitmap_maxno(cma),
| ^~~~~~~~~~~~
mm/cma.h:56:29: note: declared here
56 | static inline unsigned long cma_bitmap_maxno(struct cma *cma,
| ^~~~~~~~~~~~~~~~
next prev parent reply other threads:[~2025-01-28 4:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 23:21 [PATCH 00/27] hugetlb/CMA improvements for large systems Frank van der Linden
2025-01-27 23:21 ` [PATCH 01/27] mm/cma: export total and free number of pages for CMA areas Frank van der Linden
2025-01-27 23:21 ` [PATCH 02/27] mm, cma: support multiple contiguous ranges, if requested Frank van der Linden
2025-01-28 4:19 ` Andrew Morton [this message]
2025-01-28 5:15 ` Frank van der Linden
2025-01-27 23:21 ` [PATCH 03/27] mm/cma: introduce cma_intersects function Frank van der Linden
2025-01-27 23:21 ` [PATCH 04/27] mm, hugetlb: use cma_declare_contiguous_multi Frank van der Linden
2025-01-27 23:21 ` [PATCH 05/27] mm/hugetlb: fix round-robin bootmem allocation Frank van der Linden
2025-01-27 23:21 ` [PATCH 06/27] mm/hugetlb: remove redundant __ClearPageReserved Frank van der Linden
2025-01-27 23:21 ` [PATCH 07/27] mm/hugetlb: use online nodes for bootmem allocation Frank van der Linden
2025-01-27 23:21 ` [PATCH 08/27] mm/hugetlb: convert cmdline parameters from setup to early Frank van der Linden
2025-01-27 23:21 ` [PATCH 09/27] x86/mm: make register_page_bootmem_memmap handle PTE mappings Frank van der Linden
2025-01-27 23:21 ` [PATCH 10/27] mm/bootmem_info: export register_page_bootmem_memmap Frank van der Linden
2025-01-27 23:21 ` [PATCH 11/27] mm/sparse: allow for alternate vmemmap section init at boot Frank van der Linden
2025-01-27 23:21 ` [PATCH 12/27] mm/hugetlb: set migratetype for bootmem folios Frank van der Linden
2025-01-27 23:21 ` [PATCH 13/27] mm: define __init_reserved_page_zone function Frank van der Linden
2025-01-27 23:21 ` [PATCH 14/27] mm/hugetlb: check bootmem pages for zone intersections Frank van der Linden
2025-01-27 23:21 ` [PATCH 15/27] mm/sparse: add vmemmap_*_hvo functions Frank van der Linden
2025-01-27 23:21 ` [PATCH 16/27] mm/hugetlb: deal with multiple calls to hugetlb_bootmem_alloc Frank van der Linden
2025-01-27 23:21 ` [PATCH 17/27] mm/hugetlb: move huge_boot_pages list init " Frank van der Linden
2025-01-27 23:21 ` [PATCH 18/27] mm/hugetlb: add pre-HVO framework Frank van der Linden
2025-01-27 23:21 ` [PATCH 19/27] mm/hugetlb_vmemmap: fix hugetlb_vmemmap_restore_folios definition Frank van der Linden
2025-01-27 23:22 ` [PATCH 20/27] mm/hugetlb: do pre-HVO for bootmem allocated pages Frank van der Linden
2025-01-27 23:22 ` [PATCH 21/27] x86/setup: call hugetlb_bootmem_alloc early Frank van der Linden
2025-01-27 23:22 ` [PATCH 22/27] x86/mm: set ARCH_WANT_SPARSEMEM_VMEMMAP_PREINIT Frank van der Linden
2025-01-27 23:22 ` [PATCH 23/27] mm/cma: simplify zone intersection check Frank van der Linden
2025-01-27 23:22 ` [PATCH 24/27] mm/cma: introduce a cma validate function Frank van der Linden
2025-01-27 23:22 ` [PATCH 25/27] mm/cma: introduce interface for early reservations Frank van der Linden
2025-01-27 23:22 ` [PATCH 26/27] mm/hugetlb: add hugetlb_cma_only cmdline option Frank van der Linden
2025-01-27 23:22 ` [PATCH 27/27] mm/hugetlb: enable bootmem allocation from CMA areas Frank van der Linden
2025-01-28 8:55 ` Christophe Leroy
2025-01-28 17:52 ` Frank van der Linden
2025-01-29 22:43 ` Frank van der Linden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127201907.17a230262bedaf36c5185575@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fvdl@google.com \
--cc=joao.m.martins@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=usama.arif@bytedance.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox