From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7461BC02188 for ; Mon, 27 Jan 2025 18:42:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE459280177; Mon, 27 Jan 2025 13:42:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D941F280163; Mon, 27 Jan 2025 13:42:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5BD8280177; Mon, 27 Jan 2025 13:42:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A5875280163 for ; Mon, 27 Jan 2025 13:42:39 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5DD34120164 for ; Mon, 27 Jan 2025 18:42:39 +0000 (UTC) X-FDA: 83054102838.07.3E23A61 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf08.hostedemail.com (Postfix) with ESMTP id B871B16000D for ; Mon, 27 Jan 2025 18:42:37 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf08.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738003357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=nutNl9P/qqMp7V2SdwH1ZvEAmUdT2eEBftswLJGOhhk=; b=n9+OCZW4uexXs8cb4c+To2S0CwLGSJyiPJTIAMXh67AH0HB09wMo/edNTPp1lTgpHERVVk wnKit88T4XzaVu3O8J2UPuei6FC3HaKfi9ThPeoRIi/mIGJPqkGW+fSHtZ9OfwYveTQixj 9/DLDOqvkvm2KEIouXLjJyn8bqftiOA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738003357; a=rsa-sha256; cv=none; b=WkWO973MayYo2UN3k/7urQblwZdolpIbvIPNT/M9bZv+A3eEJOhQh2cOOiRqMqLZc/VgxZ I3YSanE9NaJ3P4rZEMqNYG4NGCUdwKkHHga8qsOaFzEZLI5ClMEBipn05FXIXsuWyM6qYj B6LBZS60lpgorfIceTgB9A4lOsPZpOw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf08.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0CFA8A4199C; Mon, 27 Jan 2025 18:40:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59F7EC4CED2; Mon, 27 Jan 2025 18:42:35 +0000 (UTC) From: Catalin Marinas To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Jakub Kicinski , "Matthieu Baerts (NGI0)" , Patrick Wang , Andrew Morton Subject: [PATCH] mm: kmemleak: Fix upper boundary check for physical address objects Date: Mon, 27 Jan 2025 18:42:33 +0000 Message-Id: <20250127184233.2974311-1-catalin.marinas@arm.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: B871B16000D X-Stat-Signature: n9ud4nhhjjxxew7a7mepzb8p5x94ikg4 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1738003357-463163 X-HE-Meta: U2FsdGVkX1+zW43+TNsDdZ1MXvgg67+KEdXcy2VpXw/Wyjj+5SWERfRYlTAgorT8OidTPy79svvQbhSoVa7d4wz4eOAbhhoq3mb75MgYPu4gXHFEu08tW8Ai4pfdPqerHhPAkOu4GX3v3A5BcPsLyFcihvuigljGlTK60/F72R0XahzL7kcfHvNELf7qF6nnlcThJq3QhxZEuZi+Gycq6IRHTYq1Jljzvi8+JQ5bT5FwXyUoaLphABQSTfQivkEWYroHdF5DDnWH+9gvOYJoILqVZ/IB8fK7ULugNfMOUr2aeq+wIVwcx2AbWNrWJQ1CQDSn4SiBXuYscrtIrJq2KmWj2TGvQsAUVHLIBtU5P6xFuSeybwPS2oXnE7GmhXN6iDiXmNUeCeNOl80G7RAmnga/UiDM/Wk6wjEcf7sALb4wW4yKbaWRPNew5nuvga7syg+U1K7o7HHxE6f7e32R1kH0X9BfFECxk7B0Laftzc9Z2MV7aJxwYvdMK4b1cP4THhjqNF/dUV3RVxcQjfbK/YxSIq54zOM9c+h0G56D7KeB2Ahg0RTlHoC9IgxG9Gbxd1GgaM9xUqNTtlyBSVAXiOUIIaic/dmLCFtWYyErXQpF6AxsdI/cyFhaCHWzdjL5reXM5rnt/chFSb+F1Ue9F8FvoYRfB3ZZLLWNs4to23QkltsMzpmHgIsVeabI6Fj/uWohbJ5fO7MgoD+q+vAYqD/IVv/aoee8uYZQHNEbjWDH7hGa74VYWIHO5SskM0ABU1LI+iKOCNyS4/QJarVwVllttLkFj1bhWOIomYnVGznsSlLUVov6JiEoucXrCBCegkz1UG9cns/DqnvXHj5hJUjq0wSocRZxM7S5EHBaK3mPOtpyX9PxqprkcYKf+l+lkgjrnK3xGSDDIQo3peKbIoxYceB9y6YzkSq1Y0JVIeqPk2HjN0f590f/6dGfIWfTPbu2RHaSWAjUcnxeex9 kKLlUq+j 1VL3QC3fqjNwxWAOku6gh139Qi3nkzT4lo0CVjctqwS2xiDDT38kzAoJdJsKdkQUk3OlYTCfzaOzDBVHcVZTi+hwOzatcLYrKLl5i+/anVy4+3AoHPZKWoiioyT5KI0BEYHQtBPywTLWFKoXw8hf2jxpZcG2BzEVFOGhYgeZEdGx3IzEcP/k7CRKsAJPOnaPCg4962jJlZv+Q80jmaUIEr06x1P65v5KqQQi8f5jYcoFaTJJMgIPYpXGKmSSgfPnB8ham5v2QGP5cFyK39A70e0m14E/ZNPSRwqY8sbEWwsKFw7Ta76N4RUD78tyzqoSGdEPdiCHLd+/YouV6WsA+dd9jig2iO7z95j8naMa9p3+7JJFbWJiPnC6AFxZOZ6azQ25FzvMY6PHWAn8Si2AF+0nzJkyjp3J6O/FkLd4bzFA+ARa4ZRKbUCBKZ8cUZn12nW9FcF5GrGDCFkHvGDa0p4voRiAIbfG6doDg27zHdchYcU9Et2dIHBTvQC0SnPiiifwEUsHzzRw02wQGVMDg3m24uw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Memblock allocations are registered by kmemleak separately, based on their physical address. During the scanning stage, it checks whether an object is within the min_low_pfn and max_low_pfn boundaries and ignores it otherwise. With the recent addition of __percpu pointer leak detection (commit 6c99d4eb7c5e ("kmemleak: enable tracking for percpu pointers")), kmemleak started reporting leaks in setup_zone_pageset() and setup_per_cpu_pageset(). These were caused by the node_data[0] object (initialised in alloc_node_data()) ending on the PFN_PHYS(max_low_pfn) boundary. The non-strict upper boundary check introduced by commit 84c326299191 ("mm: kmemleak: check physical address when scan") causes the pg_data_t object to be ignored (not scanned) and the __percpu pointers it contains to be reported as leaks. Make the max_low_pfn upper boundary check strict when deciding whether to ignore a physical address object and not scan it. Signed-off-by: Catalin Marinas Fixes: 84c326299191 ("mm: kmemleak: check physical address when scan") Reported-by: Jakub Kicinski Tested-by: Matthieu Baerts (NGI0) Cc: Patrick Wang Cc: Andrew Morton Cc: # 6.0.x --- mm/kmemleak.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 820ba3b5cbfc..bb7d61fc4da3 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -1689,7 +1689,7 @@ static void kmemleak_scan(void) unsigned long phys = object->pointer; if (PHYS_PFN(phys) < min_low_pfn || - PHYS_PFN(phys + object->size) >= max_low_pfn) + PHYS_PFN(phys + object->size) > max_low_pfn) __paint_it(object, KMEMLEAK_BLACK); }