From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04795C02188 for ; Tue, 28 Jan 2025 01:19:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8522C2801F5; Mon, 27 Jan 2025 20:19:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8023A2801F2; Mon, 27 Jan 2025 20:19:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CA7B2801F5; Mon, 27 Jan 2025 20:19:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4DDB02801F2 for ; Mon, 27 Jan 2025 20:19:01 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C0F6380A34 for ; Tue, 28 Jan 2025 01:19:00 +0000 (UTC) X-FDA: 83055101640.24.BA98D49 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf20.hostedemail.com (Postfix) with ESMTP id 2F4061C0008 for ; Tue, 28 Jan 2025 01:18:59 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="VlpSKe/j"; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738027139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EPGCH9WDxWzFL81veis9e7ooBDd8aMfq62jkIf6uW0U=; b=Z98dhQ9klHtWJjVbPGM9BdDRQiCNsWQKCGc7JE5rZ4tsXK1ReBgrzIrH5tONTGwzoPRjoG TeKMSSLroZL2r9ekNjY9xATv1ESE8xFdf00mmeZSpvomEQr4Sf12cyd5ge8oECKbGhVtjH 89Y+hGniuyxdsWMw0kx3NvLsxXoW35E= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="VlpSKe/j"; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738027139; a=rsa-sha256; cv=none; b=puM8KU1WBQrG1fB/Pl10xTwcGQeeYqde+3tEIB8lynUYD7MSTQYTB72UeFGIFrEwxmPbWN Iz2ERGzsTjH6RFulm+8/0CvM0ptlkP7Rr25M9UDQ+YX15AQ6cvrXrH7Joig4VwIwoXXBvq RuMdvooC/MpKD2LCOOBIcB/S3poG/yw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 99774A416A2; Tue, 28 Jan 2025 01:17:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F2FBC4CED2; Tue, 28 Jan 2025 01:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1738027138; bh=X5o/D/YAuJQichpl9kinMr+bJUHI5S6+DhM7enYkR8g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VlpSKe/j7CqTr9fZ/oQcneajNCFICX0M/tCSDDLVsTMdC3Lan2AhVzdTPqYafcuTD 9NH1c9Po6VgVjO0B1cVLcnM/Qr08FtKLjZTxSiQNK4LA6K64j09c0iBhX1kCX3nd20 fHmxDuEA+jDzMacnv+FCM5r7g4e5IMN2Y1t78MZo= Date: Mon, 27 Jan 2025 17:18:57 -0800 From: Andrew Morton To: Michal Clapinski Cc: Vlastimil Babka , Pasha Tatashin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] mm/compaction: make proactive compaction high watermark configurable via sysctl Message-Id: <20250127171857.34c71d3a6f0cde1953b02a58@linux-foundation.org> In-Reply-To: <20250127215020.4023545-3-mclapinski@google.com> References: <20250127215020.4023545-1-mclapinski@google.com> <20250127215020.4023545-3-mclapinski@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2F4061C0008 X-Stat-Signature: 41ziicrf7pbxfhbnz4xkaof4e9xjcw9o X-Rspam-User: X-HE-Tag: 1738027139-182369 X-HE-Meta: U2FsdGVkX19wdJlp22ju665guge45hnDX5TUBofn78wB9WHZO7pDyLH7d9mZSB8LZ+O3ZMQG78y7mYwcIRxyyY0D06xjfXj/5lW2mo+wnHJ6G1ywVVrRriODkCTEpq27sqipKz68g/iz/TCpsa/SgldaYTO7C7pu2S46ZnhIHfxmLPw20vuYCZzbzRn3/nBKTAGeNxQO0jNtH3OO1Zrm3I9IbcJqnUJwhQKlvEzk+nUT9HwedclY8mIo3zCY4kilyHEg4xj+mtAuayz2ojObiwsOzFpGZPeaE24p04j9Wp8XgNyjBU8aR/x2OJ2zplGLHU5kESEQAr63XzQHHdZ7sr5QVui8T2y8VS+lmeSfSznGpleOi9dtCGVQlORKkkSBBQ6qMUzPKg4olnjgqVxxsxLqK9gPw+t481CoOnhiHUCB5xZ0Zt/3ejsAdh1VkJaT+1v+Is6Qd13KCIeg5qJm367bEPYFyTa8sYo/dbQCGE+EB3x4/blaTdM/dGEcrmQvWymRlKdO+EvW7bBphX0BzkapxpJkwXAf5NmxhAJ49raR5dLrqgh0CJBdG2daqRrR6EeaOmzzgxZudgrITvXLzAckeL6HqJ8CYudCQQvtmg+VLBvnCny85YGI2WjNTr7tUT7rKlBGoIsAzTZHYh+WzGLEd5XPQL6UVEETDriT+SUU/jq/bzkoxHmoDxp7EqBzoWIyiQY1VlO+07+P8y27P0IZyiMstt7wCnwjHZBE8ZG+R8iGE49T/N4TEBZHoZ7Z98kZwoLQIfeQcbM5RcYgcLStkuD6jRCPQShBvKPfqo9bSxlmf1pIIjRg/oJITILXSPSf5tFoR1Wo/zfHytsg28+vXX6ZPrNOLNxoWWdSy4CBIRKmb33SBxVdg8qrB5+1ZtFzRAXRsbeUbd0WMoXDb80driuvzLgprJELrzo2Eab+DoLYxRknglw5pIXCpYNYtGmBKSr6ep3Aie2Uyww vkx7iZ2U A3++JvaRT9K7G61y+nN/OzsMP0uuDAnk5HwQWALXjnbdwVwqR0K/5L28AM4UOFFOclhMlE/8brVoVVp0M7vszskOWm2HuMIHmxFHzKWXkq1dSR28YjIOQnFaVeG5lrPpOPcc0GTxMnQpWSbIJq1f34brpJNiGaKCgaVGFlGQFazLbvLD+koXOPMzECqSEbNDqlFQYWL+4F69bdVG9i55dJS9xpzVmFsTqEojOZrWhZksSpyOA1YnyGfRLG/lJZh+91CnQclEX+v5H62E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 27 Jan 2025 22:50:20 +0100 Michal Clapinski wrote: > Currently, the difference between the high and low watermarks for > proactive compaction is hardcoded to 10. This hardcoded difference is > too large for free page reporting to work well. > > Add a new sysctl, `compaction_proactiveness_leeway`, to control the > difference between the high and low watermarks. > Oh dear, yet another tunable. Is there any way in which we can acceptably improve the kernel without adding this?