From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B54DC02188 for ; Mon, 27 Jan 2025 16:02:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D92E728015B; Mon, 27 Jan 2025 11:02:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CF665280148; Mon, 27 Jan 2025 11:02:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B97AD28015B; Mon, 27 Jan 2025 11:02:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9182A280148 for ; Mon, 27 Jan 2025 11:02:49 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 495DD160308 for ; Mon, 27 Jan 2025 16:02:49 +0000 (UTC) X-FDA: 83053700058.17.D35A27B Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf21.hostedemail.com (Postfix) with ESMTP id EE05A1C0013 for ; Mon, 27 Jan 2025 16:02:46 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b="an/mRK4i"; dmarc=none; spf=none (imf21.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737993767; a=rsa-sha256; cv=none; b=b72WKM5jIHHKUra7QS1hOchxGgRRRLQomtJcCWar6n8qhDBU6BrOuFRPQbymv3bq9564W/ nZZfrne0jkKWOF7c7SsDTJ9cmdyaee0G02DCTffnylp16k7MGPf6rIcwHldEMqNfcdzbaZ jSUSCGglZC9ZoVZIgKQJHl5M/ztM0SI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b="an/mRK4i"; dmarc=none; spf=none (imf21.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737993767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SXnX6yfCJ4lo25sKBuf0Jih5OsMg7kJt7yHBT/wi2JQ=; b=zrMrbx1woBh8XYnmuY9vkWPDrnb+flXcFLIl4F2bA6+EsMFQ1cCObgIChQ6oJGP2ZgsDgr qkocW/J8MJ5ECEC3oubNfUihT5YCWiW6CTXUHC/TJICkCvYD0Sr5QzBnkEM1qF9cGAQhm4 NGUiHNrMavBV0FMej74YoslyGge1kmc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SXnX6yfCJ4lo25sKBuf0Jih5OsMg7kJt7yHBT/wi2JQ=; b=an/mRK4icZzCqPPHMN609Ff0wL Qs2pgoOW69THhWB5T5gY6nH/4fK6Y72Gx049NYy4Jjyug2T3/ZqGxinuzmLsukap/98K7qe6Bqwy6 7MFOHakKvuHQ9yFf/ZaTeVhJH7QQNtJt3R+A5YsNVDHyFh2+dFXHFqOqCuLPafjvgw/Ko394Ybr25 5i168RQSG388+3kPTU4tUR6sth73mFYsatyAk065qko7xleaRiAMsQW6PIOD1KtmnXAMGvNjM/h8P qmlTj2NGgL7VPHXjuGCxbahpRIiTN3LvPQJXH47YXPZraFzPsPy0cSXa1hMT4QUnZnKtVWB2tSt2P 1b8AU+gg==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tcRZN-0000000Eiwv-24hm; Mon, 27 Jan 2025 16:02:37 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 145F93004DE; Mon, 27 Jan 2025 17:02:37 +0100 (CET) Date: Mon, 27 Jan 2025 17:02:36 +0100 From: Peter Zijlstra To: Qi Zheng Cc: kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 4/5] x86: pgtable: unconditionally use tlb_remove_table() Message-ID: <20250127160236.GJ16742@noisy.programming.kicks-ass.net> References: <00bf7935d65826eee547ac195d7854b1c946dbc5.1737637631.git.zhengqi.arch@bytedance.com> <20250124113854.GA15996@noisy.programming.kicks-ass.net> <45651097-c056-49e3-9cc8-c289c1c0030d@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45651097-c056-49e3-9cc8-c289c1c0030d@bytedance.com> X-Rspam-User: X-Rspamd-Queue-Id: EE05A1C0013 X-Rspamd-Server: rspam10 X-Stat-Signature: 4cetwm5jz3k49o6bipoaqbadccxnkc5a X-HE-Tag: 1737993766-494306 X-HE-Meta: U2FsdGVkX18zrbetfQMoIKPyCnXkscwd8hbq1+GvHK2GHZajL7pCgQDYspz1HZ+ie+J1r8ODNEiStB7mIisoR3FUTlsi7AGjZexuP4AO64ZOvqBsnZco99BEYflfSJjuLOncCFs6E4iL4UXoy9OzSu6jJYYYhvBJVwZmYsU/TlKsdLT7abr8MogCllPDnRkB440Zst6khoZCuVQ2wc7yFDwg9eqI/Y6+K5oz5X6Vf3FEToBf2ggoEvTiDvp+PdA04tivhCG2rbm0glkbRWtghmAQOIc96ywPrGwXBVDgNMq25FHcmyqBiZ9oMVeLDNIhjDJddCLQWdfpYGc5GHVcFsiCC50L9I9AjQ+cFwHLtHIwESrFt2QNYcG1kx67cmiYO/+qHt4eHSBmi/0e3EvnSc/6W3rcQC5Ak59HIkd2QRAmIJaW4VgeCGK8fJjs/4WVaAW+yk2V0BeeQ1gBN/3oVHwZRqx+sTwzzBWOP/+PU9I1Ntne51V9wKiZPXyzFBFulQQEBtHwShambsCHl3IDXanDzAiJggLWkweh45T8b7iiSscwkDXtk7Z02tMCWlmfR9p+qugg1YLYHk1AAMtD3iB3OgXu1PvKd/+h2M/aBhWRSzR69hI1l/Ae5LUB3RcSQl3cW9+8ZjPAX0WoK8SQjZaBWEe1IP7i4JUK92LfYV/ZRwQ9lmm7ATZuyb3p+PIq6XKjuvhSLIIKDmPrb6am0tbJMb1IEB/yejsHGyWGBa6WVc5yodYgakwvaG7oobAYLsTavaHlLYdkkTWbZfZh8J7zZNOLzGZiPqs2oi0otXmS1YF+4VoyTM8xQOEVUENoHC7KMepWmyaunynSA+qkqRYGgPBQzfOTL9lEnbFMn95N+Es8eKJgN4TouVCnI1S0/sNYRG5VBcEaUyczJzrt/nxfOTKbhXhYlnvoXjsj5y1f+aGCE2QWQWPvIOEuyIt/AatQk63X/USstim4zIo alFq8Pdc emHakw9pMFbsSGBvZI3SqbItnE4sL/YwU8s9AaYmbaozVqJ55WcPsUei3dunQAb1P7I59G2Ebf5nD3K8ndxpkNCviqfudDRnSqIG25N2mMK9LZGRJeE8i3ZFLeJWglTvKqL5xNKh0resJ/1ATSTb+giSw1q5q74KqwgHrPYXiGds2q1yXSTW5OtGyLMAiAXctwkwc+xV3tO22tT/VJfoEyZWa30/pMCA0m6xbEmhjaB1kM98BzKaqOZCUnbInIZbp8OxV7CcCft5Wg9wkEAjoRiIryqhnS3NGzSsOWIjzHyQLZ9j1CAoSYNhFxb9g46CxTprv8SA2RJek5Sz0/yHLI7qPtUkFKJ2R42nnsH+5qQfCfPr54iJVG3NhSCgfprMN6FKyX8HhkXoy90U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 24, 2025 at 09:00:58PM +0800, Qi Zheng wrote: > > > On 2025/1/24 19:38, Peter Zijlstra wrote: > > On Thu, Jan 23, 2025 at 09:26:17PM +0800, Qi Zheng wrote: > > > If the CONFIG_MMU_GATHER_TABLE_FREE is disabled, the tlb_remove_table() > > > will fall back to pagetable_dtor() + tlb_remove_page(). So let's use > > > tlb_remove_table() unconditionally to free page table pages. > > > > > > Signed-off-by: Qi Zheng > > > Suggested-by: Peter Zijlstra (Intel) > > > > I think we can clean up more :-) > > Yes, but Rik van Riel has already done the same thing in his patch series > [1], so I was originally planning to wait for his patch to be > merged into the linux-next branch, and then rebase this series onto his > patch. Duh, yeah, I've actually seen those patches and totally forgot he did that... -ETOOMUCHEMAIL :/