linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: [PATCHv2 8/9] zram: remove writestall zram_stats member
Date: Mon, 27 Jan 2025 16:29:19 +0900	[thread overview]
Message-ID: <20250127072932.1289973-9-senozhatsky@chromium.org> (raw)
In-Reply-To: <20250127072932.1289973-1-senozhatsky@chromium.org>

There is no zsmalloc handle allocation slow path now and
writestall is not possible any longer.  Remove it from
zram_stats.

Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
---
 drivers/block/zram/zram_drv.c | 3 +--
 drivers/block/zram/zram_drv.h | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 10e4c6a7735c..07cae8fe9b66 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -1437,9 +1437,8 @@ static ssize_t debug_stat_show(struct device *dev,
 
 	down_read(&zram->init_lock);
 	ret = scnprintf(buf, PAGE_SIZE,
-			"version: %d\n%8llu %8llu\n",
+			"version: %d\n0 %8llu\n",
 			version,
-			(u64)atomic64_read(&zram->stats.writestall),
 			(u64)atomic64_read(&zram->stats.miss_free));
 	up_read(&zram->init_lock);
 
diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h
index 045032acb22f..b7e250d6fa02 100644
--- a/drivers/block/zram/zram_drv.h
+++ b/drivers/block/zram/zram_drv.h
@@ -78,7 +78,6 @@ struct zram_stats {
 	atomic64_t huge_pages_since;	/* no. of huge pages since zram set up */
 	atomic64_t pages_stored;	/* no. of pages currently stored */
 	atomic_long_t max_used_pages;	/* no. of maximum pages stored */
-	atomic64_t writestall;		/* no. of write slow paths */
 	atomic64_t miss_free;		/* no. of missed free */
 #ifdef	CONFIG_ZRAM_WRITEBACK
 	atomic64_t bd_count;		/* no. of pages in backing device */
-- 
2.48.1.262.g85cc9f2d1e-goog



  parent reply	other threads:[~2025-01-27  7:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-27  7:29 [PATCHv2 0/9] zram: preemptible writes and occasionally preemptible reads Sergey Senozhatsky
2025-01-27  7:29 ` [PATCHv2 1/9] zram: switch to non-atomic entry locking Sergey Senozhatsky
2025-01-27  7:29 ` [PATCHv2 2/9] zram: do not use per-CPU compression streams Sergey Senozhatsky
2025-01-27  7:29 ` [PATCHv2 3/9] zram: remove crypto include Sergey Senozhatsky
2025-01-27  7:29 ` [PATCHv2 4/9] zram: remove max_comp_streams device attr Sergey Senozhatsky
2025-01-27  7:29 ` [PATCHv2 5/9] zram: remove two-staged handle allocation Sergey Senozhatsky
2025-01-27  7:29 ` [PATCHv2 6/9] zram: permit reclaim in zstd custom allocator Sergey Senozhatsky
2025-01-27  7:29 ` [PATCHv2 7/9] zram: permit reclaim in recompression handle allocation Sergey Senozhatsky
2025-01-27  7:29 ` Sergey Senozhatsky [this message]
2025-01-27  7:29 ` [PATCHv2 9/9] zram: unlock slot during recompression Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250127072932.1289973-9-senozhatsky@chromium.org \
    --to=senozhatsky@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox