From: Michal Clapinski <mclapinski@google.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Nitin Gupta <nigupta@nvidia.com>,
Pasha Tatashin <tatashin@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Clapinski <mclapinski@google.com>
Subject: [PATCH 2/2] mm/compaction: expose a new param for proactive compaction
Date: Fri, 24 Jan 2025 19:21:40 +0100 [thread overview]
Message-ID: <20250124182140.2243862-3-mclapinski@google.com> (raw)
In-Reply-To: <20250124182140.2243862-1-mclapinski@google.com>
Expose the diff between low and high watermark as a sysctl var.
Signed-off-by: Michal Clapinski <mclapinski@google.com>
---
mm/compaction.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index 29524242a16ef..fd546b797e544 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1921,6 +1921,7 @@ static int sysctl_compact_unevictable_allowed __read_mostly = CONFIG_COMPACT_UNE
* background. It takes values in the range [0, 100].
*/
static unsigned int __read_mostly sysctl_compaction_proactiveness = 20;
+static unsigned int __read_mostly sysctl_compaction_proactiveness_leeway = 10;
static int sysctl_extfrag_threshold = 500;
static int __read_mostly sysctl_compact_memory;
@@ -2254,7 +2255,7 @@ static unsigned int fragmentation_score_wmark(bool low)
* close to 100 (maximum).
*/
wmark_low = 100U - sysctl_compaction_proactiveness;
- return low ? wmark_low : min(wmark_low + 10, 100U);
+ return low ? wmark_low : min(wmark_low + sysctl_compaction_proactiveness_leeway, 100U);
}
static bool should_proactive_compact_node(pg_data_t *pgdat)
@@ -3314,6 +3315,15 @@ static struct ctl_table vm_compaction[] = {
.extra1 = SYSCTL_ZERO,
.extra2 = SYSCTL_ONE_HUNDRED,
},
+ {
+ .procname = "compaction_proactiveness_leeway",
+ .data = &sysctl_compaction_proactiveness_leeway,
+ .maxlen = sizeof(sysctl_compaction_proactiveness_leeway),
+ .mode = 0644,
+ .proc_handler = compaction_proactiveness_sysctl_handler,
+ .extra1 = SYSCTL_ZERO,
+ .extra2 = SYSCTL_ONE_HUNDRED,
+ },
{
.procname = "extfrag_threshold",
.data = &sysctl_extfrag_threshold,
--
2.48.1.262.g85cc9f2d1e-goog
next prev parent reply other threads:[~2025-01-24 18:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 18:21 [PATCH 0/2] mm/compaction: allow more aggressive " Michal Clapinski
2025-01-24 18:21 ` [PATCH 1/2] mm/compaction: remove low watermark cap for " Michal Clapinski
2025-01-25 16:03 ` Pasha Tatashin
2025-01-27 10:38 ` Vlastimil Babka
2025-01-27 13:31 ` Michał Cłapiński
2025-01-27 14:13 ` Vlastimil Babka
2025-01-24 18:21 ` Michal Clapinski [this message]
2025-01-25 16:20 ` [PATCH 2/2] mm/compaction: expose a new param " Pasha Tatashin
2025-01-27 10:40 ` Vlastimil Babka
2025-01-27 10:36 ` [PATCH 0/2] mm/compaction: allow more aggressive " Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250124182140.2243862-3-mclapinski@google.com \
--to=mclapinski@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nigupta@nvidia.com \
--cc=tatashin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox