From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A0A5C0218B for ; Fri, 24 Jan 2025 11:48:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A3B16B00A3; Fri, 24 Jan 2025 06:48:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 879F16B00A4; Fri, 24 Jan 2025 06:48:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7416A280047; Fri, 24 Jan 2025 06:48:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 548676B00A3 for ; Fri, 24 Jan 2025 06:48:12 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4155514119D for ; Fri, 24 Jan 2025 11:48:11 +0000 (UTC) X-FDA: 83042171982.29.B2F9C06 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id C895140005 for ; Fri, 24 Jan 2025 11:48:08 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BUvQ8lth; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737719289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FHz4xRyFvnCB+fzQfYx1bd2piIN9WzxnnPBHmtG/vRk=; b=QKnaVr7uR1xMkRHGg+R08WdRCWqa0B2e6RaKKe+4QZt3T5JT5QzMApLiL5aD4UU8Nj4jNj yJNiAIchWJ6a5FtWSDsWJrOo6cDjEC3y3EkLOwD2iRfVI6qRPaUvM0hpuFSiZjRwmACX8A s1DnqpbyT5YXtZt+sCLjSRce28fZoRQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737719289; a=rsa-sha256; cv=none; b=rbKzPcKX1JzzRAKIKYjnjRIPYcsne6N9p7ivuwO6aXVKy9S27Lr7ExHZ4hZcE78OCy7d+E 52yLsY+jBSuHykGoEA4gOEeUJYr/d+gAARaxRAiVLrHID6WcMJ6imEi+BisjdrWsP2B5Ow UO5To5jw5B2k2hhvAODKjZyVds3CYNo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BUvQ8lth; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FHz4xRyFvnCB+fzQfYx1bd2piIN9WzxnnPBHmtG/vRk=; b=BUvQ8lthZ9k+2zHpGZvP9tKKD1 lquaViIsl97XMxi+w8EPv26S5U4qI49wLbq/7Z70Dx1PNQlAWLNHyX5MOxOeVxP4Nte4BT4YUIzDX F52rfiWnKleajUvXOvI/YtkLPGiQgfJbZ65zkBnOUrhxWnmgueeVKpxckt259crPtJcZ5rXVXpoFM syCjHshJlr2WeOAArElAVkHqGgsD05TidNMiKYomegI18TgNnu1EUL7Y8XuoZThBl3xAcYvswTFQ+ +U1i57UNVCfKIrAKHrrJDCOr78rXxcqssi79dyjWqepk2cPB8NNNMD1JuTWfQw+x7WshfCesUldTR AWx3WONg==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tbIAK-0000000FV1z-0JOS; Fri, 24 Jan 2025 11:48:00 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 4550D300619; Fri, 24 Jan 2025 12:47:59 +0100 (CET) Date: Fri, 24 Jan 2025 12:47:59 +0100 From: Peter Zijlstra To: Qi Zheng Cc: kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 0/5] remove tlb_remove_page_ptdesc() Message-ID: <20250124114759.GB15996@noisy.programming.kicks-ass.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: bbnpyxexr4mkci8ckqujuhgq59dj8n9d X-Rspam-User: X-Rspamd-Queue-Id: C895140005 X-Rspamd-Server: rspam03 X-HE-Tag: 1737719288-750897 X-HE-Meta: U2FsdGVkX18Zn6vyo2Q3MtMYHbR7ZIDHzFaWhxWlkG8Pa+tgN+G2yf4CvJf241Bm0DOd2CdwVXqtxqPbUceazTrVD1YtYJyjvufdH5DqokyJzFHxEbnv9y9L6gtC7QOCkpXdenDjSS8oXhNLBs1e7V9i86LxDyc60dAK3EJRm7Qo0nmDvpnsCC4t2PQ0cqzL4P6V45KD1jolq/yFd4ns86y7CKYF50rz8k71o9acXZdI2wT+nn5MBwaKelbh91lBEkfFz5Mb3GNEErXwnLpAkIjlIm+hXcCMG+ux7031Yu+OMTrN8UxB2vm12oKB4219Ik0s448FvnOmBkoBbhfRdVxYcTVBYq+nda+6UzbKYXh8R7BaRzHjOVdpb+VvwS473bgRZT6OvNeSW1IP6G/BOeW9rsDlJNk3YB4W//owDCOKknYRM+f+TEwAn9TArMZOGERRe5grkhCO9enhndRAecvS+27AVLQB/PO74TwD0ep5p/bn0eUnSHJdmQ+qvlz7wbuB+Fni7bqyBqGsgLMueZmdOxO4HEQLbMzs9rkg7svuyfhHzkOUmaPysd9sYQkChG4knZonxkW9bQcwmOBSndcfzV39GP5NDbuVpONaBGAoTwaG1uTqdg4XMMxTH2DGhbmeWq4S0TLY5lB5pT8vB6r504zVoALy6G8RRD/nUAdRMc7LQOmFqvEej4WBEbfCF9+mryoGfB2ReWC8Rzw2DDmh5aA9DzCuI98Oob4i/SZlk10XGYrMU4/Bkaicxt+GyiwMDO003UMHhvKlVofE5mU8gJ/f36s/CEvL7pQXU4JA4Z7zQZfEXGr45Cva+fObTwupX7WIQoLXcDfRrHhFifeWZNYcjwWplcL/ay8NsuoIqKDECCsJZomFLSN3b78+ydLOQviTawu0nyqgJyzavvEPm3IBukDZbvu1TLsMcsBA5sxe7TFv8PyBnyDm2UgGiK22XaRA9cffoAaKABx ipa8iw6Y rUGdcN3b6vzyR7xmi9qTfKje3SLiaNUB9ugeVrlH+RnvFHco3Hm+2tmdKHpzoKCDHTusHFHRhvpR7HYczEhthBBCxVlXtJCliRfth/vO43gqgM2xkeR9j6m6H2HPvSbG50dvA4Nv+sZk5xM/CBi8R/4d+7a7V4TJ47cuVb0z1c6Iz9QbkUew85Zb8bUAmqfwOjYeODQLatBqL5BHzqk3VfNT4nu10U+MdQ1jO2eppXNogXb9l6acnPa8gfa1cxgghku6d1Cp8OxUyrifS9vFt2LZRolW9Cs+QK73rNnCPzEqze0/ih11JwPkYAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 23, 2025 at 09:26:13PM +0800, Qi Zheng wrote: > Hi all, > > As suggested by Peter Zijlstra below [1], this series aims to remove > tlb_remove_page_ptdesc(). > > : Fundamentally tlb_remove_page() is about removing *pages* as from a PTE, > : there should not be a page-table anywhere near here *ever*. > : > : Yes, some architectures use tlb_remove_page() for page-tables too, but > : that is more or less an implementation detail that can be fixed. > > After this series, all architectures use tlb_remove_table() or tlb_remove_ptdesc() > to remove the page table pages. In the future, once all architectures using > tlb_remove_table() have also converted to using struct ptdesc (eg. powerpc), it > may be possible to use only tlb_remove_ptdesc(). Right, so I don't think Sparc and Power care to use ptdesc, they're using non page page-tables. At the very least we should do something like this, the only point of having tlb_remove_ptdesc() is type safety, there really is no benefit from it in any other way. --- diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index dec030cb1210..a6731328db6f 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h @@ -504,7 +504,7 @@ static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page) return tlb_remove_page_size(tlb, page, PAGE_SIZE); } -static inline void tlb_remove_ptdesc(struct mmu_gather *tlb, void *pt) +static inline void tlb_remove_ptdesc(struct mmu_gather *tlb, struct ptdesc *pt) { tlb_remove_table(tlb, pt); }