From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46F2BC02181 for ; Fri, 24 Jan 2025 11:39:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBA63280060; Fri, 24 Jan 2025 06:39:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6A97280059; Fri, 24 Jan 2025 06:39:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B31B4280060; Fri, 24 Jan 2025 06:39:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 94F2B280059 for ; Fri, 24 Jan 2025 06:39:08 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 15968A11F7 for ; Fri, 24 Jan 2025 11:39:08 +0000 (UTC) X-FDA: 83042149176.21.65EC3CE Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf28.hostedemail.com (Postfix) with ESMTP id E7929C0005 for ; Fri, 24 Jan 2025 11:39:04 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=KTnsm3fI; spf=none (imf28.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737718746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rRSCJVP4ndkq+xRdOcjvb/DEkivJMHzPDW1Wja0Gha4=; b=kwDYh9vRST8G161W5WpPM1WcKSaFTIgvoS9JJhWUkeIpupG+18P48gyW1P6WeIiKA7t0N9 8TB3sD7RmEHJMiz8LXYX0hcwD5wmQICRn8dqBp3iUAF6SoaxQ5UaVOku3w+Nw7EA6O80IE B6gARIJCTQ85mrTeTlFW6my9vTskc0E= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=KTnsm3fI; spf=none (imf28.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737718746; a=rsa-sha256; cv=none; b=0euTs1iy8oqas1ilusEobu6sg6aZw6qr+lOFcWKXz7mZRoyKiwg3+mpO7guLprgI8t9rLr at/XqAF/ZSmb0tdWWEkwKjx4Kr3tT+nhHJ+z5Z9b39+NpbzF7/gNLHo6+ms8pjESaFQE7c XWHcjekbCu6KKzXgwsbQ547XU8mamjQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rRSCJVP4ndkq+xRdOcjvb/DEkivJMHzPDW1Wja0Gha4=; b=KTnsm3fI9AVUkSyp8H79u1gvIz aIz07uHBUUDNqQHPOsEPfJaMlksY/+r3dYGd0Gxfpw5KxMpfMD2FkouQIrcub+WAKrKn4xeI8Yrxy /JWF1La3cgVbC0hS1rEVG+rtaI340Lq6gd4Djr1FIB0Kz/QdwfC916H5opJ/qJgBtdfvMLYBk235I kMi7ATe4rFN6fjRcPB6ph4dPJ+0AcEoI5og8pTmRk87vqFQTj1juTejBclTopp7UdySCyr2k2P1Tr FhWEsbRpsHNUOuErEvqkxZ+fKWTUj17WehlSgkP6BiYr8gJ0MX2YIaiVPOt2otMzzaFVFlloWy0Ak neR9SFMg==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tbI1X-0000000Dzku-05Il; Fri, 24 Jan 2025 11:38:55 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 5F707300619; Fri, 24 Jan 2025 12:38:54 +0100 (CET) Date: Fri, 24 Jan 2025 12:38:54 +0100 From: Peter Zijlstra To: Qi Zheng Cc: kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 4/5] x86: pgtable: unconditionally use tlb_remove_table() Message-ID: <20250124113854.GA15996@noisy.programming.kicks-ass.net> References: <00bf7935d65826eee547ac195d7854b1c946dbc5.1737637631.git.zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00bf7935d65826eee547ac195d7854b1c946dbc5.1737637631.git.zhengqi.arch@bytedance.com> X-Rspamd-Queue-Id: E7929C0005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: cin66brmyomeabwmpms1tkt9e598twer X-HE-Tag: 1737718744-883938 X-HE-Meta: U2FsdGVkX198j3q0rNqFDjh2Ro01dKoEt77h4lo/E/3eERB2SivUDTozbW52DQIvOxR7fIM2gngsKzOVKKs+RM1JtE466qg9RgsoXRtbZu/9tKi1JoP5Qy//YWb3b2VNTHgVgEXm0WU/G0KmzYgMRZ5k8ugd4tQhQAZuKACVykGmYvQ+p17osmyMT+e8VBQ0Bhv7jgdNTeZKky54Up7aw0/VUW8eACyVxV7hPuc7n5z/a9HRQ93h1gUlitq5thmB3T5XoxucM6h5PhIFW86qHXCX/A6ar7zeGaEACcegO43x9NZEq6DS8c/bg13ft0xniEoK2p7H91uH8u+gs0tFpMc//mjlpXOJpmYSv7eCfZ0IEgYqaqNyc4DMaTAsDXWEY86NyJcuQOusA8dMcs3//17QP6kd3BJnAfrYy0QxS4JXztp2+Grh4sZhP7fMKfjzIeS2GS7biLWyR4i6o6AQF3wnsUaytH4pzhmSWqaylQT7Ktqn/PREZcRVfXb0nf4uyUtg7A/iWXGHCT4hwbQDeJAX8j2uBWV+BUpPOjqn5TP3XKA3fKWeGUdeh1ibhmv1SKM8evzZTry/ONgQxevpSaAPc4L34bFbFrvAz/uMGTjQ2yPrlEHTi9miVKWTfvR4CR79RtNcpnl0od5zxTTprM4la0u2aBTGW9T0wRPICxzW4vc7clMPvRENB1XMzgNp3A446GwFCYle5MooBFNfe7V06/Le4TYm4+//Rnvxy6FG4achCI5uYxelCR2+CbwSTrk2zPEaReTN5WsGxidyRI8vjfWqKsZhNVsIWunWIDx/xXbdaDmdYflIlJ6eHZf0Jtm/9SCAnV+lQWrFabqyiYwZ9EiUIlhxOe8qo9jGoHoVcjl3tbH4N+yLI7r5nYUcm5TEGt+A5pMX+7J3vJZIETbSLxu/DcEHekx68GmKvAniLLsmtmE5aXkI02egut+0X/kO9T6DAF1rRey1BbW PzmTL0Lj rgBKen1TSgcA0FdNAmZGkpSyy95zQD7URT95NTcie7cZDg8GZqAEIb9+qMrSnItqduLHn+2i8oFxb1085QxjZVeLmgYX3ZdlXIDgKMd788KILY3mTWCLSQke75eHbKxbzr12kpZGhT/myPVLgkwbA0WQjSgUmxfbS4sXgEFqiMNoIIaLKvKF+HnDI0G3kBvO3YlOc90pHsHdtn3pco30LjkkZ1H3waxaALgoVuBRVx0p2CQQ4MJ9SRQI5XiXDR18HoTPwSxTfKGiUl5HyEGvn56AAx7LT+bmE26/pboEFdcl5zeRYTc5XqAUJ+RiPU0pPck6YU30HN7pqBGG00QvhQOVXfltcYUrOKqZ7SLHUMhoBJ4YU3kaRfrRo//+ZIdkYXfVUTsiNBsxxfOQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 23, 2025 at 09:26:17PM +0800, Qi Zheng wrote: > If the CONFIG_MMU_GATHER_TABLE_FREE is disabled, the tlb_remove_table() > will fall back to pagetable_dtor() + tlb_remove_page(). So let's use > tlb_remove_table() unconditionally to free page table pages. > > Signed-off-by: Qi Zheng > Suggested-by: Peter Zijlstra (Intel) I think we can clean up more :-) diff --git a/arch/x86/hyperv/mmu.c b/arch/x86/hyperv/mmu.c index cc8c3bd0e7c2..1f7c3082a36d 100644 --- a/arch/x86/hyperv/mmu.c +++ b/arch/x86/hyperv/mmu.c @@ -239,5 +239,4 @@ void hyperv_setup_mmu_ops(void) pr_info("Using hypercall for remote TLB flush\n"); pv_ops.mmu.flush_tlb_multi = hyperv_flush_tlb_multi; - pv_ops.mmu.tlb_remove_table = tlb_remove_table; } diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 041aff51eb50..38a632a282d4 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -91,11 +91,6 @@ static inline void __flush_tlb_multi(const struct cpumask *cpumask, PVOP_VCALL2(mmu.flush_tlb_multi, cpumask, info); } -static inline void paravirt_tlb_remove_table(struct mmu_gather *tlb, void *table) -{ - PVOP_VCALL2(mmu.tlb_remove_table, tlb, table); -} - static inline void paravirt_arch_exit_mmap(struct mm_struct *mm) { PVOP_VCALL1(mmu.exit_mmap, mm); diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index fea56b04f436..e26633c00455 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -134,8 +134,6 @@ struct pv_mmu_ops { void (*flush_tlb_multi)(const struct cpumask *cpus, const struct flush_tlb_info *info); - void (*tlb_remove_table)(struct mmu_gather *tlb, void *table); - /* Hook for intercepting the destruction of an mm_struct. */ void (*exit_mmap)(struct mm_struct *mm); void (*notify_page_enc_status_changed)(unsigned long pfn, int npages, bool enc); diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 7a422a6c5983..3be9b3342c67 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -838,7 +838,6 @@ static void __init kvm_guest_init(void) #ifdef CONFIG_SMP if (pv_tlb_flush_supported()) { pv_ops.mmu.flush_tlb_multi = kvm_flush_tlb_multi; - pv_ops.mmu.tlb_remove_table = tlb_remove_table; pr_info("KVM setup pv remote TLB flush\n"); } diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 527f5605aa3e..2aa251d0b308 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -180,7 +180,6 @@ struct paravirt_patch_template pv_ops = { .mmu.flush_tlb_kernel = native_flush_tlb_global, .mmu.flush_tlb_one_user = native_flush_tlb_one_user, .mmu.flush_tlb_multi = native_flush_tlb_multi, - .mmu.tlb_remove_table = tlb_remove_table, .mmu.exit_mmap = paravirt_nop, .mmu.notify_page_enc_status_changed = paravirt_nop, diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c index 3bc8ad282b27..b1c1f72c1fd1 100644 --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -18,14 +18,6 @@ EXPORT_SYMBOL(physical_mask); #define PGTABLE_HIGHMEM 0 #endif -#ifndef CONFIG_PARAVIRT -static inline -void paravirt_tlb_remove_table(struct mmu_gather *tlb, void *table) -{ - tlb_remove_table(tlb, table); -} -#endif /* !CONFIG_PARAVIRT */ - gfp_t __userpte_alloc_gfp = GFP_PGTABLE_USER | PGTABLE_HIGHMEM; pgtable_t pte_alloc_one(struct mm_struct *mm) @@ -53,7 +45,7 @@ early_param("userpte", setup_userpte); void ___pte_free_tlb(struct mmu_gather *tlb, struct page *pte) { paravirt_release_pte(page_to_pfn(pte)); - paravirt_tlb_remove_table(tlb, page_ptdesc(pte)); + tlb_remove_table(tlb, page_ptdesc(pte)); } #if CONFIG_PGTABLE_LEVELS > 2 @@ -67,21 +59,21 @@ void ___pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd) #ifdef CONFIG_X86_PAE tlb->need_flush_all = 1; #endif - paravirt_tlb_remove_table(tlb, virt_to_ptdesc(pmd)); + tlb_remove_table(tlb, virt_to_ptdesc(pmd)); } #if CONFIG_PGTABLE_LEVELS > 3 void ___pud_free_tlb(struct mmu_gather *tlb, pud_t *pud) { paravirt_release_pud(__pa(pud) >> PAGE_SHIFT); - paravirt_tlb_remove_table(tlb, virt_to_ptdesc(pud)); + tlb_remove_table(tlb, virt_to_ptdesc(pud)); } #if CONFIG_PGTABLE_LEVELS > 4 void ___p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d) { paravirt_release_p4d(__pa(p4d) >> PAGE_SHIFT); - paravirt_tlb_remove_table(tlb, virt_to_ptdesc(p4d)); + tlb_remove_table(tlb, virt_to_ptdesc(p4d)); } #endif /* CONFIG_PGTABLE_LEVELS > 4 */ #endif /* CONFIG_PGTABLE_LEVELS > 3 */ diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index 2c70cd35e72c..a0b371557125 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -2141,7 +2141,6 @@ static const typeof(pv_ops) xen_mmu_ops __initconst = { .flush_tlb_kernel = xen_flush_tlb, .flush_tlb_one_user = xen_flush_tlb_one_user, .flush_tlb_multi = xen_flush_tlb_multi, - .tlb_remove_table = tlb_remove_table, .pgd_alloc = xen_pgd_alloc, .pgd_free = xen_pgd_free,