From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9749DC02181 for ; Fri, 24 Jan 2025 10:30:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F12DF28005A; Fri, 24 Jan 2025 05:30:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC252280059; Fri, 24 Jan 2025 05:30:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB0EB28005A; Fri, 24 Jan 2025 05:30:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BFE53280059 for ; Fri, 24 Jan 2025 05:30:31 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E450D1611AD for ; Fri, 24 Jan 2025 10:30:25 +0000 (UTC) X-FDA: 83041976010.07.8FD30F7 Received: from mail115-69.sinamail.sina.com.cn (mail115-69.sinamail.sina.com.cn [218.30.115.69]) by imf26.hostedemail.com (Postfix) with ESMTP id CE52914000E for ; Fri, 24 Jan 2025 10:30:22 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of hdanton@sina.com designates 218.30.115.69 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737714624; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=63gBv9BcOPT8G/70ZH7xXdBHo8GIcmdLjc9/XJFJTI0=; b=l/f8J7q4ZUK54kNRdtqJXSHKkjQtwe+lO9xoBgWQi3S/zzeN0RfgM+oP1HMraBPr9h7N2X //CGIefhR/Az0+SABWyhVeJZcxLf375gtW8pjbKrT4J1MeKMhORPpDsd6DwO8b22z7upQD wPKattBtZk68aBQLc2sPcf+DmkSjs0o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737714624; a=rsa-sha256; cv=none; b=uSFTX0EbWOdejiJuzQj2kw3TYE7CXAdQfpe5mPLj3jQCGXX/HzoMqmfTQeCCniIFk0Zw/V sWk+Yov3ZPc15OXxdZ7Ou0nA9CQ5qfPmYZr4lqt/sCZcM/wPi1bI1cj7cY+cHQhyKNkoIc FKz8RRxV+2afAvgmpHZ9XHTqWKQR4+c= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of hdanton@sina.com designates 218.30.115.69 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.88.49.166]) by sina.com (10.185.250.22) with ESMTP id 67936BB700007D39; Fri, 24 Jan 2025 18:30:17 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 2394937602541 X-SMAIL-UIID: B557A84C3D734ED19C7C980762BD89F4-20250124-183017-1 From: Hillf Danton To: Sergey Senozhatsky Cc: Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] zram: switch to non-atomic entry locking Date: Fri, 24 Jan 2025 18:30:07 +0800 Message-ID: <20250124103009.1761-1-hdanton@sina.com> In-Reply-To: <20250122055831.3341175-2-senozhatsky@chromium.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: mssytjm7toej3uq5osignfmir997uy7y X-Rspamd-Queue-Id: CE52914000E X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1737714622-781136 X-HE-Meta: U2FsdGVkX18yGat8eTr9JCJYzM/7BX9D9qDDF1k3tmrLF9uw9iyd8zcavj/Dt7ePdVATOZOdrZfNitJm4P26dOgwVd3HL1aNfWF+UkNfBhWNaI5y0oEkEy3fw6iDvDbtJcGNxHWOhg7UkfPI9GBsWZLi43gHjNhaTdln4yAqYoiGM+wh/JTnqGZ4cQaiagYQ2+tkifIGhhaNJ7yabALMNqgsU6T6UC/vBlAmdcpuPfbN7/79i03jiY/L0/14R3DOTmFaXs3xKfYNPI34c2MgBnGAD2Gy/WqHwgfL7w/00e4bBnaA81qJOJVbi4UzvFMvpeLLMPwgPkTTt7NUsR082zWA3RqO11WIgM4Dhyc72Wk3x4yYlHtDZsy6oI+FcjNKudSv0B2OHEyB/Fq134GWO7yGVYwjVC74J15n8B7LraIPQNVGteSuwWpQpRWjbJvI1BRadbDHdRxZhU5BD2MIvfBKVw+H4s3pNbqAWvZpB2Vq2c8+AQzh1tVzl7rt9rfMGqvy/TrZz7SemjWcPpB8WBRN5zlqf7CRLyotjJpGh83RVk5lpZuCNk7UBRNOhx/cZB8jScmHnebBeJKhCNFw9qK/2jkf7CaqWWpOGmBf/XDxNTwHMEk1FbwQsz8tX+PJKt18qjkpTzyRciKLY1v2n2nK2wi8T7iJT3wFB2+z2UjIlc4YbLiHRf825VUO5cXtC50yajElZzQowSEfcP3wRod4UDFkXZS2aRN4emCrQ1rN+CrUTH3kCpc43y9sMtFxIon5yQ8XHS9d2RHxB1JHF/MbRtX/l0uXqUclc/D65apTgwDrd2ydJn9v7aT2ISl43ZlS71gaVwEc2XOCjWKw32RG3KfP35vdvUCEJAs0PT0X8Pwd1mrN19fYdVTVDYP89McylkQtqa7pyEtIOe+yaKk4jo1j29NgTk/9OCtytYxC9gJNpYkwshT8vGMBfMKf1VKhHIThJmqkWBK6afM oja/SVcp zCQrR5HsQB1Jhn4imcmjx233A18oOwYTbSe4C6xqcNkPBEY74Wnf1Fxw6YhBz9+fwwkNDGwGPZjwcmjL0d+HI5SmNbHiNj1hkChqoJoasU/5GTE/ealSZlI6oCKVZrVnKW8RcV2apP66O8Hc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/01/22 14:57), Sergey Senozhatsky wrote: > > - for (index = 0; index < num_pages; index++) > - spin_lock_init(&zram->table[index].lock); > + for (index = 0; index < num_ents; index++) > + init_rwsem(&zram->locks[index].lock); Curious if lockdep trick [1] is needed here. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/fs/kernfs/file.c?id=16b52bbee482