From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE7BC02181 for ; Fri, 24 Jan 2025 09:40:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75082280046; Fri, 24 Jan 2025 04:40:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7013D280045; Fri, 24 Jan 2025 04:40:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CADF280046; Fri, 24 Jan 2025 04:40:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3C602280045 for ; Fri, 24 Jan 2025 04:40:02 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EC25B16101E for ; Fri, 24 Jan 2025 09:40:01 +0000 (UTC) X-FDA: 83041849002.17.FB7A129 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf07.hostedemail.com (Postfix) with ESMTP id 9DC864000E for ; Fri, 24 Jan 2025 09:39:59 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=D3Gn9Kkw; spf=pass (imf07.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737711599; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=euSSqRsocsBLpT+sD8KiFSTkI0r7D+UF7rQijaSe/GE=; b=tHLdmOYS2XidbFwZAj2CboLbwX1TkTWSUETE0mqM9bsLY7qsoLefnp7t2D+MyOD6pzWR+4 06uxPmmBwi4dd9nwcQUOqiv5gyhrAlKR6KBOUhcfmKWm8e7BxRLy2WDFK/oq4lzMOwB0zk KkXCkGLk+V6WIoFiVIOwkiv5e0hHFwg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737711599; a=rsa-sha256; cv=none; b=xW3I2UlJb31AxW2jEZMxG/UmFnpNuLKlZnrzaCsIBEerGSotEFa9+n71G+N7hxullM92Zh 3x+IJEOOtdC6oGecgcwLUIV6P/QoKJqiUEazJBWB/cRbrPR42cFkBJYUDA5ex875cah0gY j4xxi4QNLkhuR6dSFBc72cgPP3QbKYk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=D3Gn9Kkw; spf=pass (imf07.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50O7Gevh019218; Fri, 24 Jan 2025 09:39:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=euSSqRsocsBLpT+sD8KiFSTkI0r7D+ UF7rQijaSe/GE=; b=D3Gn9KkwBtburx1wZdIJ5U5VPTtF5A4c4rzkUJlaIlbcuG id5ajLAgzFSdwwvrDVqlQTLyYJjlnMfHkrQznOtaZVlHDMEtzUQUo4kv63SZOjee TK+cQvv9iy863vf5XxJAJbTPy495kcyTUwOx6OQHW2btlE+naOSW8+pjNFCfHS/J i0I2auV5FYNjdhcKURsadLiSVYy07OKfRJswnA8Hhh2IcPOZJrq7UY3bJhNiDpgN wlkSdPHsPcjvr7Px0qNw1YqmukNtJ3J8J/mZa3qCWeT9OTP4crjnIFZ4fJm+hgw1 7cqjvPuLFuxB0QorQ5p4eLfN+/cNbNyR99AQtdQQ== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44c0x92y4d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jan 2025 09:39:45 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50O80S1Q029587; Fri, 24 Jan 2025 09:39:44 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 448qmntt1x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jan 2025 09:39:44 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50O9deth58130882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Jan 2025 09:39:40 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 82EF220154; Fri, 24 Jan 2025 09:39:40 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1077B20153; Fri, 24 Jan 2025 09:39:40 +0000 (GMT) Received: from osiris (unknown [9.171.14.46]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 24 Jan 2025 09:39:39 +0000 (GMT) Date: Fri, 24 Jan 2025 10:39:38 +0100 From: Heiko Carstens To: Heiko Carstens Cc: Kevin Brodsky , Alexander Gordeev , Qi Zheng , Gerald Schaefer , linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH] s390/mm: Add missing ctor/dtor on page table upgrade Message-ID: <20250124093938.19507-B-hca@linux.ibm.com> References: <20250123160349.200154-1-agordeev@linux.ibm.com> <20250124092917.19507-A-hca@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250124092917.19507-A-hca@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: oubK88tcqYsjSNeyzN7iYN_w5akgJ703 X-Proofpoint-ORIG-GUID: oubK88tcqYsjSNeyzN7iYN_w5akgJ703 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-24_03,2025-01-23_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 mlxlogscore=291 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501240068 X-Stat-Signature: zixe57rh5tcsx7pmstsqj3kenmn9ycpo X-Rspamd-Queue-Id: 9DC864000E X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1737711599-28376 X-HE-Meta: U2FsdGVkX18g1ea+AMgQ95M4uBb6NugKIedvC3wIgCkDDrqjYfV4EqeTSXBfccsxkqfDWDj/SpC5PT3QVVCGP1IGDi4+iHRla00fODptHWGoHw6A/2IaqNDh95nDCQ/fDb/V+EazMt887s6CrNK4/8385qMvbXscGbJ8NJZf6RX7TOi7XraPPyWge90+73hZVSIMpO4AISw2Lq7XticfABuA+D09D88k+hHyqUC8UaWAnbuQ6YUbKtXQnN05u0A3zMTVPxUD2OHX1TOclqRfDv/L2w5ZQnk72hR8xu8d6E7tRCuh77zpCPTOQA3bDZflwlXaJb2ipxk+NSBl8pXKrReIKVWcElCdaedGwJgA762aF56kZCLGYrC1x9FsIB6nZnWL8tIULxUNA0ZJlpVmyiubURvkrbxB3a//OHDpq71Hr7bIwELx0pWmm/MsnpvSiVrwGIhicKv2qaFMFVFmEDkZ48KvxH/B6UxVH7UXlu9x3rrCLcTJ5jGyl2xIfZ2JKObjH+vvhYuEeLWkhFnVRVbCQYMrrYgPR6sR+6Uom1N0DIEXq/Y/cdynU7GRe0rHtsHZj8Xu5nhKXjdrgi5+0IKBgBWdlbASuguX7VNBjn5sCwuAES1XQptWdcWmF8ycZRpXp3swVOmVrVk78VdVoRL48DdFP15TgkUDUQAiWPojr3cDCNly84ICaOxlJH2XreOrrqfbUhXt+cHk6J68h1rJDw8YKfyIW/1JCnSGIb5dkN30XvJH8ZxlUl7jhfgX4QXcxIZazTB86RPD22HVaysMYalCJDSdvrO6mYjxpW/GfvmlRiVLLL4NzzHHSWh0Mvpl4S0Akq1ohHRzYNzy7j3ATS8bPxEx44pExIA85AWYyKVtP8N+LJsdzll0MkjxMNIC+O6nGqK4JmsQdl0YrJrp/lA5mS3MBMRYsS8qeNc0HClCjVRng76Np0yFU7zNF9sCJlWF9Gzz3jW/qgo wvjkRMLT 1JpbrWrH73UtdQGPyEKDZ0s0sVhiEaP0cLmoSCkBF5hM2Ku+tP5da1OwaqFKO/kmlbta6CwNTbb8KZF+flddSOGfwq9kqTcRJwsCnQFhEVK2I5UuuEPDLxp7RS/1k+ImCKA7KHXdNHtGibrYUEULfeEZRMsOG+MwcY5Tk3584uwlI8P9EaeSx6RhogZoiDkvqlzu1fWjuv/zNIbErBVCbOqA34QbHFKVNuUMQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000059, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 24, 2025 at 10:29:17AM +0100, Heiko Carstens wrote: > On Fri, Jan 24, 2025 at 08:58:07AM +0100, Kevin Brodsky wrote: > In addition, looking at [1] where page table accounting was introduced: it > is really meant to reflect the memory consumption used by page tables. This > might work for nearly all architectures which have the same page table size > for every level; but on s390 the lowest level comes with 4kb page tables > while all other levels come with 16kb page tables. > > Therefore at least on s390 you really can't tell how much memory is > consumed by page tables by only looking at nr_page_table_pages. It _might_ > make sense to introduce a factor of four for page table accounting for > higher levels, so those numbers make at least some sense; but not sure > about that. Ah, this is actually not true at all, since we have static inline void __lruvec_stat_add_folio(struct folio *folio, enum node_stat_item idx) { __lruvec_stat_mod_folio(folio, idx, folio_nr_pages(folio)); } which will do exactly what we want. So this part is not a problem.