From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AB3AC02181 for ; Fri, 24 Jan 2025 09:04:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABA306B009D; Fri, 24 Jan 2025 04:04:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A6AA86B009E; Fri, 24 Jan 2025 04:04:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9594C6B00A1; Fri, 24 Jan 2025 04:04:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7B35A6B009D for ; Fri, 24 Jan 2025 04:04:36 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1000FA0F76 for ; Fri, 24 Jan 2025 09:04:36 +0000 (UTC) X-FDA: 83041759752.27.515F762 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 3A8264000C for ; Fri, 24 Jan 2025 09:04:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GMoPNTxh; dmarc=none; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737709474; a=rsa-sha256; cv=none; b=DZrn4LsY+bM0f6gdMbxp4swb1Zfu0q5uZpZrnKi5zT3BrMc6lS04LjNV+svALswvBJRa0D gfRKXb+pnAsZcqmd03gLCw+6usXWPWgQrcFKC5zfisWJfVvu8SBgF08KY/0uuPrtIEPXBR +WaNm0x7+8nOoxksyiepR392Fwg0cr8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GMoPNTxh; dmarc=none; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737709474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/+M5Ubh5p8DlqI6wZwc5gaFWz2GtMxNLGDwH0dogozY=; b=HpVuC75MgAAIaVQUKVOf3Ir7K+LtkqCB8PdC9ihItmAFYKi9QIrmVERJh/rWfKqrwudYSv O95CFw2SjZC87qTLWEPODAMSDatbN0zQCPUNmzI21mrZZaj3UrUclHrxyzeg1NPzK/uUIG IPqDbfdGFCxDL9I4bqLH4TFGjaQUNyE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/+M5Ubh5p8DlqI6wZwc5gaFWz2GtMxNLGDwH0dogozY=; b=GMoPNTxhr/YokXcKKjTQyIc+eh 2qh1YFGLccsKNzCDmVLy1f7veNKJABJyovmOjx8po0PfpHIfg6gAmLiWeUhEZi2YMETVnHjCOIBLp aoed7lxLwExrJt6rIEGhKQXQt9qyZlsqIcDHctPUc9GdBWp6ZPQuiG41HVDuP5WqQUDRE+yiuFfEh pDLUrMW/BFeWruqC599mHvbhrXB2rflZeT+ThdB+eE/dKQM0uxraFBZay1AlZTl/eeGWjbloFna4/ ibt0WCkrzrOj2tCiWzgY58ff0Vcs6aKYv3McG3FBdfBcrTlRzkpwwhMtTfvX0H6v4njJTuWisC72b Ujgly4Pw==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tbFc7-0000000EhjW-2qWi; Fri, 24 Jan 2025 09:04:31 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 12FEB300619; Fri, 24 Jan 2025 10:04:31 +0100 (CET) Date: Fri, 24 Jan 2025 10:04:31 +0100 From: Peter Zijlstra To: Hugh Dickins Cc: Jann Horn , Roman Gushchin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , linux-arch@vger.kernel.org Subject: Re: [PATCH v2] mmu_gather: move tlb flush for VM_PFNMAP/VM_MIXEDMAP vmas into free_pgtables() Message-ID: <20250124090431.GA3861@noisy.programming.kicks-ass.net> References: <20250122232716.1321171-1-roman.gushchin@linux.dev> <20250123214531.GA969@noisy.programming.kicks-ass.net> <26cd41c2-b8b6-0c1d-c36d-28f2f9f369be@google.com> <20250124083139.GB13226@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250124083139.GB13226@noisy.programming.kicks-ass.net> X-Rspam-User: X-Rspamd-Queue-Id: 3A8264000C X-Rspamd-Server: rspam10 X-Stat-Signature: hdss9o7b44mem9azxcot4y9fg3i9dbpq X-HE-Tag: 1737709473-218452 X-HE-Meta: U2FsdGVkX1+mTn6oq3YqADea2xyzDmg9Vt2TRyAJnAxaJvRNCqGmyLghIRS/BQ2/A8zmG3Z8kZM4WRpIwikfCuGO8RESwpIc3TnmcJajGxfQ6Q1jfwk45hAfVcOg7nSZqn7fol6I9gvF0OUZQ5IUKoq+WjnT6v8eUT/+Sh82wzzuwG6s0ymA9ua8r4MJrZYQOUPGs/YW1To+3IFBhtZSJb9phpGe4saQtxZMWbm91OmeD8bo7L2QJ3xvUq8rp1yHS9xXn9Hcad1rtzUV6XktGKD9CpexmjAf6zgDdLK8fK6Kx90oK6X5mkOkXqPM++L0NBvuf3whxjDg3nEZC4ZXuSpX4rk3Y0KNd9C9be2DwRO9Zdz2wvMkA/K3Y5aY4VWBIK8gpYC/IoaiucVAgtUqXkQibffIeh5QxRF62W3ic7k7+N97z+EgsIkP4EhKfKHRXGYHlCc5sX2gnTrlVeOkE5zuuIAuYwpqVEqYfPNHsqw86uRw5NkDmK6jbyRPlzvOjw/2t34THSmlchk8c+vZkHnDxqwl3d3bt/UoR1OaNyvYHCP5sqYPa5LETkp2g33bFstUzELrlB5xPoaGlqAxilKjz55cBynZPnpdOqH9gvf1S8Nn0kzI9sPlMtGpUjruZel0xPneQMczON5iV13coT2VHc2IL89IlUarQf516XlKkGmUfSeMVDIHv72o+Ict/dtx14FX8ZinDp5SFUHXR86zn90qmYc1ZCGeh1qBEkQynpJSjSn8RCRlY69s6S95/8bylGLwiglTB/aXJgNMyJ6ukZWlZOTQIjKEUT7BApaBnjEwPSxjZtqoswXfGzAZhGxl6lnWpRdThWh7rhW4NiouQhyjEf33pSxJf/8SS4mCWKAYRbztwFHWjFMPp4hPkvtYcT1sR4muHGver/M7rN+7pSlvsF27uWkWUuEs1vxVCtvC0WN0pvDydi5N7ZRFc8qzTkhIzOt8G2bcjA3 3IMp7Do+ sUNpIoUA28FBASWtHJAg2MFStKE6tTfVpvMdMsIRHOPr9f40Iw4/ZSCCl/hkUCMMxd/cZ+jpn30hiY2qpR5xhvHwD9FEDaShO1fLDzpjcIgfRz61SCsONrUhO+eb7tEZ2zzQYPh81jirDgLZtdvnOX0ZrjJsx0rmgLyAqJUD+XUznYyySrp+wOirg2Gka+2BzHtmkxQQeRkZ3DUA6hdb7gpgOY4HZpgIrjIsVx7pnGwI16EIy6y5IATf+u89mxg2alDC9Rd8czL/crmA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 24, 2025 at 09:31:39AM +0100, Peter Zijlstra wrote: > On Thu, Jan 23, 2025 at 08:42:36PM -0800, Hugh Dickins wrote: > > The changelog of commit b67fbebd4cf9 ("mmu_gather: Force tlb-flush > > VM_PFNMAP vmas") has not helped me either. Nor could I locate any > > discussion (Jann, Linus, Peter, Will?) that led up to it. > > Hmm, that was probably on security -- I should have those mails around > somewhere, I'll see if I can dig them up. Hugh, I've bounced you a copy of Jann's original report on the issue. Subject: unmap_mapping_range() race with munmap() on VM_PFNMAP mappings leads to stale TLB entry