linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Hugh Dickins <hughd@google.com>
Cc: Jann Horn <jannh@google.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Will Deacon <will@kernel.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
	Nick Piggin <npiggin@gmail.com>,
	linux-arch@vger.kernel.org
Subject: Re: [PATCH v2] mmu_gather: move tlb flush for VM_PFNMAP/VM_MIXEDMAP vmas into free_pgtables()
Date: Fri, 24 Jan 2025 10:04:31 +0100	[thread overview]
Message-ID: <20250124090431.GA3861@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250124083139.GB13226@noisy.programming.kicks-ass.net>

On Fri, Jan 24, 2025 at 09:31:39AM +0100, Peter Zijlstra wrote:
> On Thu, Jan 23, 2025 at 08:42:36PM -0800, Hugh Dickins wrote:
> > The changelog of commit b67fbebd4cf9 ("mmu_gather: Force tlb-flush
> > VM_PFNMAP vmas") has not helped me either.  Nor could I locate any
> > discussion (Jann, Linus, Peter, Will?) that led up to it.
> 
> Hmm, that was probably on security -- I should have those mails around
> somewhere, I'll see if I can dig them up.

Hugh, I've bounced you a copy of Jann's original report on the issue.

Subject: unmap_mapping_range() race with munmap() on VM_PFNMAP mappings leads to stale TLB entry


  reply	other threads:[~2025-01-24  9:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22 23:27 Roman Gushchin
2025-01-23  7:42 ` Hugh Dickins
2025-01-23  8:06   ` Hugh Dickins
2025-01-23 16:45   ` Roman Gushchin
2025-01-23 21:45 ` Peter Zijlstra
2025-01-23 23:12   ` Roman Gushchin
2025-01-24  4:42     ` Hugh Dickins
2025-01-24  8:31       ` Peter Zijlstra
2025-01-24  9:04         ` Peter Zijlstra [this message]
2025-01-27  2:34         ` Hugh Dickins
2025-01-27  9:53           ` Peter Zijlstra
2025-01-24  8:22     ` Peter Zijlstra
2025-01-25  1:23       ` Roman Gushchin
2025-01-27 10:03         ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250124090431.GA3861@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@kernel.org \
    --cc=hughd@google.com \
    --cc=jannh@google.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@gmail.com \
    --cc=roman.gushchin@linux.dev \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox