From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1721C02182 for ; Fri, 24 Jan 2025 01:44:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E986280028; Thu, 23 Jan 2025 20:44:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09A89280026; Thu, 23 Jan 2025 20:44:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA341280028; Thu, 23 Jan 2025 20:44:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CB9E5280026 for ; Thu, 23 Jan 2025 20:44:03 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 59D8C80A55 for ; Fri, 24 Jan 2025 01:44:03 +0000 (UTC) X-FDA: 83040649566.20.0187E50 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf17.hostedemail.com (Postfix) with ESMTP id 5968440014 for ; Fri, 24 Jan 2025 01:44:01 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ic+SALmC; spf=pass (imf17.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737683041; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J3ZX9c0FgVF0V5U4F94DpD+Pw8yKgfgQD5h+O/mGFh8=; b=aUqcrgUZjXuU0LC4+w3hGN827maF3XYmQusy4Y1fXWEZ/wOIIyoHuXTrCfh1wup90Vz5hX NBYRJd9qXvIf/7TiNBFkAZ7EceO2wJy8MBYvuQzwKBpaE412H/JFueg+yo1zuK1YPCSKeU ha3OmXiGypRgBwdVxEiNZuGW2TN9iKE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737683041; a=rsa-sha256; cv=none; b=rAnBQW0vfKU7e7uOp11UpAD657zblumljnUW2enjg8RY3taKHTEMWi47/73ITLncWG6iho NveYylP2kK0fZDfMwcAC91eBAgtGiJEyFVFx1rp8xcUzjlywHCsRtOmYffn+jzJSxOaFSw LaaMEtY0CBtC58myFvydlewsAzd9chg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ic+SALmC; spf=pass (imf17.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a9e44654ae3so262188966b.1 for ; Thu, 23 Jan 2025 17:44:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737683040; x=1738287840; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=J3ZX9c0FgVF0V5U4F94DpD+Pw8yKgfgQD5h+O/mGFh8=; b=ic+SALmC45HEIOKeM4/EiZdCzGLGafQF0quVPopZRzIg19vCO/5vuSlahTWzuVucPY h4RaSTTOE+8ot3b3SIxSsUTFrQnzRl7nrQfwVkh5g+zjlH3pOazWyqA8oU/XHaqPUPuH bTJAodjUe+WoSBjJTW90Cue1M+OwJlO3Dfl5YSgq6dyvHEPlybtt1eUzwxPtkX02H3pU YrUAW9FV+Nro8tC4oKsC5a482AHQ/VfweIRRB/YcVplTJ4G20pW9dU29LHCUIwmGkFfK dE0+rwVODkPoxO9TaX3uj5PVi76AUrB727Ubp6Qq3SF+tDHRbCLI95lj/mrvbl7w8yF5 AapA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737683040; x=1738287840; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=J3ZX9c0FgVF0V5U4F94DpD+Pw8yKgfgQD5h+O/mGFh8=; b=Rymc1tvQqv1NeitUgtu+ya8ess3my7YV8LM0iQm5r9HmyF3kNybJcPHkzqvMqJ03VM HTLKS5mi+88EhOI9QCZ3UmhWsnzkuuiZCWsJ9N/oQZ/675FbWkEGxGehauyDDesDi7Ne eEr0EXTvwP3LHPDz9Gl7vtft4H3Rpc29cwj0/JeEyNp2aTO1lYktX2776trXTOW3Xf0h Afkl+yiU7Cg8KxXZzXYXfYLQ9K77wcl/uJF2FogwUjV+aULrk4aMKEP0Luy2wxMvJdnW kREbMMnHdHGimsMkReOcz6vQcde5KOIJI2gz35iuSFsTBs0OQ9GjguDjpTGYgLxR/2yv WJDA== X-Forwarded-Encrypted: i=1; AJvYcCVCmSEvMiTplmOiVB8p5Sy2xI/zZv4TkPMkZr44+X2HWI2ulVgMN9Fz/BUhyovVmz4RgmeSCZR/5w==@kvack.org X-Gm-Message-State: AOJu0YxUCy1yFzYOWkyVxpdo/jEb+xBKrtbYD82UKGSY+nv13JI24n43 aU7oZcgwte00KhCkrGX+xyeCuaxQKHSNPeJr0DhZ6j54zKEDRFFU X-Gm-Gg: ASbGncvEsYGQoBxlBFgpp3cNVXIQrUAeDNMGfO7AK7vTmOQ6E5+KyThYUxCeXULEWVK 4ecOildOrpcQ687qSXbkX0//oxQ6/SN9KpUxYjHITEWs64xpa1ELq8Nw7MDXFSwa3d4kHqsTwUI 4ySm/rCOzOT0gRZ0DGMmtXvm1LG2LaRicmi0gM8kKTH7J0d88ILlBmYqCWQq+4iu52YbRQ2tQ05 2zBvZkMWo+wsFJ3RgM7vDPkX/BT56yl/5sMY2NmvqR9z4eUwItIChF9O7YYtPfMnMCMGIkbHyBR gpzD X-Google-Smtp-Source: AGHT+IFoqyTaBRJqakrW7bN/qw8LMy8iwmo7supgrqJ3CkSSPVTo5dvrHDKriR5dFxTcB0dtWEdSoA== X-Received: by 2002:a17:906:7315:b0:aa6:6c46:7ca1 with SMTP id a640c23a62f3a-ab38b0b807amr2848198066b.10.1737683039430; Thu, 23 Jan 2025 17:43:59 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab675e1367csm45770866b.16.2025.01.23.17.43.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Jan 2025 17:43:57 -0800 (PST) Date: Fri, 24 Jan 2025 01:43:56 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 0/7] spanning write related cleanup Message-ID: <20250124013412.2vpf7davx63s377d@master> Reply-To: Wei Yang References: <20241127012753.3393-1-richard.weiyang@gmail.com> <20250117054942.w6vgrllnaasjaww3@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: ip34am4bjbowzg1m3yhnug3pkrq8u843 X-Rspamd-Queue-Id: 5968440014 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1737683041-896142 X-HE-Meta: U2FsdGVkX18xlN/xBzNqhj88SK1B2y3K7A9Z9vrC/ZhD4NRm/rljks9B19hNyK+g0olKrHfS6vNT8fB+1UoAiNHfgiJCNxNJ1TTJORl3uYjCnYhgZtujgiwZG7sXzhWF1pYrirDXC3wkuGAt1jGczjR7obEtnL3c/GcXIHdzsxrb9YVhXbr8iW0bnywf69oarjQOjFNdClyphS/b+RSFgxgXTLgtrrBeQQbUI8mjq301QSYi3QpVFtln4m+LazhefYE0LRsYSRgAJHkDdjYYPlACqZbu7b8d/hQw1HyxXk13OXtSCceLXPkVi9Ety8MR0dHI1q1MTSQee1n8uvqND5wsrZjknJXsstL0fg1HQw1elB5qeme2VaqAy+6usSsEGgFeZBhapsXccmg0ndUHO1M/lFbd1synrDHJvo6t1a+npL/arT0JUY4luTU9851Yho3TiMW3OC+SvXXDDIcHqrm/UXYJP7W4V+T8dvb6IO+oc9NV5bs/SGyTsLLCzT/Tw/W/xhBQAcV0goAX6TQ/9jkkFRXU0+hffqR0HcbixSIfq/SbVyQIIp1OKy1TcGdatYEILRPqe2wUE7uyecOr5+P7U+IXsuAH3ySA8M6+y3WBpxd0Z7vaMnqwUta4gMO0T+9zxlUnINv+08xNKGLyIG46lgNI8//5qjV1IFPcFkFTJOPA1kvmP7J3SgaN94mpM7n7xqgDMo1Zrqb69k/vhHddp+VAE7u0LqdcEzjGDbQ4v6ppN/EXCAy24DMgxIpcjS9XD5Csl+DSOY24fRiFiJPzAFKg4/3N7aY6NzISo2LisLPWPvFWBOVjUamjjsCroeMCEW0MpPGOWFtzmQ4xN8KaVQKfQ4ObxB3YOJlyKOM+CChkLHZHddG4kxA4W2k8PIVnt6dgBilJVFh36m271u1fPzMh8tISxJTGdD5GiRob9UPUxa0Y2OSulog6SEk2Ui5Gbj8tFyW67gkZ0UJ /gzzNFjB ZO/Xzz5nrQL5xO7fUd4jdN+1+7YXRH9aGkSvEAdd7yLfny4W/ljIdLjYBRAYWXyFh4D7j94WHa1QKcCilkcpJGAgg4fx3oZL9Wh5aRXNum8gocjyTKOWL0yPmYc/rbbhNWneai6wtAffSLGsrrZg+w6HkigPHgMEgPHArHFOabsL9Cqt0jtsMVwDE36NB4Y2J5UQGK8/Pq2XhExoHHFTWZsKFtWtsMY9PlOWjKRaUDUxeOZxgdwRxNLEClyVd1oYijXt8c1cEbsuzQ3tURjPdPgF/e6NgOv4Vyo7XEpWwjxCuaCfOW+spxtjzY+wHB4tmFgor+ZtNuaSVnHxV81kNiVCaafsAc4AKsHla6ktD88AQR+dKdPUFjxrmSmQ41XTH4sXsvYh26A6d2u+dJ/5b1yAzHxYVu0saIf2E/dKEUsGuCITkb5IJBxKYlqXOFdrBLl8WlA0hbdbgOwamma1Et+OD1Jys8oFQ9U+RygfOra+XhxEtngE65KiLho7AsiEo29PJbqhV+yW0CiswoEezR+Mn8ZtJ/EGJ0fObcsGlEsos9kcTPKa3+4oFxRDPO3Ngqp7F3T7FmxCoPhJVUrjde5ajjC9jGStNAb6AzVTJrDeyztpljy4WgCJYShrJi5px/q1ZhgWX+sQ3Hr4+QiWWI6oMm0ErKho3ZuDXHVefV0U71RE5Ri7thV1hZT+HI7XuuQkz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000449, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 23, 2025 at 12:52:40PM -0500, Liam R. Howlett wrote: >* Wei Yang [250117 00:49]: >> On Wed, Nov 27, 2024 at 08:31:13AM -0500, Liam R. Howlett wrote: >> >* Wei Yang [241126 20:28]: >> >> Here is some cleanup related to spanning write. >> > >> >None of these fix anything, but do fiddle with code that's pretty >> >critical to the kernel. Most of the changes will be immeasurable in >> >change but carry risk to causing subtle changes. >> > >> >Some are simple removal of returns that aren't used while others change >> >things because you think they are probably the equivalent. This seems >> >like unnecessary chrun at this point. I'm all for efficient code but >> >this is getting a bit much, some of these are just preference of what to >> >use that will already exist in the cpu cache. >> > >> >I'll get back to you when I dig through them, as some need a deeper look >> >for sure. >> > >> >Liam >> > >> >> Hi, Liam >> >> Would you mind taking a look when you have time? > >Yes, I'll have a look soon. I don't love changes that dive deep into >complex code that results in no gains (performance or feature wise). > >It's also odd to have simple "this return isn't use" and things moving >code blocks to be executed only in certain scenarios, as the difficulty >to verify the latter is much higher. > >Can we please limit changes to areas where there is a performance change >or coupled with a change that is needed? ie: stop sending patches that >change things unless it's with a feature or improvement (performance or >otherwise). I'm just not convinced some of these are worth the >cost vs risk. > Ok. So you would drop this patch set or still want to take a look? >Thanks, >Liam -- Wei Yang Help you, Help me