From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF57BC02182 for ; Thu, 23 Jan 2025 07:00:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D7E66B007B; Thu, 23 Jan 2025 02:00:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 188176B0082; Thu, 23 Jan 2025 02:00:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04F016B0083; Thu, 23 Jan 2025 02:00:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DB2A36B007B for ; Thu, 23 Jan 2025 02:00:13 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 47AD2140C4C for ; Thu, 23 Jan 2025 07:00:13 +0000 (UTC) X-FDA: 83037817506.20.EE704FC Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf21.hostedemail.com (Postfix) with ESMTP id 04F701C0003 for ; Thu, 23 Jan 2025 07:00:09 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jjSZ81Ui; spf=pass (imf21.hostedemail.com: domain of lkp@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737615611; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=jtSIu7jO1aiM52RP0IAu1mTyONeRUuGVZEehTj7K7rM=; b=DJ2htD34nVAZLmArvf+D4GObKPMiI8O2nPjikcGoXU4HdwirQyiTb8oHRXMeNR5FwdrJWK qjb/iBOz5ClWz1P0lh5ZPUzJfF1ivYzrpVecjzh8A2NGq6WB+Hg0P4xBNHPd7euguWAqS1 CmMFv2ATUp/ai9Woh3MW5Bi5KwBSnUQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jjSZ81Ui; spf=pass (imf21.hostedemail.com: domain of lkp@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737615611; a=rsa-sha256; cv=none; b=EPj8klVj5jeNsaFmaJm8i0iLNXnM1kiToC69vpRUpAo2dLA+U7a9TUq8buZM+FL28aFmpE teoCf4hdpaq//530boJniFONSlGVkIkHHdMs5zsybwn1EPRPr6emj8OL8kYEGknsVU78Kl B7yJUGymPAVYxpVbTHVYW8grqulVJRc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737615610; x=1769151610; h=date:from:to:cc:subject:message-id:mime-version; bh=kS4RzeOpRXl6IG+eqBVepRaT+klnaSo0/a4onyerHaA=; b=jjSZ81UiBmHoEYvT476LyA/gZ/OvLwU3tEJcQO8wxvnTjzB4k+lvZkfD V6SPIsNqehRYbLbaRHhpvvdqHdZgBaYWlA5eruDQR+XDM6Sm2Jjrocvo/ kitCQ/RrEvbnj5Up6rHPgxC0On16+Go4fYencczffPRFnjWhzBS6CDYp/ ahCCd73uyPHTQ3Jo5yQiWB+8d2jsJcVb547lSKCIWUWpfhSiLa6KlqE7L 9+7CkjuAkw2K9YcnG8xjoyjYRe2ggQkNOnKsfsD8c3Nl5gjpq/QGXJaUn oSC1pfK40sDXz/RRe/KsxIdRvoW9ZtPkTENdbly4eORYerBB+F781eacm g==; X-CSE-ConnectionGUID: GlIvO2D2SHSAaV5LeNBqtQ== X-CSE-MsgGUID: b2OxhIK+RIq4e6F49oDYeg== X-IronPort-AV: E=McAfee;i="6700,10204,11323"; a="63450310" X-IronPort-AV: E=Sophos;i="6.13,227,1732608000"; d="scan'208";a="63450310" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2025 23:00:08 -0800 X-CSE-ConnectionGUID: WSC3ra2tSzGFjx+kP5enmw== X-CSE-MsgGUID: t7l2Fz9ySI+SMoSbDFSSuw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="112343451" Received: from lkp-server01.sh.intel.com (HELO d63d4d77d921) ([10.239.97.150]) by orviesa003.jf.intel.com with ESMTP; 22 Jan 2025 23:00:06 -0800 Received: from kbuild by d63d4d77d921 with local (Exim 4.96) (envelope-from ) id 1tarC7-000arG-2u; Thu, 23 Jan 2025 07:00:03 +0000 Date: Thu, 23 Jan 2025 14:59:41 +0800 From: kernel test robot To: Randy Dunlap Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: drivers/base/power/runtime.c:362: warning: Excess function parameter 'dev' description in '__rpm_callback' Message-ID: <202501231452.84vwjQqo-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: 04F701C0003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: q31daaio35p7gxgehsqapxd5ibzjxfq9 X-HE-Tag: 1737615609-613963 X-HE-Meta: U2FsdGVkX18womp29P2OSe5exrTnTUmo/A/sRn9/YBZh1cxwVK6cXc7BD49m3vfTj+3F6YU7O6t9h6cwgAWT41KG2u9l3zh8fLzoEFY8W0lewIES8spV0+rGjzu3wgXcQqtNrW+0evBoNVGiiebFUh+5G6KYXOg8fpzk9j2FKFG47aD87mOtFCemnlF+wQ8S4KRhQBYbOmYu6BeT7zCFpIlmUF9Zp34DKhFv+RDkV+2d3j32Vc+spqX2hHsEhPydY3w+Y4mFvboA1huK5QatP4NeV39W5g3bcSFqmjtY4079EzW/oXg/971lpjr5Dzy3US1jbbq37vasZPLLVBWQ89UifbX3A3rjQvSan1CpZsVD1fzltassrmNuYKs9UD13iI7yAXm9AjnhVQhZC/59EA4QV8ILQuZAWzIJWVgHv8jZQbm/LT7gH3Fx4HpcKbLAV9TEDwCAv829mkgSorkjVKT4CIHsEGtteKBH9pC74zNEJBymxZBJDUfGmiyHF5eWQ4KREXI/nyNpUSOuLyxM5X20PHXbdU2xeQE81mvtiDm7c3+R9deodX9NhP0zCAyyszCChRnGgaa8CV//GRl77PBfRzQLgRIE2aGi9vlQ5XDGB8JJe7usktIpe6r2Q6Ih7GENoT8P2IHKv9CEHFQqCPhA0q729bvKXW+u7Be4gGFqQowUkeFj8sfILMdDxg9rM4chISU9cCIuilSsDX68ga6TX9i/KHhZup0IbFtQ6sTZS5CyN8MP6n9qSaqUP4K/WKFCe6jV4axLdX865b7Zg7IOrl5TFQFDA3CcuFqKfknQkjNaOiVDBuGW21jUJMNtL27F3FUjbALiTnRpToF3nCQLXR3Z74b/uvQQn2x8j8lwqknjU6PhQSaUy9C0KHU4GmedZMA1G5PKvuKXGP61YeIDfsaA/eEp4eImdI4mLtSKi5cd0rJTFkYCu2ITlQ7dzCNGmm7js9o2HTCD1j2 xCs06VKd gGdpvwMrON4sepMIdf73/aUe8E5ZSycwMi8C+5XDwD9qR+sipm4Wn2HCWSP+6NxVlj1l4frYBhZcB5oRygO0OTYKEG5GTO/BuxiVdLAH4+x37i+n6gmiyry8fXW73SBNLTKaKDKO8xWVITIvjrM8tLb5OaihLAjWBhWPUkaxoQNMU+fBUWeLlZn2dVLMrvFz2Zf9+ohdO2xcDcFIA5Zj/C25yEKW1l3Y8fTWBV7fWWHFxRcjGoQR5WqV1gOM8iVFSCWbfWPVdgkMQSwLG+EJCmC0K6GH7Wv5LthDon/9YPexcJB6mucmVE7nOhq4EUOv9BgwwuaVVcjSk0IcKrbSIL978WkLvPV10YcKlSEKFB5it77SGD5UjbiWRsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 21266b8df5224c4f677acf9f353eecc9094731f0 commit: 7be6a87c2473957090995b7eb541e31d57a2c801 sparc: allow PM configs for sparc32 COMPILE_TEST date: 1 year, 11 months ago config: sparc-randconfig-r032-20230416 (https://download.01.org/0day-ci/archive/20250123/202501231452.84vwjQqo-lkp@intel.com/config) compiler: sparc-linux-gcc (GCC) 12.4.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250123/202501231452.84vwjQqo-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202501231452.84vwjQqo-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/base/power/runtime.c:362: warning: Excess function parameter 'dev' description in '__rpm_callback' vim +362 drivers/base/power/runtime.c 21d5c57b372616 Rafael J. Wysocki 2016-10-30 354 ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 355 /** ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 356 * __rpm_callback - Run a given runtime PM callback for a given device. ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 357 * @cb: Runtime PM callback to run. ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 358 * @dev: Device to run the callback for. ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 359 */ ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 360 static int __rpm_callback(int (*cb)(struct device *), struct device *dev) ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 361 __releases(&dev->power.lock) __acquires(&dev->power.lock) ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 @362 { 63d00be69348fd Ulf Hansson 2021-06-08 363 int retval = 0, idx; 0cab893f409c53 Rafael J. Wysocki 2021-03-19 364 bool use_links = dev->power.links_count > 0; ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 365 21d5c57b372616 Rafael J. Wysocki 2016-10-30 366 if (dev->power.irq_safe) { ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 367 spin_unlock(&dev->power.lock); 21d5c57b372616 Rafael J. Wysocki 2016-10-30 368 } else { ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 369 spin_unlock_irq(&dev->power.lock); ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 370 0cab893f409c53 Rafael J. Wysocki 2021-03-19 371 /* 0cab893f409c53 Rafael J. Wysocki 2021-03-19 372 * Resume suppliers if necessary. 0cab893f409c53 Rafael J. Wysocki 2021-03-19 373 * 0cab893f409c53 Rafael J. Wysocki 2021-03-19 374 * The device's runtime PM status cannot change until this 0cab893f409c53 Rafael J. Wysocki 2021-03-19 375 * routine returns, so it is safe to read the status outside of 0cab893f409c53 Rafael J. Wysocki 2021-03-19 376 * the lock. 0cab893f409c53 Rafael J. Wysocki 2021-03-19 377 */ 0cab893f409c53 Rafael J. Wysocki 2021-03-19 378 if (use_links && dev->power.runtime_status == RPM_RESUMING) { 21d5c57b372616 Rafael J. Wysocki 2016-10-30 379 idx = device_links_read_lock(); 21d5c57b372616 Rafael J. Wysocki 2016-10-30 380 21d5c57b372616 Rafael J. Wysocki 2016-10-30 381 retval = rpm_get_suppliers(dev); 5244f5e2d80125 Rafael J. Wysocki 2021-03-19 382 if (retval) { 5244f5e2d80125 Rafael J. Wysocki 2021-03-19 383 rpm_put_suppliers(dev); 21d5c57b372616 Rafael J. Wysocki 2016-10-30 384 goto fail; 5244f5e2d80125 Rafael J. Wysocki 2021-03-19 385 } 21d5c57b372616 Rafael J. Wysocki 2016-10-30 386 21d5c57b372616 Rafael J. Wysocki 2016-10-30 387 device_links_read_unlock(idx); 21d5c57b372616 Rafael J. Wysocki 2016-10-30 388 } 21d5c57b372616 Rafael J. Wysocki 2016-10-30 389 } 21d5c57b372616 Rafael J. Wysocki 2016-10-30 390 63d00be69348fd Ulf Hansson 2021-06-08 391 if (cb) ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 392 retval = cb(dev); ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 393 21d5c57b372616 Rafael J. Wysocki 2016-10-30 394 if (dev->power.irq_safe) { ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 395 spin_lock(&dev->power.lock); 0cab893f409c53 Rafael J. Wysocki 2021-03-19 396 } else { 21d5c57b372616 Rafael J. Wysocki 2016-10-30 397 /* 0cab893f409c53 Rafael J. Wysocki 2021-03-19 398 * If the device is suspending and the callback has returned 0cab893f409c53 Rafael J. Wysocki 2021-03-19 399 * success, drop the usage counters of the suppliers that have 0cab893f409c53 Rafael J. Wysocki 2021-03-19 400 * been reference counted on its resume. 21d5c57b372616 Rafael J. Wysocki 2016-10-30 401 * 0cab893f409c53 Rafael J. Wysocki 2021-03-19 402 * Do that if resume fails too. 21d5c57b372616 Rafael J. Wysocki 2016-10-30 403 */ dbfa44782787dc Rafael J. Wysocki 2022-12-05 404 if (use_links && dbfa44782787dc Rafael J. Wysocki 2022-12-05 405 ((dev->power.runtime_status == RPM_SUSPENDING && !retval) || dbfa44782787dc Rafael J. Wysocki 2022-12-05 406 (dev->power.runtime_status == RPM_RESUMING && retval))) { 21d5c57b372616 Rafael J. Wysocki 2016-10-30 407 idx = device_links_read_lock(); 21d5c57b372616 Rafael J. Wysocki 2016-10-30 408 5244f5e2d80125 Rafael J. Wysocki 2021-03-19 409 __rpm_put_suppliers(dev, false); 21d5c57b372616 Rafael J. Wysocki 2016-10-30 410 5244f5e2d80125 Rafael J. Wysocki 2021-03-19 411 fail: 21d5c57b372616 Rafael J. Wysocki 2016-10-30 412 device_links_read_unlock(idx); 0cab893f409c53 Rafael J. Wysocki 2021-03-19 413 } 21d5c57b372616 Rafael J. Wysocki 2016-10-30 414 ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 415 spin_lock_irq(&dev->power.lock); 21d5c57b372616 Rafael J. Wysocki 2016-10-30 416 } ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 417 ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 418 return retval; ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 419 } ad3c36a534bc7b Rafael J. Wysocki 2011-09-27 420 :::::: The code at line 362 was first introduced by commit :::::: ad3c36a534bc7b945d7bffdda1c62e13bf93489a PM / Runtime: Don't run callbacks under lock for power.irq_safe set :::::: TO: Rafael J. Wysocki :::::: CC: Rafael J. Wysocki -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki