From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 878AFC02181 for ; Wed, 22 Jan 2025 20:05:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1E94280002; Wed, 22 Jan 2025 15:05:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ECF42280001; Wed, 22 Jan 2025 15:05:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBE12280002; Wed, 22 Jan 2025 15:05:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C1A06280001 for ; Wed, 22 Jan 2025 15:05:53 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 25334140644 for ; Wed, 22 Jan 2025 20:05:53 +0000 (UTC) X-FDA: 83036168586.09.EE861A1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 60EB420005 for ; Wed, 22 Jan 2025 20:05:51 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sQRRo21t; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737576351; a=rsa-sha256; cv=none; b=GBurg9DPE/BwXTpEpC3dizVDaUHLKl+ErpmiYjB4RL1zobQRa3JSPhpCku0Vm69r1keJgc 2SdAbmbLazmQ0O/hIvSQ0R6kJifKl7CD/eszXbFwUEPCzrJR7Go0AiDFtzGhUkOSYBbwAJ x5w9k614Z8laSrlhDYX3lDuCnEN9Meg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sQRRo21t; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737576351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qKyf4ePSfys7AXfW9j7MZi0C6MSJ3EcVS44RyAOfi9o=; b=WzbIcaenuFCu4YRGYEA7rLHMcjMzMO9iB+XPQy5DIgzI3TiWZXqVrl3K1wWCGUk5A4Vffs m8TYhDJaa7Dxy72HfP4TOTFjwC7tP1bQ4V8eWxfdDiF/BCQK2+wx1ECriKtGMPtGgQko1g fY0hen3p2g6qkXOw2JhGkgFz9iW0p/k= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 05C745C5D46; Wed, 22 Jan 2025 20:05:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED0CEC4CED2; Wed, 22 Jan 2025 20:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737576350; bh=uF+EtzEo1MBzJLul5VAqJp9o/IVt+jDiN49DXxj88ww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sQRRo21t8kFgZWwBiIylReXTe60KhxKy4y/iP9+aT1HT1rX9IBSQhBfSfp5puxidb p3M3wP02mrmR4TCXepnZ9DQspveAf8M3cAvdP7VIfHAOp0TSuq6Y7UB1BBXZOWFwHx 2FLT2HEoz/Hs6KsylfKqsJ52/wQZ3DHFb4vnia6YofokeKQ/RAmPtOMTMAw8Q7htEY /mAP14R8p3bj3s10aaE6DZgEgq+RdFrjxy/0nyHc8CVgo3TDsaBqvFVUCwtV0xOC0T +kxFi6IkvT6lWyZIrK29rDnXj2ERINN/wDSneEUi0BM3bHdkZbBkmNrAHWvS3oPGjA DV2kXJSnrGvBQ== From: SeongJae Park To: Vinay Banakar Cc: SeongJae Park , Bharata B Rao , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, mgorman@suse.de, Wei Xu , Greg Thelen Subject: Re: [PATCH] mm: Optimize TLB flushes during page reclaim Date: Wed, 22 Jan 2025 12:05:45 -0800 Message-Id: <20250122200545.43513-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 60EB420005 X-Stat-Signature: 84sz6o5dahbdeif76z3gee4dpxhemqee X-HE-Tag: 1737576351-464252 X-HE-Meta: U2FsdGVkX1/UC7Z1GToPFfh48kSQxkaACyGoNkZ9C93mNpqCV3gRKW7+0LiYgL3rXmwv4SVlyQVAgGdM6uu0Ur6TQyE6d0395RaeYeyBhTt6Mocksve5EYBtF/X1sBPUPXTr8PPWZOWhvshWGd6mfDEi71d+oIG4I8oFL02ygKNP+t2fJWgHt9/OCM1Dg+G6nGes9NHrIa57KVBI2hS9poWJjw38eFaH3KIXmWVAm5ufAsPYVox/GqACQwx2paADlWXpYcmPJ89+54MWh/Zqt30rDXicn0wkq0AaQ/1IeNHU9Vbmz99meceD0PKeBHe+9QOuBmv+7V+zH0oSSKgtFdaTOQ9UfrvZKdP8zXbCzBYx9rptIco44q9q2zgx7RN1b7IlGvuEjfYcKRLEB61TzO6u9ZT3jG8gy1Sm8atccC5b/eNHt7CqDGkfgAgNDsgc1lEPYC27OrlWfin1TwDE+Fy8AHTSQgIE8Ny5aQBI+SV1P4mLfAQ2ogQGFYUW2nZg1YoyYyRHLSKXWlaAcreaLjKmCYK/8Y2PCNP7lkPMgb0SV48c7cfdH9p90M88JHDfNMAAAHLlkXYiQ8NaOs2KOVUyGUE4HPiXLhn9/VGSt0wB3bYv7QIgVbXrTd+vmFJzsKoMPCGvd1uYo2brV1KL7Qu2uqZulsNGHaJD8kgQqkfNY+u80JElaVG329qqfL2Vg6SQo11RqjP7i8bA8/pcBh5M8XXavrBZsbIbZ5FvBPdGaG5bi04PdoGAcGOFkV6dArxbi/z0FI4bgTYGkkAMb6uGLCxE5APHaE8BF4j5R2wxGSjwuu4jeR7jjS+Z/0uz3wWshaGG4BvOltQ7b8XytcLF7iA659L6kVxJivkOnJiQRWCWz0SMFI2UeccGCdxcI5L2oyhLySMfnUeT/hwiNqKYkm+gLD/egmmAT3PiJqLjqmIiNkJU694EDF2sQWWo+1+N/NPP9fDjq0mNVH0 jrZNVqI0 Ks438lYxa+LGO6CFbRAKUwSDbpdUpREUdQeyEovUGoj8DjfS5CMPh9d8Et3CicilAEjBZ/aAEfsjhFGGCht0ejVk0ncPYbFq0p9gRSFeN/EnEZNsWRWmApWzSNn2Qqio0lqUx4kFfGSy5hv0NZ+KAkmd3nql2ro3MWX3XzK5BWfjMbMNGDxLke6a3Qf5xcLrQ/dUn/KMH2Dv9T0XCG2wgHy3Esqejep2eCOahaDHIW5U062E+mWnZpUqmgIzN5vNCo+Wn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 22 Jan 2025 07:28:56 -0600 Vinay Banakar wrote: > On Wed, Jan 22, 2025 at 2:59 AM Bharata B Rao wrote: > > While that may be true for MADV_PAGEOUT path, does the same assumption > > hold good for other paths from which shrink_folio_list() gets called? > > shrink_folio_list() is called by three other functions, each with > different batching behavior: > - reclaim_clean_pages_from_list(): Doesn't do PMD batching but only > processes clean pages, so it won't take the path affected by this > patch. This is called from the contiguous memory allocator > (cma_alloc#alloc_contig_range) > - shrink_inactive_list(): Reclaims inactive pages at SWAP_CLUSTER_MAX > (default 32) at a time. With this patch, we will reduce IPIs for TLB > flushes by a factor of 32 in kswapd > - evict_folios(): In the MGLRU case, the number of pages > shrink_folio_list() processes can vary between 64 (MIN_LRU_BATCH) and > 4096 (MAX_LRU_BATCH). The reduction in IPIs will vary accordingly damon_pa_pageout() from mm/damon/paddr.c also calls shrink_folio_list() similar to madvise.c, but it doesn't aware such batching behavior. Have you checked that path? Thanks, SJ > > Thanks! > Vinay