From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCF32C02181 for ; Wed, 22 Jan 2025 07:50:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 340676B0082; Wed, 22 Jan 2025 02:50:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EF096B0083; Wed, 22 Jan 2025 02:50:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1904C6B0085; Wed, 22 Jan 2025 02:50:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EFFC56B0082 for ; Wed, 22 Jan 2025 02:50:28 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 75222C140A for ; Wed, 22 Jan 2025 07:50:28 +0000 (UTC) X-FDA: 83034315336.25.2055D8E Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf28.hostedemail.com (Postfix) with ESMTP id 5C8A8C0007 for ; Wed, 22 Jan 2025 07:50:26 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=WKfRRI1l; spf=pass (imf28.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737532226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YOmEKaCYp7BVYdSA921evwSGcBIDRQEOB9Qf7IL5hrk=; b=KtYJat73JMGjb8OF93Uv/cDZEJOPSot96nSg/WgEC4BTlt8HaoJYP8/2kEipDeby3o2NeO P5uQvjxXeI0kvLgbJfDpZCBbQoOMpofuHthwtNhU37I87JZ8zTfziOkgL7CtMLbQIwdDb0 SQH62msP4rgiY6aGTCfZCcO/8OFyzhw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=WKfRRI1l; spf=pass (imf28.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737532226; a=rsa-sha256; cv=none; b=6tdSm57uD0eqNkWeHpelPfdUK9AozIPMIlL0zvaPE8eTTGa38kZhB39Fx6AY0jXBFoWnWP UnSIUe37YSU3febSKuDVvDvgecLb9yxdSizIOGym80/DoFBZLgfI1vhth6F5zz2ElDJQ7r awIGV88BjbwLzBibZao/CYWrfXBgJL4= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50M2A4Je009705; Wed, 22 Jan 2025 07:49:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=YOmEKaCYp7BVYdSA921evwSGcBIDRQ EOB9Qf7IL5hrk=; b=WKfRRI1lHye/PfeRq0CM+invZscqmJxiyfMJj6RqKDo+k0 oHw8bxFR10u4InxfkGzbtPQRnmjjRIxYD+e4Hdc6VNWvxRNBhElChMEKYTQww/ne kooQLVgHcJbjlXo8YwFiHbBQ8lYIn1j20/tkdmwE9rGrifbH6of2GaRERifgPxvN e6jGjgMPTSpOWNSK//eRAMpTyDt03PLcgP0/2Qj42QpNbLO975g3w4J/8kekr9qF dPd8DDCPlAQUGXVLnf/2L8EUh+BlP8RuxoA5walvWUcYL4qLgoLMxpcBdMKwAzI/ K9cmGJQE5Hsas24CZr5x5+mJxBXMWUxPL2+9HvXg== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44aee1bs75-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Jan 2025 07:49:59 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50M4kx3X019330; Wed, 22 Jan 2025 07:49:58 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 448pmsfk01-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Jan 2025 07:49:58 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50M7nu1d48300472 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Jan 2025 07:49:56 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B223620040; Wed, 22 Jan 2025 07:49:56 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4B9362004B; Wed, 22 Jan 2025 07:49:56 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 22 Jan 2025 07:49:56 +0000 (GMT) Date: Wed, 22 Jan 2025 08:49:54 +0100 From: Heiko Carstens To: Alexander Gordeev Cc: Kevin Brodsky , linux-mm@kvack.org, Andrew Morton , Catalin Marinas , Dave Hansen , Linus Walleij , Andy Lutomirski , Peter Zijlstra , "Mike Rapoport (IBM)" , Ryan Roberts , Thomas Gleixner , Will Deacon , Matthew Wilcox , Qi Zheng , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, loongarch@lists.linux.dev, x86@kernel.org Subject: Re: [PATCH v2 6/6] mm: Introduce ctor/dtor at PGD level Message-ID: <20250122074954.8685-A-hca@linux.ibm.com> References: <20250103184415.2744423-1-kevin.brodsky@arm.com> <20250103184415.2744423-7-kevin.brodsky@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: qTola2ylJwUaTSt4IdPRfZSdT02Tio3Q X-Proofpoint-GUID: qTola2ylJwUaTSt4IdPRfZSdT02Tio3Q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-22_03,2025-01-22_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1011 lowpriorityscore=0 mlxlogscore=674 priorityscore=1501 bulkscore=0 spamscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501220053 X-Rspamd-Queue-Id: 5C8A8C0007 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: zdh9o31d5xi9wz3w5hme5kymxsip8ymt X-HE-Tag: 1737532226-906003 X-HE-Meta: U2FsdGVkX19aT2YRZlmfCwTnU7pGuBZ7BGcoGo2JP3ZuiwYG60FP7vNPfPkRzOUqaDs5PkEAp3FLzJFMC8LNV2WJd7Yrklq/sintJB5RBK4NNTBPnZW+fiMS3TPx8gN2b1xBkHvAzTzBZHUximFhoWPsVivf6kTxLs1ku9HWNz8fed8Dv7R6g+TWeMaaMQFgQcQhClEtcCGQWVf9sRd25PkkKqPtdDfE9t/Js4GWfNgv4cawOz1PCf/IsyFJEYnIHZno/4n4YgM0Nu6fiEPcbCFvKrlBT3Xmr1je7SRnPAZVzbUKOADubQJm6m6FhtAaE7D57VmNNjJzT735sVHJEJs8teUboXN4wKjNRGEf13K3Dkb+JLTSJjW42qcLOFjQvI5YSbbvqTsZavGMDiWijCS4979QTUqL3CRu3PX5m8EG4FYWaO//IKRX0J5EY7S44CjIrgD8Y+EiPODhSByAwmnfFE9crY+eBEK8xy1CnYVWNLZmeYK//0+zTB2rjPrj6p2eSJE/cxrheP/zem/Xt6kX7QTpk9CO1CLEtbhQiGxpNZ3gw4CLk8NK8Fro9fySq2iSq8VY7dDFRydD3NzgzkxHiF9CXwePtERFYkZJhkvvqAVk6WwdsIH03ME9QzgHOekRlhIo6WAmooCeCvi3CCBywb2RrioCn5HCMuJzJP8EjXaBcv3I1jtF4ANfNbSmfrbBcLxUKrLIMatOtRqUKVGn5gn/Lxwl/rYs4559OHAGZS18zODfrjN6CYlE0aT9bq4RSa582qiT5v0iPZWfIr1rfssDMa6nBDh0yZU9ycLcoQ4Ded1UbNf1m9iwLfp/lKuLgAwYzFwsb6a664dR96Fm+hDxmYibBetVHZO+vf/5cxT5e+70SuI1k3ohZDcixKZ4qDCLlYYyxQtH0cL4a2Wf0321HTeC6QfXRxM4n9wluZi/Dc6ZYMxxF08hTILWDVjgP4CQnP0KUKQZpMT X8xJxvzN TGgINv7sctXn5+EXyytLkn1RHzhYlrdzf5WNHZbbyrNunEQVqyXrkrIXF+an1onzbWKv4iJ6F4XT3UUq/amcgnPYviHsc6sBhf8FeGNKbGGcH1Hdgq3GslsnOoU1Sy265jwNAkyr8ZyqaKrDNvJCzCCvWnEegNxpAlTECC8qWtyLxIaLLfG54fB2+V+D66o+1Sa1VXTjfeTYPCBCVBdyVOctn0wgbuzXuhXFewg+ykWsp4C9L0E6OjsZt09lTJ8rC2C0ZbPyIlUivBSEdA33bnP1WlhYpwMXi9lQc0y5eNInxfGXFNkG+9CEViSyZsRJiY9EZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 21, 2025 at 05:37:33PM +0100, Alexander Gordeev wrote: > On Fri, Jan 03, 2025 at 06:44:15PM +0000, Kevin Brodsky wrote: > > Hi Kevin, > ... > > diff --git a/arch/s390/include/asm/pgalloc.h b/arch/s390/include/asm/pgalloc.h > > index 5fced6d3c36b..b19b6ed2ab53 100644 > > --- a/arch/s390/include/asm/pgalloc.h > > +++ b/arch/s390/include/asm/pgalloc.h > > @@ -130,11 +130,18 @@ static inline void pud_populate(struct mm_struct *mm, pud_t *pud, pmd_t *pmd) > > > > static inline pgd_t *pgd_alloc(struct mm_struct *mm) > > { > > - return (pgd_t *) crst_table_alloc(mm); > > + unsigned long *table = crst_table_alloc(mm); > > + > > + if (!table) > > + return NULL; > > I do not know status of this series, but FWIW, this call is missed: > > crst_table_init(table, _REGION1_ENTRY_EMPTY); Why is that missing? A pgd table can be a Region1, Region2, or Region3 table. The only caller of this function is mm_init() via mm_alloc_pgd(); and right after mm_alloc_pgd() there is a call to init_new_context() which will initialize the pgd correctly. I guess what really gets odd, and might be broken (haven't checked yet) is what happens on dynamic upgrade of page table levels (->crst_table_upgrade()). With that a pgd may become a pud, and with that we get an imbalance with the ctor/dtor calls for the various page table levels when they get freed again. Plus, at first glance, it looks also broken that we have open-coded crst_alloc() calls instead of using the "proper" page table allocation API within crst_table_upgrade(), which again would cause an imbalance.