From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FD4C02182 for ; Tue, 21 Jan 2025 09:45:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E04C66B007B; Tue, 21 Jan 2025 04:45:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB4786B0082; Tue, 21 Jan 2025 04:45:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA4026B0083; Tue, 21 Jan 2025 04:45:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AD5386B007B for ; Tue, 21 Jan 2025 04:45:53 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 31D4D1408C7 for ; Tue, 21 Jan 2025 09:45:53 +0000 (UTC) X-FDA: 83030977386.09.ECBE3E9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id E24E640008 for ; Tue, 21 Jan 2025 09:45:50 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YhClChW5; dmarc=none; spf=none (imf07.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737452751; a=rsa-sha256; cv=none; b=a7W9WlUIsrgu60L7i6mLwPtSMziBBFsrO6kInJF387AIDxxbjvrldxSlaSsev2mHtSyTsr 6dQ8j0znFuljxVrdB/F3sYNpMeOUEG6Q+G6sZ1p+MgBovgt55794FTTYkrnPbW/4IESAoi vp2kPJjXuDG6AVJngTJJ9CO/52v7QME= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YhClChW5; dmarc=none; spf=none (imf07.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737452751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fOvAn/1eIfoUpeniWv9foq3vmq6m+tBJyxyTbXnkGDs=; b=fNcGOJaf4HZ4APnPpsFijuzIcLdvWDDpnp3uqhwIGAgZOyVxBwdH5JdXGIbYNScB/9nmuz yDsGn+aoQ/nVKQ1Sh7Hao3amBqKhbT3PJ0VyfmjA+dlE6F6Jn+TyXzMhoiAwWpU5zVR8HY Qb0OYYPgOz5NQa/ukE41oESXyIycORw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fOvAn/1eIfoUpeniWv9foq3vmq6m+tBJyxyTbXnkGDs=; b=YhClChW5FmMPeXz8n4Ca9vgZ25 zyAjQbTUqgdJHeKWEpIbyM2IUOmFjVbS1gLOufqhVlG7Pn5Ckb8ZPmUaDwlJQ6REtjGJh35MXWmkp /u7S+W1W0zqJEqO8RYydMbLijuKl+MMxd2f+1XvDzKVdN7KJd5o8aoRK046MAEK0OpVBYgKj2GNbr /noBSv5Kds3NOQB0f8BqYM4Visj9kqAYdiHe5M03XX432D7dy346286dW4m1EpqLimAkqmbmTaGQG av7mdqEYs8LCZxK7cn5Pb0sBfZXx8L2+wWkyu0ErCwD0qSh/HmXr4y9tIFI5SXSMQPqRjmy0nypUZ ryLJns8A==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1taApK-00000005zzc-0fRd; Tue, 21 Jan 2025 09:45:42 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id E33FE300619; Tue, 21 Jan 2025 10:45:40 +0100 (CET) Date: Tue, 21 Jan 2025 10:45:40 +0100 From: Peter Zijlstra To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com Subject: Re: [PATCH v6 05/12] x86/mm: add INVLPGB support code Message-ID: <20250121094540.GA5388@noisy.programming.kicks-ass.net> References: <20250120024104.1924753-1-riel@surriel.com> <20250120024104.1924753-6-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250120024104.1924753-6-riel@surriel.com> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E24E640008 X-Stat-Signature: tiwg91b7dry7r1qbx1tqz6je5cxeuqxh X-HE-Tag: 1737452750-317084 X-HE-Meta: U2FsdGVkX1+2VZ+hqiWzNXTjxqhWNn0BZ01gvQcNckdUZPKJvrelzquxEkQZMuSwt9BQNYz8GzlzfUcIgZZULIc2ufyITf6hg8rP2GLIzQnYF4QoJzPZsXGyopxZQoqC+YRPuSLNistkdL9rSxHaqZNqGCTRA+H5jakIWKitRE3o2arwO/vBJ6ixnujAqvdcviZx45mQu8GAkjYSiNaLJpsP5mVsyZ6SO3wHCswe8ourtzLgqfTD2qzqpSycpc+jFmh2mWcp+cnTjB4bRbPxx/wto86QuIcnnxMLC2JtoqZlWF6Oq8RonH2nbbDIAZqXYCKk9hlpIHAUghRKaCjCQI+F3jPudNOAeeW0Mz4yDPx1Qoqi/n69fUEuKK7luEboazuWDfqcVqZBPOsVHFoF3198Rgp8kYZcmk4cM43GXPkF3oF/e/RVY5ibgBN8dy07FX7TeYfJZRUXt5m0//wPHh3EkMjmUdMU4VLoYNq+j7SxspQKt8l3YM2SEz7UNnbaznlwDg3k8gX4dK1jR5YFST7mkO0NYxtThjPnAc2i7ukCb87eBIvw/o/cXtr56Iw9gYrUfZwvdO5o5/fEP6oV59T8E8Y/kiP1hQc+9TE6aBADBylMGMmyHctU8Jc0N8Vie0ihO041sgzkCGjsD5Qv70p1XdtOuapDYtoulyoQv3h2V/NDNFBeEaWxYH+vu4WIVEH2nwoo0VaEJQQ/htOLMJRs9PzpGqlfXx+eNkU1lF3nR2yYnz3ivZYeqO9MOGs3fq+YwylIbq6FknKveEgMbk/LZLhSNsmmrsfw17MsK+iARBXAa5KkozpaFzLDlfiPwW542dCxhGGIb8muZSgEmNEEVfqB9au0fG+H+1m5wpWPHeVPS3S1CPgHMWtXZF+IrS9SpTcu7He30ZQ1QJ2e7WzjllxchLgN/WH2VfOOuQAjAbL/dir6znk3dgQTObVmzESfIVQ55+0X3zTbkkZ J/MrHNzg ZI7QlP0zXhQ9x6D8DighFl6HNqoQApNOhoADeuQSsy4pCKuZ1ymkp9aXI6ro9doA1JNheNoKjMhoD4BQ2qRZ4LzwKXaegQ+Bt6EPyex0Ru+SMRW1oJGWFmLe2fGRmlcsfOBNORMmqIHRhyBqCxhniyzXwWShMs5LnefXnWzNG1sSW/LiISwg4PzKQEtJdxCxub7Y7ITgJptCoVm3io1vR8kE/wcRljKEJRtcO4f/hZa9IxtKekkQu1PkfMZD3Fxb+18tbOtBBLFXdl3o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 19, 2025 at 09:40:13PM -0500, Rik van Riel wrote: > +/* > + * INVLPGB does broadcast TLB invalidation across all the CPUs in the system. > + * > + * The INVLPGB instruction is weakly ordered, and a batch of invalidations can > + * be done in a parallel fashion. > + * > + * TLBSYNC is used to ensure that pending INVLPGB invalidations initiated from > + * this CPU have completed. > + */ > +static inline void __invlpgb(unsigned long asid, unsigned long pcid, > + unsigned long addr, u16 extra_count, > + bool pmd_stride, unsigned long flags) > +{ > + u32 edx = (pcid << 16) | asid; > + u32 ecx = (pmd_stride << 31) | extra_count; > + u64 rax = addr | flags; > + > + /* INVLPGB; supported in binutils >= 2.36. */ > + asm volatile(".byte 0x0f, 0x01, 0xfe" : : "a" (rax), "c" (ecx), "d" (edx)); > +} So asid is always 0 (for now), but I'd feel better if that was a u16 argument, less chance funnies when someone starts using it. We should probably mask or WARN on addr having low bits set, and flags should then be a u8 or something.