From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1093C02185 for ; Tue, 21 Jan 2025 08:54:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 070696B007B; Tue, 21 Jan 2025 03:54:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3DB86B0082; Tue, 21 Jan 2025 03:54:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDBC96B0083; Tue, 21 Jan 2025 03:54:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BBC766B007B for ; Tue, 21 Jan 2025 03:54:30 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 69581120814 for ; Tue, 21 Jan 2025 08:54:30 +0000 (UTC) X-FDA: 83030847900.20.EDFF58E Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf30.hostedemail.com (Postfix) with ESMTP id 4570E8000B for ; Tue, 21 Jan 2025 08:54:28 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=BuSWNcl9; spf=none (imf30.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737449668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cYCq7VWlsf17HZjMd4BzuRbRgmVxe556YjNJKjyewvE=; b=K99U9vMOQjTQRoEbHe5jLUmSIvFJ5Ji57770lBFjPWePPeJUT91Ma3QT3KEB0hL7oGG6/7 UKxDmMPlNX1dn5kIwRn3vvK5sm43M27ljHm/m0RSUgxhmAfBKIt/0UsXvq+ktMYPoS96OM qor6q/NKPQkAFhjs8B2JgPNAiiNKNp4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=BuSWNcl9; spf=none (imf30.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737449668; a=rsa-sha256; cv=none; b=lFfZVLWR3sg1GUgKB1Ov3ALQNN8kYuDs6EYAcoAfGWft/uFZLEt6qJgjfV+rfKQFw/mMey wKfDMvnps5BWG1LDWLxjkvptBB/WKU3OnP94cc9ulTLWz3sHlsCASUJNyKU2+gOEkOltFc 9ckVgol45vTVXhCq4a0VXjmAc7ecnTA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cYCq7VWlsf17HZjMd4BzuRbRgmVxe556YjNJKjyewvE=; b=BuSWNcl9sfm/7BIQIOrSWRzCRH OEfeu3nDjpheKH8YEqZNMsfeTdEow+ErBB5XrEJJaLKrEK/w/9NqM703+VEWh2+0jTq72Y2qb/nPD FNXU9vj0s/u/sSqZWZYxVtG+b9tAKM0CpRchcmYcHlsKpUfieUKRmhrQWaSNvQCY9AZ1ytT5bmMFo J32A6CmTKJCatvWyP3FuyeD8EgnhUtbA/ZZdoBAr81z8foH3etlHEsusDWgQ5SCh4fVRrb653I5YR 6yp2UJuJCij904X+t/Ir50deBh7arfT3arhPxJefDMQyBTtwN5V6u5gpTDHxRaoc8utjY58/i6Ckn DZ11gJsA==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1taA1Y-0000000DE4g-0e5U; Tue, 21 Jan 2025 08:54:16 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id B3F673006E6; Tue, 21 Jan 2025 09:54:15 +0100 (CET) Date: Tue, 21 Jan 2025 09:54:15 +0100 From: Peter Zijlstra To: David Hildenbrand Cc: Rik van Riel , x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com Subject: Re: [PATCH v6 02/12] x86/mm: remove pv_ops.mmu.tlb_remove_table call Message-ID: <20250121085415.GZ5388@noisy.programming.kicks-ass.net> References: <20250120024104.1924753-1-riel@surriel.com> <20250120024104.1924753-3-riel@surriel.com> <8de49f2c161085fdc63d8cc883cdebd3451df47f.camel@surriel.com> <543a134e-26ef-46c8-9f4e-c37e24dd7a25@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <543a134e-26ef-46c8-9f4e-c37e24dd7a25@redhat.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4570E8000B X-Stat-Signature: dkdno6mp5cqwewoe4wpk17tcss594aa8 X-Rspam-User: X-HE-Tag: 1737449668-26478 X-HE-Meta: U2FsdGVkX19lasxFdYMp6u9GsfeAvBOdEtjBpdRF4vkdRSwEeyFbh1DkaPC2fcRh64O5R1bnN6IcExTAox+ZaF5zpeYXdp/5E74KaZR/SoEi5hJ8fZXKmr75PfrvDmeTpnwZAMDf3/zIlTs2rjs1+OMizXTCHeLkVTctsD2pg4u1l+1BVrw3UDG9XFTq4uAVSPYYKXAP23DNs+NfbiXetVbgQnP8u4l6sJE6wrYzt7uglxr06EWTb9o9QomwgBbSiPPxV8k/2Dtc/9GvFV8ai+wAIN2S6SsHkCTV3BhCYjzTUT6UdvzodQK3bSN8JW6NGwLpAef2ShxuFIcmUtLBTXim58gnTfQon8Ulmn5VOl4PPhGdjBjVcdhuXMywjMXfWF0bj7svk8s/IVP0bHVeoLxmHPeSdEIBQfq6YQAPEPyoCYm3Wi/4Ur/fqClQhBCN0DKkqF1UrGthMaxPMidX138eCP2q+LgnW5soo+p2qJ91pfIYODcH9+yQxJlMudS0XUmcUYRy70qqCc0xe1oLU+rQtf+B+u9rxFXPBwTv7ZQ5I66s/Yn/6Lmcf0iFb6pYpMZS3lxbWk2FPzYfySXR+N9WjKWBYyn87jV8QtwtTSbFx99uppMLmFRf/fp8KiDgiGb+4DH5hZ8IxZ6LfgLPpsXJHk6vzbqbZlKEqMNZvfCwD7NWAFz/M8VN/YvMtwyP7ru8oL3khEcwBSFgNANoMkIsa9UNy+5qAfDnhewLA1IpZ4YQOgdVymtrwfYm2EnRNPuLbllRYZR+aJ5JUemQO5OMjtP4vFtKWWzeqMUsHvI96WkBhuSTFbgXITXQYW3NmfJFz7tVmelN41alcNoPlWcG3/0wRwK75nYlP1W5fFLMULGEzDBhP+m/Lit4VGex7Y7NYhaASqS5R6crdCrvBGr5cIl+GV1H1wYXhC6w+s9BMKJ3CBa3zvnKBHEb6+zijtgnfCI8ZNWq+O37SuD c6DLpTeo UiIaF/f/AJa26DPOmbSJzd3SZv8WV28aHVnriz4MPFMTHNpVdIR9K/AKbhxP8viXzM27A1Klw0lPdRLMnHaxtj+VLIXuHkbiAYjWgJgX1TSc8rjaGZ5yduABEmTv6grfI856+w2Ox1ef7G1+cN61XdXSEwZHDD8RXx36z+xdoc8X0zbwgKnKrjxGldbJM2Ud5RKhSPnpPhAtgpYzOmzZb4VUQ3fSKqFsBMpkqdwdo2NfisYEbTUzy/RSUabzDMc+GsW0UIwkTxLJuWe5y3B34tbOn1WWn1FuYxKmaydyQpX+zr4odaVeEDuXgqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 21, 2025 at 08:46:04AM +0100, David Hildenbrand wrote: > On 21.01.25 02:03, Rik van Riel wrote: > > On Mon, 2025-01-20 at 20:47 +0100, David Hildenbrand wrote: > > > On 20.01.25 03:40, Rik van Riel wrote: > > > > Every pv_ops.mmu.tlb_remove_table call ends up calling > > > > tlb_remove_table. > > > > > > > > > > Indeed, but the !CONFIG_PARAVIRT variant paravirt_tlb_remove_table() > > > however calls tlb_remove_page(). > > > > Patch 1/12 from this series removes that. > > > > After patch 1/12, we always call tlb_remove_table everywhere. > > This patch contains the hunk: > > -#ifndef CONFIG_PARAVIRT > -static inline > -void paravirt_tlb_remove_table(struct mmu_gather *tlb, void *table) > -{ > - tlb_remove_page(tlb, table); > -} > -#endif > - > > That is the source of my confusion. Ah, that hunk should probably go to patch 1