From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEFE2C02181 for ; Tue, 21 Jan 2025 02:34:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B9AA6B0082; Mon, 20 Jan 2025 21:34:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7419A6B0083; Mon, 20 Jan 2025 21:34:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 595B46B0088; Mon, 20 Jan 2025 21:34:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3C10B6B0082 for ; Mon, 20 Jan 2025 21:34:25 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 70AAA805A0 for ; Tue, 21 Jan 2025 02:34:10 +0000 (UTC) X-FDA: 83029889460.26.23777B9 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by imf30.hostedemail.com (Postfix) with ESMTP id AFEFE80004 for ; Tue, 21 Jan 2025 02:34:06 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=upqYDq5i; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf30.hostedemail.com: domain of hyesoo.yu@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=hyesoo.yu@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737426848; a=rsa-sha256; cv=none; b=18fVSM2rkRLLfz0VG0gYSujHnK7fb82zV/rT7isq0kFrvp3zhEY5Hu8X6kP5INbTKvIItH DDrmrGeLMjUPie9qW5QVlHZnN6lo01gWeiZehYcK5lRG/Rq9UrlNoxmTg+uOhtSP9eexyz U7g0Lbv06UusLKhYyCpnA61ps+HQdSY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=upqYDq5i; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf30.hostedemail.com: domain of hyesoo.yu@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=hyesoo.yu@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737426848; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1Hkxk2m8dg0qUTbY9/1KkBqFD1L/vV8wRNYJej5g09o=; b=ixQOZGjAeiddVdwBvxEyRse78DE1lfqJWwPV2aMJuyoeCFLE1/AtSGUpHjkGHfmPTCeHRL pG1oPJBg8eEsuL/5A9eiPC2c/5/bsOexbIz0CV8rUW2grE4+MlX4mb75AcrpyAO/CUqRfT 0mqYirvPHRnjIEwQu5lQblA0hPDhVR4= Received: from epcas2p3.samsung.com (unknown [182.195.41.55]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20250121023402epoutp01bf1e7f8c957a58c75967b162ab06ecc8~clIIVDMYZ2440224402epoutp011 for ; Tue, 21 Jan 2025 02:34:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20250121023402epoutp01bf1e7f8c957a58c75967b162ab06ecc8~clIIVDMYZ2440224402epoutp011 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1737426842; bh=1Hkxk2m8dg0qUTbY9/1KkBqFD1L/vV8wRNYJej5g09o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=upqYDq5ileDDUPfozn2RWcHSQTtJBxbImQKi+bTf9TrHFMhkFlTiMbw0uvH50t+Mu 6CDXE7PjuRFrKhDR3hZ/DB36NSrFjSh6jVba0FCA+YUQ9tXrWAY7MiGRF4qfurRaZg 1r0RBTkhwRVhyQWR1bVPvtmu46CoxHF+6tNOX9J4= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20250121023402epcas2p110c6f6d62cc8784723a26f66996daa5d~clIH5-SRd2425724257epcas2p1y; Tue, 21 Jan 2025 02:34:02 +0000 (GMT) Received: from epsmgec2p1-new.samsung.com (unknown [182.195.36.69]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4YcWVd30hRz4x9Px; Tue, 21 Jan 2025 02:34:01 +0000 (GMT) Received: from epcas2p1.samsung.com ( [182.195.41.53]) by epsmgec2p1-new.samsung.com (Symantec Messaging Gateway) with SMTP id 8E.20.32010.9970F876; Tue, 21 Jan 2025 11:34:01 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p2.samsung.com (KnoxPortal) with ESMTPA id 20250121023401epcas2p2a3d5086caafb9950070c258542dce27c~clIGxGb4V2385323853epcas2p2e; Tue, 21 Jan 2025 02:34:01 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20250121023400epsmtrp2a5c4821979cf260c16e414579f55c206~clIGwOI1m1100611006epsmtrp20; Tue, 21 Jan 2025 02:34:00 +0000 (GMT) X-AuditID: b6c32a4d-abdff70000007d0a-05-678f0799016a Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id D8.82.18729.8970F876; Tue, 21 Jan 2025 11:34:00 +0900 (KST) Received: from tiffany (unknown [10.229.95.142]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250121023400epsmtip2ac6dca7106a25615294aa5d88c89fc78~clIGgFFNX1481014810epsmtip2E; Tue, 21 Jan 2025 02:34:00 +0000 (GMT) Date: Tue, 21 Jan 2025 11:32:40 +0900 From: Hyesoo Yu To: Hyeonggon Yoo Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, kernel_team@skhynix.com, "janghyuck.kim@samsung.com" , Andrew Morton , Jonathan Corbet , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mm: slub: Panic if the object corruption is checked. Message-ID: <20250121023240.GA645761@tiffany> MIME-Version: 1.0 In-Reply-To: <1495dc28-f16c-4990-ad89-2a90b79a80b8@sk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNJsWRmVeSWpSXmKPExsWy7bCmqe5M9v50g9M/RSwm9hhYzFm/hs3i +rc3jBZPDrQzWsxcm2SxsruZzWLznGKLw3NPslosbFvCYnF51xw2i3tr/rNatH3+BySWbGSy mLhG1GJ2Yx+jA7/Hzll32T0WbCr12LSqk81j06dJ7B5db68weZyY8ZvF48mV6UweCxumMnss 7pvM6tG3ZRWjx7fbHh6LX3xg8jiz4Ai7x+dNcgF8Udk2GamJKalFCql5yfkpmXnptkrewfHO 8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUBfKSmUJeaUAoUCEouLlfTtbIryS0tSFTLyi0ts lVILUnIKzAv0ihNzi0vz0vXyUkusDA0MjEyBChOyM3btustUcF+yovffXPYGxuMiXYycHBIC JhK3Lq1m7WLk4hAS2MMo8WnhMWYI5xOjxNOFf9khnG+MErP3rGCFaXny/DEjRGIvo8SjSzeh qp4ySpy89pkNpIpFQFWiZe4GdhCbTUBd4sSWZYwgtoiAhsSPbydZQBqYBa6zSNw73AjWICzg KbHqPcgKDg5eAV2JWwucQMK8AoISJ2c+YQGxOQWsJJ53nQLbLCHwhUNizbsTUCe5SDT+ucYM YQtLvDq+hR3ClpL4/G4vG4RdLLFt8WEmiOYGRonNHfehGowlZj1rB7uOWSBT4sP7WUwgR0gI KEscucUCEeaT6DgMCguQMK9ER5sQRKeyxP5l81ggbEmJR2vboc7xkHg96wsLJFBWM0ncO/GS aQKj3Cwk/8xCsm0W0FhmAU2J9bv0IcLyEs1bZzNDhKUllv/jQFKxgJFtFaNUakFxbnpqslGB oW5eajk8xpPzczcxglO9lu8Oxtfr/+odYmTiYDzEKMHBrCTCK/qhJ12INyWxsiq1KD++qDQn tfgQoykwriYyS4km5wOzTV5JvKGJpYGJmZmhuZGpgbmSOG/1jpZ0IYH0xJLU7NTUgtQimD4m Dk6pBqZoxf18AccNmK7Y1zyL4bde1B8R8EiSq3uC2M7auz6ppgmu6pLfNC4zrjyyYbZO17b5 ktL+xumdVk/vTo9hvOp6RjHjuYla7oISaRGJ/+t4QjXsbBdd+ufdbzqn8Z2+tIxcSdur5s5N XbtW3zmgPuX2VHad6hb71RuYV72zjv/e9Hcqt2r+t5RJYjJx19dGhIacn9TV47Viv6tClAvv 3rn33TsP79heMeMed4tr3MotrrY9k9Ta/tntTzy7JrzupN/7wsZ1+6yWPbtxK2nBP/fdNn4r ZTqOtVROD223/MHpkny7+eKSijsbebbWJPSe2jbDUEDDR2vq9r0Tr+9Z1b2XIYh7w2/JW2/m Wk05+FuJpTgj0VCLuag4EQBM/aI6fgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsWy7bCSvO4M9v50g9vXLCwm9hhYzFm/hs3i +rc3jBZPDrQzWsxcm2SxsruZzWLznGKLw3NPslosbFvCYnF51xw2i3tr/rNatH3+BySWbGSy mLhG1GJ2Yx+jA7/Hzll32T0WbCr12LSqk81j06dJ7B5db68weZyY8ZvF48mV6UweCxumMnss 7pvM6tG3ZRWjx7fbHh6LX3xg8jiz4Ai7x+dNcgF8UVw2Kak5mWWpRfp2CVwZH2fMZyr4J1ax 9X4zWwNjk1AXIyeHhICJxJPnjxlBbCGB3YwSC6ezQcQlJWZ9PskEYQtL3G85wtrFyAVU85hR YkN7N1gDi4CqRMvcDewgNpuAusSJLcvA4iICGhI/vp1kAWlgFrjLInH55FawImEBT4lV71cA TeLg4BXQlbi1wAli8WomiZWLSkFsXgFBiZMzn7CA2MxAM//Mu8QMUs4sIC2x/B8HRFheonnr bGYQm1PASuJ51ynGCYyCs5B0z0LSPQuhexaS7gWMLKsYJVMLinPTc4sNCwzzUsv1ihNzi0vz 0vWS83M3MYLjVktzB+P2VR/0DjEycTAeYpTgYFYS4RX90JMuxJuSWFmVWpQfX1Sak1p8iFGa g0VJnFf8RW+KkEB6YklqdmpqQWoRTJaJg1OqgencyRNJnWtuLjnPIXe3Mizr4OP2mYr7W0yZ V4kF7VzE+XnDzHWzVLP6NzcYyqXcNwjrnxB7TeGnwGH5+LiEz4t3dv+KWltaZMWwec2yh3cL Q9dmZB1an/xw6Zqtfb+LvaaEpG9m1Qm0mbqyVIlb8Yf0rkmTlz95rl34xmqbztmZu0o3HW6b s3xj+lEuxnPTL+c8r3+V7yg54cMS3bUpYaXXlAJTlcxWHc1uucFy770De16yCp9Hhbno9rpg O4d08yChGXuvPfbaGnX4joyqNecxo6Mnp575GiPl3Pt03+ftOZNY+lUrHhelz7h1rD7ku2XJ TE7OiZbPb2Vovev4tkLgp4J9/rQrj/xvX+PvDk9VYinOSDTUYi4qTgQAjFE16UoDAAA= X-CMS-MailID: 20250121023401epcas2p2a3d5086caafb9950070c258542dce27c X-Msg-Generator: CA Content-Type: multipart/mixed; boundary="----_tVqzgGyW6tMiW3Z4snM0QQCkibZmALk2DMBUp8NwEyQzDMD=_2a9654_" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250120083041epcas2p30d61ee801c1db5a7ebdf26fdc642883f References: <20250120082908.4162780-1-hyesoo.yu@samsung.com> <20250121005452.GB610565@tiffany> <1495dc28-f16c-4990-ad89-2a90b79a80b8@sk.com> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: AFEFE80004 X-Stat-Signature: igusipxsgk3hg4bsuu75xitp66gx1he5 X-HE-Tag: 1737426846-710844 X-HE-Meta: U2FsdGVkX18DfI2Jzib9x/ANwi/7yS0m0cBOKpMSUYaBkIg5QydZ7jZSMhCw+k3Cc6U13Fzfw45ls8EooAYuLCNCH3Zrrd5sbpS2/MKfWjczV93P5DLylot7ek6t5Uk/SWqL7AC/7u435wtWlzF1aoIlxzbTZ975dgZ1L7bo4J6ihDRoMpiLdrS9phmXl2bfMy+NM5Dd5YGKbWzd+BBXq0FzqU7lcBuy0DDVyHNlmWL2Of6+EbEXrj69cNuLNqM1xs/GL04mtkpQkJV4Nr+l1rQVV726wLRAMkWJVYzAM/Hwz345R8hClsLIxd5ofxUJK9z9HhTDSEnhFtoAYNrCMW2MYqGlHCCZPqsitAWUFyxmZACp5hv2cckg91mqdED9sJXmkhIOjpFz+3rptY6Mqeu+vnWhqjCuCH35DU8/XslaDiFtIk/YRcnLjoayYU3YT3ArcVmgQ0rjfNB8QlS7T1zWsnw8b+3UywejrqMvM1Dq/QsdM8LY/yOJn3zfnf6urgGglSU0iTFQ1blJuvFoJj8vIsZBnkyvU/1Vlt+lWKXwLPOY3ahWfcvffOdXxK8Kovnz8Fkjqlmh0/5Qh6637EyJlfG8MIMVqlGYYiQL2W3ffuaDhd0M3hPqtwE+HSc7PkM6txE1NX/hdloS88uQWZkJn6tJvlfqGXs8CctWoFF35wxYskBbXabh3DP1P0WBsjyCQALlA+6fDIjFbJd2nVUxFH2n4s64vcPqG9wmkICnDhiQUZbFiz3/yi9sW8S5iQSd88n0ShPULoc3dg0/vB9ZT5eaOiDhSvDQoolgSfY+vXGbiJ5eYYwkfvTCU8/Iu3533tVGyTcPLtINd140Rb/uJ4z8yxPnIFWLvwVzF/G6L/5jt/S6fnUCYhh9Z7xN8hlcOdgN8AUymSfJi72jaIKkqzTkQgDllm+UdJ7jCRA2g4HM9ehf90HqKqAZ9sExbN13dmC4wU6gUVi+dX9 b9qMl018 PfrB0RyT043UOLt0AyjYrmOReNSNlz1+yS/yTGaNfWpqL7wanhfbzLulL+cnFJz6Il8rMqAQnMdsfOeZYWiwRe7SNr069MeNh4/7X+MW66HWIKtDKIaLx/jEZdPfuiBFuUYV+txHnA95aMepRfeBZ/v9sBW8plLWE1KQXwaIdM8NB/YIWNql9sPDWakWKrDa3s7h0KIP4efV5AVzLuyhGLpe+GluSKH6O2BBa8Z/7WiZuaPcO+qpgc+N5/pkLKZ/YYyr2O7yV0EMQL64CxcvtFP1ISFml3Y0JLoqvOg4AMk993gpI7Lk6YEeduA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: ------_tVqzgGyW6tMiW3Z4snM0QQCkibZmALk2DMBUp8NwEyQzDMD=_2a9654_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Disposition: inline On Tue, Jan 21, 2025 at 10:48:08AM +0900, Hyeonggon Yoo wrote: > > > On 1/21/2025 9:54 AM, Hyesoo Yu wrote: > > On Tue, Jan 21, 2025 at 12:41:01AM +0900, Hyeonggon Yoo wrote: > > > On Mon, Jan 20, 2025 at 5:30 PM Hyesoo Yu wrote: > > > > > > > > If a slab object is corrupted or an error occurs in its internal > > > > value, continuing after restoration may cause other side effects. > > > > At this point, it is difficult to debug because the problem occurred > > > > in the past. A flag has been added that can cause a panic when there > > > > is a problem with the object. > > > > > > Hi Hyesoo, > > > > > > I'm concerned about this because it goes against the effort to avoid > > > introducing new BUG() calls [1]. > > > > > > And I think it would be more appropriate to use existing panic_on_warn > > > functionality [2] which causes > > > a panic on WARN(), rather than introducing a SLUB-specific knob to do > > > the same thing. > > > > > > However SLUB does not call WARN() and uses pr_err() instead when > > > reporting an error. > > > Vlastimil and I talked about changing it to use WARN() a while ago > > > [3], but neither of us > > > have done that yet. > > > > > > Probably you may want to look at it, as it also aligns with your purpose? > > > FYI, if you would like to work on it, please make sure that it WARN() > > > is suppressed during kunit test. > > > > > > [1] https://docs.kernel.org/process/deprecated.html#bug-and-bug-on > > > [2] https://www.kernel.org/doc/html/v6.9/admin-guide/sysctl/kernel.html#panic-on-warn > > > [3] https://lore.kernel.org/linux-mm/d4219cd9-32d3-4697-93b9-6a44bf77d50c@suse.cz > > > > > > Best, > > > Hyeonggon > > > > Thanks for response. > > > > Using warn() instead of panic, is a great idea. > > Thanks for pointing out what I missed. > > Just for clarification, I think changing the common error reporting > logic (like, slab_bug()) to use WARN() will be preferable to inserting > new WARN()s at random points, which is what this patch does now. > > Best, > Hyeonggon > Thanks you for clarification. Actually, I considered adding BUG_ON() to slab_bug. However if we add BUG_ON() to slab_bug, it will prevent many meaningful error log from being printed subsequently. As you know, slab_bug is the log that usually is printed at the biginning of a bug in the slab. As a result, it would be difficult to figure out the problems based on the logs during our large-scale test-bed. Similary, even if I use WARN() in slab_bug, we won't be able to obtain the logs when panic_on_warn is enabled. I don't think it is useful to include WARN in slab_bug. Instead, I will implement a solution where WARN is only used in slab_fix before slab object is restored. If I add it to slab_fix, I think warning is suppressed on kunit test by slab_add_kunit_errors handling. Thanks, Regards. ------_tVqzgGyW6tMiW3Z4snM0QQCkibZmALk2DMBUp8NwEyQzDMD=_2a9654_ Content-Type: text/plain; charset="utf-8" ------_tVqzgGyW6tMiW3Z4snM0QQCkibZmALk2DMBUp8NwEyQzDMD=_2a9654_--