From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F344CC02181 for ; Mon, 20 Jan 2025 20:48:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 675AD6B0082; Mon, 20 Jan 2025 15:48:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 624FB6B0083; Mon, 20 Jan 2025 15:48:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EC556B0085; Mon, 20 Jan 2025 15:48:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2E2316B0082 for ; Mon, 20 Jan 2025 15:48:40 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A8BB7AECC9 for ; Mon, 20 Jan 2025 20:48:39 +0000 (UTC) X-FDA: 83029018758.19.AFA5EE3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id DF163120009 for ; Mon, 20 Jan 2025 20:48:37 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YF5AcHrl; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737406118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PXVFvRHTd27ZlYt+DehWHJe7xQveQBb3Xs+A0+CPcqQ=; b=K2mQhOjvoEonQi9vxiSqJdyWJEV87oWBKpDynQKAOLmyoNlPIYmjoPcpMaDB2Gv22jWzwt uV6QKjHeb+tSCn7VYUlH+AHe+g/JCGpuhwbZJCkQ2/6SkVokO/bT2dRS/F2H8XeX6g7wr+ oNuK20Rjhg0kIYdf1MhPcP9qj498GR0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737406118; a=rsa-sha256; cv=none; b=UqIZentwkxX4/C195vPV38nqbBByZ522g2XY7z88Nj1TODY/wcHibmLmabPUX1ETaErH/i KI0RTiRmAsBAJYfI6tC7zxzReHN7JhrE+0gvHTiK4KjdJCUpQSAxwo7yjRJ1bIzisp3iPx mas5KFWx7jWUT/NM0rlldRgj68mfUiw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YF5AcHrl; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B843A5C57C7; Mon, 20 Jan 2025 20:47:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD77FC4CEDD; Mon, 20 Jan 2025 20:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737406114; bh=gdh/Zw5Hi+hthd3e2UYqfLZNX0QeFe/TjoVHAm1V7kc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YF5AcHrlmzhoxc1dkwJO+OkyW9qH0QBjTlgNQxcVuTkJ+vII/hOufoj0OtZzXKLWT UU5N76Pm6DJEcfwfmCc6VwfgPG1L86mBDV4PTnlIaS/ghNMeKGdMEESJZW5b3qsVn2 sxl59t3cZTOp8RDUn4iy8EAVWTX9olpfcRPuTpg5OX/PxmAK/4U0DQkIsF+KgzY6Rs /23HgCD0+WNn443OtCBMP4PuWSI5xIBq2US0yPU/IEFWIW6Xjx0oO/hifq0LURC0V2 GziRzNIeDw2mjNiCYbfLV6CO5sQCiMZZ9PDhIGUT5sC0BCOgujXnjfdaBUKSDOLUzy cBtBsioTSxZzQ== From: SeongJae Park To: Usama Arif Cc: SeongJae Park , David Hildenbrand , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH v3 2/2] mm/damon: introduce DAMOS filter type hugepage Date: Mon, 20 Jan 2025 12:48:30 -0800 Message-Id: <20250120204830.40088-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: DF163120009 X-Stat-Signature: uzmuiocd1f3dxk4hh8aqa8of6a3mwzcc X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737406117-845531 X-HE-Meta: U2FsdGVkX18+5uiXsd/UZn+/dFGZuU3k8quXIo66npgbx8430saxmoZ1tgdLQ+kp7Ec0HZQTDr++jBtaEUe4VqHRWCneUQS7IPiryq5ZPKAp4WEtemzVAE63d5VLNBK/U/wMH1A9BZGQzHWMOWaIMcTdonEImNZj0jz0PJdcYDayjTrfND7yAqQ34GR+S0UcAtvykgcsERh0ldjJbpKqsvNSZWdHooQF6GibfFWvrBftywVsMrXGmrWOnQPwC3InQI6sUMzYk+xHvvAXrRvItPpVlwJ9SwV7nmNGwXUKRpwzaIV35UxHEGOiTWp9OWualB7QmXE0Wi1J8B1rmtS+IfhQ4zeGBwVRNZjGP4qYGjjR8hbcV9a/srKmXmi70cRRfMq3j8294laqH17UR1OJfjXf54D0APJNoZ5R1qJQeN6oTNhg01MtMi+iGRfE6P/piuQxDD1ttxK+/xu2ofuhkLjpNj88pELe4/JMFkMdocI3tnvl9Ed13NRrt3l8nBiQow+GgITXzYK2nAs6ez6k2hhd+W0bE3AkcV27boKRSievgkRP+3JJsdtbntASdZiLshXt+ktlBNxI7le7LlfDKnI+aqjLLE7K5eczwGGBp1E2ySp1Jlsj33AQc/4cilbgaMmdGTVUei6wYsmr23u8BDFbESFqHR3pGF9MOL2X6nRfOVDBAYwb8jViyKdZkkuAao4wEOfM/hLjbfI2xdoU2LH2mJlKLGKoAMFulG15gfquSSMfsJIe/EM6sY3MemTtstkHnNHF576OQjHUN8mcIpksiyZIhZVgcrzVvejYw8/j9WJSclYIcmsjKV9pu2NHQDQ5vJw+Mh0Pggzc8IXaOT2lx8bNIl+T82WQNl/5svFcKONwsczM9pcBzh73vtmbSYWBONeF+IgthMS5HNxHa4t0Xl7uf3wSiibGk28nEehMn6wYESzpKK57uFwKor6yDPimlaUsUSjLYDfDo72 HPLkdMr6 N2hV/Yp3g4VW8t3YlzzrAeAhQYh0/yLZRIvkmy8O/HjYNveBLnla3CpbfiNZGrs9Abz1Hl9f46Mwtnwxa7dpJLDB7IH84cCcLBThKifpRcd8XCJa6eGo9t+a8vl+cGJ25iu5kyWqiPA9POkhUKWjOENx++0t3K+1ACp1n+NQILrX5UTTews0jE9iwfH8OaPJ6YgvgT27yck5FAde/T3ghZRXtZQxFMieq6nAN9UKQGU2Qy/ajXGoef3pwjpXh6JxzWFz7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 20 Jan 2025 20:26:02 +0000 Usama Arif wrote: > > > On 20/01/2025 20:12, SeongJae Park wrote: > > On Mon, 20 Jan 2025 19:58:24 +0000 Usama Arif wrote: > > > >> > >> > >> On 20/01/2025 19:30, SeongJae Park wrote: > >>> On Mon, 20 Jan 2025 20:23:20 +0100 David Hildenbrand wrote: > >>> > >>>> On 20.01.25 20:16, SeongJae Park wrote: > >>>>> On Mon, 20 Jan 2025 19:57:10 +0100 David Hildenbrand wrote: > >>>>> > >>>>>> On 20.01.25 19:19, Usama Arif wrote: > >>> [...] > >>>>>>> +#if defined(CONFIG_PGTABLE_HAS_HUGE_LEAVES) > >>>>>>> + case DAMOS_FILTER_TYPE_HUGEPAGE: > >>>>>>> + matched = folio_size(folio) == HPAGE_PMD_SIZE; > >>>>>> > >>>>>> > >>>>>> Can we directly embed in the name and the comments/docs that we are only > >>>>>> talking about PMD size (both, THP and hugetlb)? > >>>>>> > >>>>>> DAMOS_FILTER_TYPE_PMD_HUGEPAGE or sth. like that. > >>>>> > >>>>> Nice suggestion, thank you! And we might later add more filter types for > >>>>> different size huge pages. What about extending this to handle more general > >>>>> case, though? That is, we can let the filter receives a range of the folio > >>>>> size to match, like DAMOS_FILTER_TYPE_ADDR does. Then, the filter could be > >>>>> used for any size of interest. > >>>> > >>>> That would probably be future proof: either a range or explicitly > >>>> specified sizes (ranges?). > >>> > >>> DAMON supports installing multiple DAMOS filters. So multiple DAMOS filters > >>> that each matching single range can be used for the multiple sizes or ranges > >>> use case. > >>> > >>> > >> > >> Does creating something like schemes//access_pattern/page_size/{min,max} > >> sound good? with the default value being pmd size? > > > > For user-space ABI, like DAMOS_FILTER_TYPE_ADDR, let's use > > 'schemes//filters//' directory. File names 'min' and 'max' look good to > > me. > > > > For kernel-space API, again, like DAMOS_FILTER_TYPE_ADDR, let's use the union > > in 'struct damos_filter'. > > > > If you will do the extension together with this patch, I think the default > > value is not really needed. It will only add a bit of complexity. So if you > > will do so, I'd recommend not having the default value. > > > > Also, if you will revise this patch series for the extension, could you please > > split and post the first patch of this series as a separate one? I think the > > fix is important and has no reason to be tied with this patch. > > > > Yeah I think it might be best if we get a version with flexible folio sizes merged > from the start, especially as it involves creating user ABI. I will try and send > something tomorrow. Makes sense, looking forward to the next spin! > > For the first patch, do I need to resend? Or maybe Andrew could merge whats in > this v3 for patch 1, we discard patch 2 and I just send the hugepage > filter implementation separately as a new series.. I think the first patch is important but not urgent. I'd suggest to drop it from the next revision of the filters extension series, and resend it if Andrew neither pick it nor ask some action by a few days or weeks. Thanks, SJ