From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB6E8C02182 for ; Mon, 20 Jan 2025 20:12:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B61B6B007B; Mon, 20 Jan 2025 15:12:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 365246B0083; Mon, 20 Jan 2025 15:12:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2540E6B0085; Mon, 20 Jan 2025 15:12:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 093726B007B for ; Mon, 20 Jan 2025 15:12:21 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A9BE21C550E for ; Mon, 20 Jan 2025 20:12:20 +0000 (UTC) X-FDA: 83028927240.13.3CC99A2 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf09.hostedemail.com (Postfix) with ESMTP id 1594E140008 for ; Mon, 20 Jan 2025 20:12:18 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aA6U5ZF6; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737403939; a=rsa-sha256; cv=none; b=xB5WhGsDxIS3zLdrqqyxyDA2JroeDpG/4ZTTfZ+Yv321MFG6UBo7mI0k9wdN3u+8+2zi6o u9MZytRAvsfsJUTOlXvzkZ2heK0ycgS/pgjZvctnZGXWjcCq17B2+/MmfCABUa0Nk+gvzE t+pqFiWjr4q94yP3hvM9TjrWi/xhsyA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aA6U5ZF6; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737403939; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5a1t9nY85ghhBDPGSBPqNs5MXO8HzGHvz0nA0r283hE=; b=Tx+VUAkP0i0dxOiq4TgGBPnUueQPazd207XU6UhtI7EJgvEaW4obbizGXJAua0lY48C3iZ 4vVPz5alcjSXf8zOdMd9pB7tqYeglkAh9KcDyrXSvEt+GxGon63QJ46VYK0SEWYSVeeHEK lxQlUoSui2Gc69jyBdAyx02UGgWsMB4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C34CDA40148; Mon, 20 Jan 2025 20:10:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB231C4CEE0; Mon, 20 Jan 2025 20:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737403938; bh=78cwvxWzowYMPOAQ/P3Gv/HhiJtvYHGT6olSBLC4/yY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aA6U5ZF6Fs322VyQSWlIkjTmk72N3NyHzMewlm7Fb9RdB8L5bmPyTuwBVS6IpKEcn hl8L/NO0H2lu4U2Qzb3ENMs0R2KUcXnVtMS6mRj+m8GIQh70xN9KHAH5u2MiE2mqep tHZBFMuuZaNVQV8O//rLo7xijqnQ5V2g8kxN/0D0HXLbRYnaXTosdXZHjWgBFY86DJ 3cPo9o3NP9FqtKG9X5dQvmdM9bI6/cGCTFomGbcZaBnqoMovULN8mwWHSTYREjETi5 VPiGV5wa2Kp8C0/PyFwXq9bqy2Vmu5iEDVQO2zTDGVgflnhgBrsdKyN30gRhM0C58a vYC+6G8IsG7yg== From: SeongJae Park To: Usama Arif Cc: SeongJae Park , David Hildenbrand , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH v3 2/2] mm/damon: introduce DAMOS filter type hugepage Date: Mon, 20 Jan 2025 12:12:14 -0800 Message-Id: <20250120201214.39533-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <3b461f19-45b7-4e74-969d-1cdf4d324353@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1594E140008 X-Stat-Signature: noeb834mrdzjxzmsng37y6eo8kpauzzw X-HE-Tag: 1737403938-450841 X-HE-Meta: U2FsdGVkX18tvp6mr7seJP271YZtx/BjwRWiRLsoL/chmfGjDTfJd64W59LJb6FbQJXEHdt9BXbjMv2zLj+gc8e1xreAa4Yr6j7k5LtZlcVux5GHrKhPEc8/CKGidA+fxc7dKdT5eLldjD+xPBAsC62XXRR+tR8eqQ2WNL8XBZcaKuNbns8O2WmPe2nP0ewXQSKTghbSq2hO81R50Rdyxy4XjTvnUeNEN49HFQutLhsn4ujKTrUbU9Hhuz2in6ShyiaXf8l3r6LIdJhjCrEsj8SWpnI4+xx+t+4T3Uu/k+zMVlo26TbR0TPGU82GNvLlHFvceNfuf5W1/gHnM99T81GXCJYOkhgfuSofKALHE7IPZ3f3sQCvZVw+SVk22xUHdwQXIbucvP69dVTyxHu4lhow6QOvw5YnNetAmjNG2l7bAvDabeRORUaZm4MO0w+PJHYRl/9KoIP1PJtyw+JJGMDc3kwewQwUoap9d558bpWxAtIzR81H/cMPjNnbsIv8qr7zQhlnI2Yb3huD4Mrcb1HI6MAsiHNez5dWfz7xCFAoOeqMgjDJmXZwPw2m3G0d1oxWmRWOYNv4ZQKu6Fvvn4swXdAcH6Psx2yB4qjoVkyOEPWZYeApDF9na0s0lbq1xcZnawH6O+/GBDadBCR/fhM8Kue1ojiJJBHcR01LrfC32l9YBGzEuD2fwNzvHm2/G2f2WgLKUa2AoFhcYECle7Fz76inM/nb+JjRfhBAmvT29NWIoQMUD+mrI6tqIa+owFKz2y1dCTcdLVMQDQR7bGq+w3jN+Q8CPT9FfjjJK83ynC6PdchUNGiSTGGwElwX+hrILeZkdygU9GtGpMKa2KZUtMRbHVkL0g2Gd6MjiaVl8AE98lpVNq3G+8GQRCaAtwXqHmoZmjJAkOSMmi3w8HF2TVKd7xKI2y9/mFf+QPI4p0JBVpU1mruRfASwzQrNbZf/obwa/A9YVbw4t5d IRMNhpeV MgxmHS9XyHHI3yzLsxvXR4GWb/Gd2nuo2JdY3CpwMtS+ZfV8SqnwSesC9/GKUcsHNFz9/cRacssjWFHPodgXKm06tFFUeRMrby7G7Y3srUke9fvfyC+KsOfm7bnsQ/vNlK4aVhmsJ3OSexh+5nJgApCfHDRT+z3xiAgcP7d3RrYfTvdzUFYCLBLrYHtuimeC7Xyqs/WBrLQUV0B0Dlpmt4VAtBjRMQ8LniuU2ua4+SLEgnc1n834985C5AQkTuXkBlX6n X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 20 Jan 2025 19:58:24 +0000 Usama Arif wrote: > > > On 20/01/2025 19:30, SeongJae Park wrote: > > On Mon, 20 Jan 2025 20:23:20 +0100 David Hildenbrand wrote: > > > >> On 20.01.25 20:16, SeongJae Park wrote: > >>> On Mon, 20 Jan 2025 19:57:10 +0100 David Hildenbrand wrote: > >>> > >>>> On 20.01.25 19:19, Usama Arif wrote: > > [...] > >>>>> +#if defined(CONFIG_PGTABLE_HAS_HUGE_LEAVES) > >>>>> + case DAMOS_FILTER_TYPE_HUGEPAGE: > >>>>> + matched = folio_size(folio) == HPAGE_PMD_SIZE; > >>>> > >>>> > >>>> Can we directly embed in the name and the comments/docs that we are only > >>>> talking about PMD size (both, THP and hugetlb)? > >>>> > >>>> DAMOS_FILTER_TYPE_PMD_HUGEPAGE or sth. like that. > >>> > >>> Nice suggestion, thank you! And we might later add more filter types for > >>> different size huge pages. What about extending this to handle more general > >>> case, though? That is, we can let the filter receives a range of the folio > >>> size to match, like DAMOS_FILTER_TYPE_ADDR does. Then, the filter could be > >>> used for any size of interest. > >> > >> That would probably be future proof: either a range or explicitly > >> specified sizes (ranges?). > > > > DAMON supports installing multiple DAMOS filters. So multiple DAMOS filters > > that each matching single range can be used for the multiple sizes or ranges > > use case. > > > > > > Does creating something like schemes//access_pattern/page_size/{min,max} > sound good? with the default value being pmd size? For user-space ABI, like DAMOS_FILTER_TYPE_ADDR, let's use 'schemes//filters//' directory. File names 'min' and 'max' look good to me. For kernel-space API, again, like DAMOS_FILTER_TYPE_ADDR, let's use the union in 'struct damos_filter'. If you will do the extension together with this patch, I think the default value is not really needed. It will only add a bit of complexity. So if you will do so, I'd recommend not having the default value. Also, if you will revise this patch series for the extension, could you please split and post the first patch of this series as a separate one? I think the fix is important and has no reason to be tied with this patch. Thanks, SJ