From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5573AC02181 for ; Mon, 20 Jan 2025 19:30:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDAD36B0085; Mon, 20 Jan 2025 14:30:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D8A4C6B0088; Mon, 20 Jan 2025 14:30:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C79196B0089; Mon, 20 Jan 2025 14:30:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AAC396B0085 for ; Mon, 20 Jan 2025 14:30:22 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2ECAF1202FF for ; Mon, 20 Jan 2025 19:30:22 +0000 (UTC) X-FDA: 83028821484.21.34D15ED Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf17.hostedemail.com (Postfix) with ESMTP id 8F4274001E for ; Mon, 20 Jan 2025 19:30:20 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TJbRBFBw; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737401420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KxAL4BoGfe/9Z7lGUyTMtutXAOpVe9Vqvxi8ZP1ZUek=; b=sviykjlL+EaWV+0I/xCwD5ez2UOOA27C78BMGT6pdbrS6WYlrIHcXhdqxxYrnSDjLx2jtP t+9SdJNIANSHvdJ/rUljqXpdvipvkwTx7Nbv0ErIXbq+DGkxo2lck0OKwUnNTeb4mMMZ8D C0WUdYQwsXtwL48ndoeyL09A3KIVObU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737401420; a=rsa-sha256; cv=none; b=21Dn/AdajQubuOvrAnJo2oDilLIOrIQHLWYNqUQLOrLU97N8wl0vh4Z3rKtkprtAqwtxPe mnOelTY5cmcrYyuG+EG1YcXraXs+HiDAhA87V59v8nsbqWbbgx4++Tx8exiB7ItlsocG6s wvQlUFqpcfbzd8maqxsTiGNRd3k+8Lw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TJbRBFBw; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3F1BFA413ED; Mon, 20 Jan 2025 19:28:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64949C4CEDD; Mon, 20 Jan 2025 19:30:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737401419; bh=MsHAwJxqXzNPCCQgAFjJH/pOsANQIx5hNNxm2MOvnbI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TJbRBFBwE/FBMw9XG7rlBihbjApSgmh66Sx9/IImCXxkS6hW0+Jwt23VJT8v3d1ud UB0jbZ+mznc2W6TADEILruO1Ne0CkO1jmVvzhfyHOHUAqMt2rc8cj6AqitQ9n6lGdw DGX842FjIM0pxNk3g79Ta4NgyfWep2EZIQIovWpcFD7iTrNlXvc3n2qZ2DnwKOTEyb 41X4f/JdhuWFcDwgWVFVJaE9OYPkMPiIFivISylWyfcA9E2rL4MxMVxIubP4KvqFyh gmi7p0LeoRDxBv8+xWRtzBpYGYkJ3X4qv8ZrS+g7StqCNzRL2j/Z3tbyqLXXc95Skx 4Naiipd0Ft7Ig== From: SeongJae Park To: David Hildenbrand Cc: SeongJae Park , Usama Arif , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH v3 2/2] mm/damon: introduce DAMOS filter type hugepage Date: Mon, 20 Jan 2025 11:30:15 -0800 Message-Id: <20250120193015.38753-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 8F4274001E X-Stat-Signature: upnye4bue8qrnw7tiaote7j1mgni8pcg X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737401420-809510 X-HE-Meta: U2FsdGVkX199bfUUQjveMuNaXGnFllW/U5QYKZPUlpX3Wf9r/RaF4jtlOe5OY1oBiFVE0eXiZ8Tw/d8xdLpNQpgMhq/aLm/aAFjaRtgMGMLngDonpihGjV9dcoc6NgoKSF/TXt7wZt0sXbmB6g3wUVlqjRx4MzCPLUiCBwEDAX0oVJlx7fbeKeDMoIMBDOH87GBL4qnzaXHihupv7LrOeM/2A75+d0g1OhAJBSNFL5kQ9lWkRAf8ZVpu8O1oZ52GTI8piv3JTSOQnyVCPBz+hK6ehEItggYoXUPCyizY0eoX/qH27dBkvmIm+0XhbVocImuKo+PGA8kK+C25TDvUdF7nCCNw4uJwza5+OiyyvGLT6m3GDX2ROsWKXH4UmMJCP1DMl02pMc/EqRZxnJcx93L2bB3CDKUMeJOTZFmOtA0DfyczrtPpTBfnAZ15xWjrgHuZgSx9Ip4gByEKdkyTC4Z1mY15RlOia9CLp09qXNCH/2279oDcG85gcXBHnvGuNIIyfQEtJ0KVFmNi+FRb/ljVk0CpnfKvxuQGxEOrw99OHBEPD5dAcMevdWVM4BNYVFbXIyKWpbjZZOTH8/TrYHVcAUeUTSttlzRRt1YPlWE+ZViavhqAw7STuJF46dgkAuUJMUg8Bau9LoVzYF6kBUEW2n5D+m6eVUsJvXjA/XsaKodFizlvLOWfuodlDiOsqb6q6znn0sKOEeFscKEjrTYd90YiIgsoSx1d/bCE5FWtfmeNNdcV0IIqUCBWmyMupaiHsO48Huo2cSD5gY1IFOl5slEoFYEBbLQ2y66GW8b5RIMKOQq1AjZUr28vF/mJc3Rx866/UaMSzHvApavs6iiNicY2QywrYwE3mM668IdnIKCjM4Uv/XvYrTy9Sf/JqhmJcq7NcsYzkICWK92iVQtVyM56wrNHewGuDFfPDkoCyP7RrDtxgczATIcYaohWgiRbwcsQEW+KZAcYRwC QrCeX7QH ihjdFd3mhv7nOuam5zGUug3q+Sjr67+8VvG/WQ5qXnUQrUivwMl6pXgDCy4wJc2KFufg4wP8NKlAkyA89VdN+5Ao4rFNklnzea7lQWH+X30YZuq1CkGd3dFC88oImGBxr/M6lLu9NHmwYrEJnga+0tTqxhbr456OM/Z92JT8vneAQyYB3nju0tyOWuSpIDLU6unms4unOjaQfRwMJ6W56e+qirTNuNDHfFhUO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 20 Jan 2025 20:23:20 +0100 David Hildenbrand wrote: > On 20.01.25 20:16, SeongJae Park wrote: > > On Mon, 20 Jan 2025 19:57:10 +0100 David Hildenbrand wrote: > > > >> On 20.01.25 19:19, Usama Arif wrote: [...] > >>> +#if defined(CONFIG_PGTABLE_HAS_HUGE_LEAVES) > >>> + case DAMOS_FILTER_TYPE_HUGEPAGE: > >>> + matched = folio_size(folio) == HPAGE_PMD_SIZE; > >> > >> > >> Can we directly embed in the name and the comments/docs that we are only > >> talking about PMD size (both, THP and hugetlb)? > >> > >> DAMOS_FILTER_TYPE_PMD_HUGEPAGE or sth. like that. > > > > Nice suggestion, thank you! And we might later add more filter types for > > different size huge pages. What about extending this to handle more general > > case, though? That is, we can let the filter receives a range of the folio > > size to match, like DAMOS_FILTER_TYPE_ADDR does. Then, the filter could be > > used for any size of interest. > > That would probably be future proof: either a range or explicitly > specified sizes (ranges?). DAMON supports installing multiple DAMOS filters. So multiple DAMOS filters that each matching single range can be used for the multiple sizes or ranges use case. Thanks, SJ > > -- > Cheers, > > David / dhildenb